feat: add tonic plugin to provenance buf config so grpc client/servers are generated - guarded by grpc and grpc-transport features #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are generated - guarded by grpc and grpc-transport features
scirner22
commented
Aug 9, 2024
| @@ -20,6 +20,4 @@ prost-types = { workspace = true } | |||
| quote = "1.0.26" | |||
| regex = "1" | |||
| syn = { version = "1.0.109", features = ["full", "parsing", "extra-traits"] } | |||
| tonic = "0.7" | |||
There was a problem hiding this comment.
since we leverage buf for generation, these deps aren't needed
scirner22
commented
Aug 9, 2024
| @@ -11,5 +11,5 @@ use provwasm_proc_macro::{CosmwasmExt, SerdeEnumAsInt}; | |||
| ::schemars::JsonSchema, | |||
| CosmwasmExt, | |||
| )] | |||
| #[proto_message(type_url = "/cosmos.authz.module.v1.Module")] | |||
| #[proto_message(type_url = "/cosmos.app.module.v1alpha1.Module")] | |||
There was a problem hiding this comment.
@kwtalley there's many changes like this that I wasn't expecting as it seems like this change is going backwards? Were there manual changes to these files or were they last generated with a different version of cosmos or something?
|
I just realized Ken has this work in progress as of last week in StatusHero. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no grpc client/server generation of Provenance types. These types aren't useful from a smart contract perspective, but as a general purpose crate containing rust bindings for Provenance types, they are useful to have.
New types are wrapped with
grpcandgrpc-transportfeatures.Deprecates https://github.com/provenance-io/provenance-rs so we can maintain bindings in a single place.