Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the security contract #139

Merged
merged 112 commits into from
Feb 29, 2024
Merged

Adds the security contract #139

merged 112 commits into from
Feb 29, 2024

Conversation

Taztingo
Copy link
Collaborator

@Taztingo Taztingo commented Feb 5, 2024 •
edited
Loading

A new contract has been built that allows users to easily create, modify, and query for assets that are linked against a security type.

Issue: #138

@Taztingo Taztingo self-assigned this Feb 5, 2024
Taztingo added 28 commits February 6, 2024 10:04
@Taztingo
Initial update of converting template to nav contract. Still need to …
9efee7b 
…clean up a few more things and add the actual logic.
@Taztingo
Add event for set tag.
7a0734d
@Taztingo
Simplify storage::tag for now, and add comments.
024af8b
@Taztingo
Add some basic logic for set_tag.
dea84b5
@Taztingo
Provide a way to remove an asset's tag.
ea36ce8
@Taztingo
Add remove_asset_tag func.
1714a58
@Taztingo
Update execute funcs to not take funds.
eb0ef20
@Taztingo
Add error for invalid asset. Add validation to check if asset exists …
ad4e107 
…as either marker or scope.
@Taztingo
Remove reply entrypoint since it's not needed.
ae3e2dc
@Taztingo
include change that was missed in previous commit.
d4e8f15
@Taztingo
Add query_address. Remove validation since it's done by set.
b3cbaf8
@Taztingo
Fix unused imports and args.
82b205c
@Taztingo
Rename project to nav-tag.
119eeea
@Taztingo
Replace deprecated functions to_binary and from_binary.
ea88fdf
@Taztingo
Update optimizer.
244c218
@Taztingo
Move old store known as tag.rs to asset.rs. Create new store known as…
0390af8 
… tag.rs for tracking types.
@Taztingo
Add query for getting all the accepted tag types.
b3be920
@Taztingo
Add messages for adding and removing tag types. Still need to impleme…
0a7eb7a 
…nnt the handler.
@Taztingo
Add UpdateTagTypes event. Create actions for add and remove tag types…
d470800 
…. Add logic for add tag type.
@Taztingo
Start remove logic, but need a way to quickly check if an asset uses …
8cf09f1 
…a tag.
@Taztingo
Add temporary unfilled functions to the asset storage until I figure …
0d89adf 
…out best way to store them. Update logic for remove_tag_types.
@Taztingo
Add logic to set_tag to verify that the tag being used is valid.
1603626
@Taztingo
Add TODO so I don't forget to include logic.
ebfb8dd
@Taztingo
Add additional map for quick tag lookup and asset by tag retrieval.
bda6bc0
@Taztingo
Include logic for adding and removing entries from TAG_TO_ASSET lookup.
99a6c24
@Taztingo
Add tag types to init so we have a choice to populate them initially.
05cad06
@Taztingo
Fix function documentation and testing for instantiate.
c17ba2a
@Taztingo
Add tests for tag storage.
4bc3d24
@Taztingo Taztingo changed the title Adds the nav contract Adds the security contract Feb 27, 2024
@Taztingo Taztingo marked this pull request as ready for review February 27, 2024 20:00
@Taztingo Taztingo requested a review from kwtalley as a code owner February 27, 2024 20:00
kwtalley
kwtalley requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@kwtalley kwtalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor updates, otherwise looks awesome!

contracts/security/src/storage/asset.rs Outdated Show resolved Hide resolved
contracts/security/src/storage/security.rs Outdated Show resolved Hide resolved
contracts/security/Makefile Outdated Show resolved Hide resolved
contracts/security/Makefile Outdated Show resolved Hide resolved
@Taztingo Taztingo merged commit 1c27cda into main Feb 29, 2024
8 checks passed
@Taztingo Taztingo deleted the taztingo/138-nav-contract branch February 29, 2024 20:42
@kwtalley kwtalley mentioned this pull request Mar 1, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwtalley kwtalley kwtalley approved these changes

@nullpointer0x00 nullpointer0x00 Awaiting requested review from nullpointer0x00

Assignees

@Taztingo Taztingo

Labels
None yet
Projects
Provenance Core Protocol Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taztingo @nullpointer0x00 @kwtalley