Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dwedul/no params key #2188

Closed
wants to merge 1 commit into from
Closed

Conversation

SpicyLemon
Copy link
Contributor

Description

Remove the params store key and transient store key from the app.

This is in draft because I need to test the upgrade again.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Added relevant changelog entries under .changelog/unreleased (see Adding Changes).
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@SpicyLemon SpicyLemon changed the base branch from main to release/v1.20.x October 16, 2024 20:59
@SpicyLemon
Copy link
Contributor Author

SpicyLemon commented Oct 16, 2024

Closing this PR in favor of:

Need to get the change to main first, then will backport it to release/v1.20.x.

@SpicyLemon SpicyLemon closed this Oct 16, 2024
@SpicyLemon SpicyLemon deleted the dwedul/no-params-key branch December 4, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant