Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark v1.19.1 and fix mainnet CLI queries. #2109

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Jul 25, 2024

Description

This is a frontport of the following PR to main:

It updates the changelog to mark v1.19.1 and fixes the mainnet queries.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Summary by CodeRabbit

  • New Features

    • Enhanced command flexibility by allowing users to specify testnet mode via a command-line flag or environment variable.
  • Bug Fixes

    • Resolved an issue with the Human Readable Prefix (HRP) in CLI queries for improved accuracy.
  • Documentation

    • Updated the CHANGELOG to include version v1.19.1, detailing improvements and fixes for better user awareness.

* Look up the testnet flag the hard way when initially creating the root command.

* Mark v1.19.1.

* Add blurb.
@SpicyLemon SpicyLemon requested a review from a team as a code owner July 25, 2024 22:42
Copy link
Contributor

coderabbitai bot commented Jul 25, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent updates introduce a new version v1.19.1, primarily addressing a bug related to Human Readable Prefix (HRP) in CLI queries. Additionally, significant improvements were made in the command configuration logic, allowing dynamic handling of the testnet mode based on user input. These changes enhance usability and clarity while ensuring that users can easily track modifications and issues addressed in the release.

Changes

File(s) Change Summary
CHANGELOG.md Added version entry for v1.19.1 with bug fix related to HRP in CLI queries.
cmd/provenanced/cmd/root.go Updated NewRootCmd to use isTestnetFlagSet(), improving command flexibility. Introduced isTestnetFlagSet() function for better testnet state management.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant App

    User->>CLI: Execute command
    CLI->>App: Check for --testnet flag
    App->>CLI: Return testnet status
    CLI->>App: Proceed with command based on user input
Loading

🐇 "Oh, change is afoot, hop, skip, and bound,
New flags and fixes, let joy abound!
With testnets set right, our paths now align,
In code we trust, our futures entwine!
So let's leap for joy, with each little fix,
In the garden of code, it's magic we mix!" 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SpicyLemon SpicyLemon enabled auto-merge (squash) July 25, 2024 22:46
@SpicyLemon SpicyLemon merged commit 50dc3d8 into main Jul 25, 2024
31 checks passed
@SpicyLemon SpicyLemon deleted the dwedul/fix-queries-main branch July 25, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants