Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Remove the config warnings from the store loader: #2095. #2096

Merged
merged 1 commit into from
Jul 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ Ref: https://keepachangelog.com/en/1.0.0/

## [Unreleased]

* nothing
### Improvements

* Remove the warnings about some config settings [2095](https://github.com/provenance-io/provenance/pull/2095).

---

Expand Down
7 changes: 2 additions & 5 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ func New(
// Register upgrade handlers and set the store loader.
// This must be done after the module manager, configurator, and pre-blocker are set,
// but before the baseapp is sealed via LoadLatestVersion() below.
app.registerUpgradeHandlers(appOpts)
app.registerUpgradeHandlers()

if loadLatest {
if err := app.LoadLatestVersion(); err != nil {
Expand Down Expand Up @@ -1045,7 +1045,7 @@ func (app *App) setFeeHandler() {
app.SetFeeHandler(msgFeeHandler)
}

func (app *App) registerUpgradeHandlers(appOpts servertypes.AppOptions) {
func (app *App) registerUpgradeHandlers() {
// Add the upgrade handlers for each release.
InstallCustomUpgradeHandlers(app)

Expand Down Expand Up @@ -1078,9 +1078,6 @@ func (app *App) registerUpgradeHandlers(appOpts servertypes.AppOptions) {
if storeLoader == nil {
storeLoader = baseapp.DefaultStoreLoader
}

// Verify configuration settings
storeLoader = ValidateWrapper(app.Logger(), appOpts, storeLoader)
app.SetStoreLoader(storeLoader)
}

Expand Down
91 changes: 0 additions & 91 deletions app/store_loader.go

This file was deleted.

Loading
Loading