Set scope navs in umber upgrade. #2085
Conversation
WalkthroughThis update enhances the application's handling of scope NAVs by introducing new constants for mainnet and testnet configurations, improving test coverage, and incorporating robust error handling in the upgrade process. The changelog entries provide clarity on recent improvements, including the successful implementation of new functionalities, enhancing both the organization of constants and the overall upgrade mechanics. Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant UpgradeProcess
participant AddScopeNAVs
App->>UpgradeProcess: Initiate upgrade
UpgradeProcess->>AddScopeNAVs: Call addScopeNAVs()
AddScopeNAVs-->>UpgradeProcess: Return success or error
UpgradeProcess-->>App: Complete upgrade with status
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
app/upgrade_files/umber/mainnet_scope_navs.csvis excluded by!**/*.csv
Files selected for processing (5)
- CHANGELOG.md (1 hunks)
- app/scope_navs_updater.go (1 hunks)
- app/scope_navs_updater_test.go (1 hunks)
- app/upgrades.go (1 hunks)
- app/upgrades_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- app/upgrades_test.go
Additional comments not posted (4)
app/scope_navs_updater.go (1)
12-15: LGTM! The constant declaration is well-organized.The addition of
umberMainnetScopeNAVsFNis appropriate and enhances the organization of constants.app/scope_navs_updater_test.go (1)
35-48: LGTM! The new test case is well-structured.The addition of the test case for mainnet Scope NAVs enhances test coverage.
app/upgrades.go (1)
150-154: LGTM! The new function call with error handling is well-implemented.The addition of
addScopeNAVswith error handling improves the robustness of the upgrade process.CHANGELOG.md (1)
43-43: LGTM!The new entry under the "Improvements" section is clear, follows the existing format, and includes a link to the relevant PR.
* Add a file with the mainnet navs in them and make sure it can be parsed properly. * In the umber upgrade, set the scope navs using the mainnet data. * Add changelog entry. * update scope data * add tests for new navs csv * fix files with proper block height for more recent --------- Co-authored-by: Carlton N Hanna <[email protected]>
* Add a file with the mainnet navs in them and make sure it can be parsed properly. * In the umber upgrade, set the scope navs using the mainnet data. * Add changelog entry. * update scope data * add tests for new navs csv * fix files with proper block height for more recent --------- Co-authored-by: Carlton N Hanna <[email protected]> Co-authored-by: Ira Miller <[email protected]>
Description
This PR adds a step to the umber upgrade that will set the NAV info for a bunch of scopes.
It's in "draft" until we get a final updated csv of the entries.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
Improvements
Logging Updates