Bump github.com/cosmos/iavl to v1.2.0 (from v.1.1.2). #2076
Conversation
WalkthroughThe update involves bumping the version of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
CHANGELOG.md (1)
58-58: LGTM! But fix the unordered list style.The code change to bump the
github.com/cosmos/iavldependency is approved.However, the unordered list style should use an asterisk instead of a dash to maintain consistency with the rest of the file.
- - Bump `github.com/cosmos/iavl` from 1.1.2 to 1.1.4 ([#2076](https://github.com/provenance-io/provenance/pull/2076)) + * Bump `github.com/cosmos/iavl` from 1.1.2 to 1.1.4 ([#2076](https://github.com/provenance-io/provenance/pull/2076))Tools
Markdownlint
58-58: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- go.mod (1 hunks)
Files skipped from review due to trivial changes (1)
- go.mod
Additional context used
Markdownlint
CHANGELOG.md
58-58: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
CHANGELOG.md (1)
62-62: Use asterisks for unordered list items.Markdownlint suggests using asterisks instead of dashes for unordered list items.
- - Bump `github.com/cosmos/iavl` from 1.1.2 to 1.1.4 ([#2076](https://github.com/provenance-io/provenance/pull/2076)) + * Bump `github.com/cosmos/iavl` from 1.1.2 to 1.1.4 ([#2076](https://github.com/provenance-io/provenance/pull/2076))Tools
Markdownlint
62-62: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
Markdownlint
CHANGELOG.md
62-62: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Additional comments not posted (1)
CHANGELOG.md (1)
62-62: Verify the dependency bump entry format and information.The entry for bumping
github.com/cosmos/iavlfrom1.1.2to1.1.4looks correct. Ensure that it includes the pull request number.Tools
Markdownlint
62-62: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
…venance into dwedul/bump-iavl-1.1.4
SpicyLemon
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
CHANGELOG.md (1)
62-62: Fix unordered list style.Expected: asterisk; Actual: dash
- - Bump `github.com/cosmos/iavl` from 1.1.2 to 1.2.0 ([#2076](https://github.com/provenance-io/provenance/pull/2076)) + * Bump `github.com/cosmos/iavl` from 1.1.2 to 1.2.0 ([#2076](https://github.com/provenance-io/provenance/pull/2076))Tools
Markdownlint
62-62: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- go.mod (1 hunks)
Additional context used
Markdownlint
CHANGELOG.md
62-62: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Additional comments not posted (2)
go.mod (1)
215-217: Verify the impact of the iavl version update.The version of
github.com/cosmos/iavlhas been updated fromv1.1.2tov1.2.0to fix the node stop/start app hash problem.Ensure that this update does not introduce any compatibility issues with other dependencies or functionalities.
CHANGELOG.md (1)
62-62: LGTM!The dependency bump aligns with the PR objectives to resolve the apphash issue.
Tools
Markdownlint
62-62: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
* Bump iavl to v1.1.4 (from v1.1.2). * Add changelog entry. * Bump iavl to 1.2.0 instead since a wasm bump will need it.
* Bump github.com/cosmos/iavl to v1.2.0 (from v.1.1.2). (#2076) * Bump iavl to v1.1.4 (from v1.1.2). * Add changelog entry. * Bump iavl to 1.2.0 instead since a wasm bump will need it. * Bump wasmd to v0.52.0 (from v0.51.0) and wasvm to v2.1.0 (from v2.0.1). (#2077) * Update go.mod with latest wasmd fork and wasmvm. * Update PR number in log. * Update supported features. * Update third_party protos. * Fix Changelog. * Fix Changelog. --------- Co-authored-by: Daniel Wedul <[email protected]> * Update buf.lock to latest commit hash (#2080) --------- Co-authored-by: Ira Miller <[email protected]> Co-authored-by: Matt Witkowski <[email protected]> Co-authored-by: provenanceio-bot <[email protected]>
Description
This PR adds a replace line for the
github.com/cosmos/iavlto bump it tov1.2.0(fromv.1.1.2).This will hopefully fix the apphash problem when stopping and restarting a node.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
github.com/cosmos/iavlto version 1.2.0, to improve stability and address known issues.