Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): heighliner image build #2052

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix(ci): heighliner image build #2052

merged 1 commit into from
Jun 25, 2024

Conversation

scirner22
Copy link
Contributor

@scirner22 scirner22 commented Jun 24, 2024

  • Uses a fork of heighliner and custom pre-build step in order to get wasmvm 2.x working.
  • Use the default, alpine 3.19, now that we're on go 1.21.

Summary by CodeRabbit

  • Chores
    • Updated Docker workflow to use heighliner tag v1.6.3 and change owner to ProvLabs.
    • Enhanced pre-build steps and specified platform as linux/amd64.

Copy link
Contributor

coderabbitai bot commented Jun 24, 2024

Walkthrough

The .github/workflows/docker.yml file underwent updates to incorporate the new heighliner tag version v1.6.3 and change its owner to ProvLabs. Additionally, a library copy step was added before the build, and the target platform was specified as linux/amd64. Some unnecessary build environment arguments were also removed for optimization.

Changes

Files Change Summary
.github/…/workflows/docker.yml Updated heighliner tag to v1.6.3, changed owner to ProvLabs, added pre-build library copy step, and specified platform as linux/amd64. Removed some build environment arguments and comments.

Poem

🐰 In the digital warren where code does grow,
Out came the changes in a seamless flow.
With ProvLabs new and tags refined,
We built our Docker, streamlined and kind.
The platforms set, pre-builds align,
Hop to the future, everything's fine! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@scirner22 scirner22 force-pushed the fix-heighliner-image-build branch from b6a62fb to f364721 Compare June 25, 2024 13:20
@scirner22 scirner22 marked this pull request as ready for review June 25, 2024 13:29
@scirner22 scirner22 requested a review from a team as a code owner June 25, 2024 13:29
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6370ab1 and f364721.

Files selected for processing (1)
  • .github/workflows/docker.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/docker.yml (2)

58-59: Update of Heighliner owner and tag validated.

The changes to update the heighliner owner to ProvLabs and the tag to v1.6.3 align with the PR's objectives to use a fork of heighliner for compatibility with wasmvm 2.x.


64-64: Platform specification is appropriate.

Specifying the platform as linux/amd64 is consistent with the PR's description to lock to this architecture due to differing pre-build steps.

.github/workflows/docker.yml Show resolved Hide resolved
@scirner22 scirner22 merged commit c91ee53 into main Jun 25, 2024
20 checks passed
@scirner22 scirner22 deleted the fix-heighliner-image-build branch June 25, 2024 14:35
SpicyLemon pushed a commit that referenced this pull request Jun 25, 2024
SpicyLemon added a commit that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants