change provwasm stargate query plugin to use protocodec #2034
Conversation
WalkthroughThe recent changes involve enhancing the ProV-WASM codebase to support a new codec type ( Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant Codec
User ->> App: Query Plugins
App ->> Codec: Initialize protoCdc
Codec -->> App: Return protoCdc
App ->> App: Create stargateCdc using protoCdc
App ->> User: Return Plugins (including Stargate with stargateCdc)
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- internal/provwasm/query_plugins.go (2 hunks)
- x/wasm/types/any.go (1 hunks)
- x/wasm/types/interface_registry.go (1 hunks)
Files not reviewed due to errors (3)
- x/wasm/types/any.go (Error: Server error. Please try again later.)
- x/wasm/types/interface_registry.go (Error: Server error. Please try again later.)
- internal/provwasm/query_plugins.go (Error: Server error. Please try again later.)
Additional context used
GitHub Check: golangci-lint
x/wasm/types/any.go
[failure] 11-11:
var-naming: don't use underscores in Go names; method XXX_WellKnownType should be XXXWellKnownType (revive)x/wasm/types/interface_registry.go
[failure] 22-22:
unused-parameter: parameter 'typeUrl' seems to be unused, consider removing or renaming it as _ (revive)
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- x/wasm/types/interface_registry.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- x/wasm/types/interface_registry.go
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- x/wasm/types/interface_registry.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- x/wasm/types/interface_registry.go
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- app/app.go (1 hunks)
Additional comments not posted (1)
app/app.go (1)
652-652: Update tocosmwasm_1_4insupportedFeaturesreflects newer capabilities for contracts.
|
The |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- internal/provwasm/query_plugins.go (2 hunks)
- x/wasm/types/any.go (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- internal/provwasm/query_plugins.go
- x/wasm/types/any.go
Description
This PR changes the codec for wasm Stargate (proto based) queries to use the protocodec. This gets around the issue of
Anytype messages returned from a wasm query missing theirtypeinformation, thus breaking the deserialization to the contract level.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
New Features
cosmwasm_1_1tocosmwasm_1_4.Enhancements
WasmInterfaceRegistryfor advanced protocol buffer message handling.