Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker sdk v0.50.x #2021

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Update docker sdk v0.50.x #2021

merged 6 commits into from
Jun 5, 2024

Conversation

Taztingo
Copy link
Contributor

@Taztingo Taztingo commented Jun 4, 2024 •
edited by coderabbitai bot
Loading

Description

Updates to support localnet and ibcnet for docker in sdk 50.

Related to: #1760

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Summary by CodeRabbit

  • New Features

    • Enhanced relayer functionality by updating to version 2.5.2, providing improved compatibility and performance.
    • Improved chain ID handling with fallback to genesis chain-id if chainID is empty, ensuring better reliability.

  • Chores

    • Updated documentation to reflect changes in the CHANGELOG.md.
    • Updated build process to use the latest relayer version (2.5.2).

@Taztingo Taztingo self-assigned this Jun 4, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 4, 2024 •
edited
Loading

Warning

Rate limit exceeded

@Taztingo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 43 minutes and 47 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 6290f28 and 46d6da4.

Walkthrough

This update primarily focuses on upgrading the ibcnet relayer to version 2.5.2 and ensuring correct chain IDs for localnet and ibcnet. Additionally, the Makefile has been modified to reflect the new relayer version, impacting the Docker build process. A minor but crucial update in cmd/provenanced/cmd/root.go introduces a fallback mechanism for the chainID using the genesis chain-id if it's empty.

Changes

File Change Summary
CHANGELOG.md Added an update to the ibcnet relayer to version 2.5.2 and fixed chain IDs for localnet and ibcnet.
Makefile Updated RELAYER_VERSION from v2.1.2 to v2.5.2, affecting the Docker build process.
cmd/provenanced/cmd/root.go Added import for genutiltypes and introduced fallback logic for chainID using genesis chain-id.

Poem

In the land of code, where changes bloom,
Relayers dance to a new tune.
From 2.1 to 2.5 they leap,
Ensuring chains in sync, they keep.
With genesis fallback, they stand tall,
A seamless flow, for one and all.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Taztingo Taztingo marked this pull request as ready for review June 4, 2024 14:18
@Taztingo Taztingo requested a review from a team as a code owner June 4, 2024 14:18
coderabbitai[bot]
coderabbitai bot reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (3)
CHANGELOG.md (3)

Line range hint 124-372: Consider using a consistent list marker style in Markdown.

- - Bump `github.com/cosmos/cosmos-sdk/x/genutil/types` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))
+ * Bump `github.com/cosmos/cosmos-sdk/x/genutil/types` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))

Line range hint 964-964: Remove unnecessary spaces inside emphasis markers.

- * ** Note: ** Although Provenance supports multiple database backends...
+ * **Note:** Although Provenance supports multiple database backends...

Line range hint 360-360: Remove unnecessary spaces inside code span elements.

- ` MsgAddMarkerRequest` 100 hash (100,000,000,000 nhash)
+ `MsgAddMarkerRequest` 100 hash (100,000,000,000 nhash)
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c9f8d39 and 6290f28.

Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • Makefile (1 hunks)
  • cmd/provenanced/cmd/root.go (2 hunks)
Files skipped from review due to trivial changes (1)
  • Makefile
Additional context used
Markdownlint
CHANGELOG.md

124-124: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

125-125: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

126-126: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

127-127: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

128-128: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

129-129: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

138-138: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

139-139: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

140-140: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

141-141: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

142-142: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

212-212: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

213-213: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

214-214: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

219-219: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

220-220: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

221-221: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

223-223: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

239-239: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

240-240: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

241-241: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

243-243: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

272-272: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

273-273: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

274-274: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

351-351: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

352-352: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

353-353: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

354-354: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

355-355: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

356-356: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

357-357: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

358-358: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

359-359: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

360-360: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

361-361: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

362-362: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

363-363: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

364-364: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

366-366: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

367-367: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

368-368: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

369-369: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

370-370: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

371-371: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

372-372: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

373-373: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

729-729: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

737-737: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

782-782: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

790-790: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style

836-836: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1237-1237: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1254-1254: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1306-1306: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

1410-1410: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines

247-247: null (MD034, no-bare-urls)
Bare URL used

278-278: null (MD034, no-bare-urls)
Bare URL used

377-377: null (MD034, no-bare-urls)
Bare URL used

427-427: null (MD034, no-bare-urls)
Bare URL used

439-439: null (MD034, no-bare-urls)
Bare URL used

455-455: null (MD034, no-bare-urls)
Bare URL used

526-526: null (MD034, no-bare-urls)
Bare URL used

537-537: null (MD034, no-bare-urls)
Bare URL used

545-545: null (MD034, no-bare-urls)
Bare URL used

581-581: null (MD034, no-bare-urls)
Bare URL used

606-606: null (MD034, no-bare-urls)
Bare URL used

618-618: null (MD034, no-bare-urls)
Bare URL used

664-664: null (MD034, no-bare-urls)
Bare URL used

665-665: null (MD034, no-bare-urls)
Bare URL used

666-666: null (MD034, no-bare-urls)
Bare URL used

667-667: null (MD034, no-bare-urls)
Bare URL used

668-668: null (MD034, no-bare-urls)
Bare URL used

715-715: null (MD034, no-bare-urls)
Bare URL used

756-756: null (MD034, no-bare-urls)
Bare URL used

809-809: null (MD034, no-bare-urls)
Bare URL used

922-922: null (MD034, no-bare-urls)
Bare URL used

964-964: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

964-964: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

360-360: null (MD038, no-space-in-code)
Spaces inside code span elements

Additional comments not posted (1)
cmd/provenanced/cmd/root.go (1)

47-47: The import of genutiltypes is correctly placed and necessary for the new chain ID handling logic.

cmd/provenanced/cmd/root.go Show resolved Hide resolved
nullpointer0x00
nullpointer0x00 reviewed Jun 4, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Taztingo Taztingo requested a review from nullpointer0x00 June 4, 2024 14:34
@Taztingo Taztingo enabled auto-merge (squash) June 4, 2024 14:37
@Taztingo Taztingo merged commit cb8fcac into main Jun 5, 2024
27 of 31 checks passed
@Taztingo Taztingo deleted the taztingo/update-docker-sdk50 branch June 5, 2024 19:49
@coderabbitai coderabbitai bot mentioned this pull request Oct 11, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@SpicyLemon SpicyLemon SpicyLemon approved these changes

@nullpointer0x00 nullpointer0x00 nullpointer0x00 approved these changes

Assignees

@Taztingo Taztingo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taztingo @nullpointer0x00 @SpicyLemon