Breakdown internal/helpers #2019
Conversation
…nd internal/rand.
WalkthroughThe recent changes involve breaking down the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
CHANGELOG.md (5)
Line range hint
243-243: Consider replacing bare URLs with descriptive link text to improve readability and accessibility.For example:
- [Issue #2012](https://github.com/provenance-io/provenance/issues/2012)Also applies to: 274-274, 373-373, 423-423, 435-435, 451-451, 522-522, 533-533, 541-541, 577-577, 602-602, 614-614, 660-664, 711-711, 752-752, 805-805, 918-918
Line range hint
960-960: Remove spaces inside emphasis markers to adhere to Markdown best practices.- *message* instead of * message *
Line range hint
356-356: Remove spaces inside code span elements to adhere to Markdown best practices.- `code` instead of ` code `
Line range hint
832-832: Remove multiple consecutive blank lines to adhere to Markdown best practices.- Ensure there is only one blank line where multiple consecutive blank lines are found.Also applies to: 1233-1233, 1250-1250, 1302-1302, 1406-1406
Line range hint
121-138: Use consistent list item markers in Markdown. Replace dashes with asterisks for unordered lists to maintain consistency throughout the document.- * Item 1 - * Item 2Also applies to: 208-238, 268-270, 347-369, 725-725, 733-733, 778-778
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (24)
- CHANGELOG.md (1 hunks)
- app/export.go (4 hunks)
- app/upgrades_test.go (2 hunks)
- internal/collections/maps.go (1 hunks)
- internal/handlers/msg_service_router.go (2 hunks)
- internal/provwasm/message_encoders.go (2 hunks)
- internal/rand/account.go (1 hunks)
- internal/rand/int.go (1 hunks)
- internal/rand/int_test.go (1 hunks)
- internal/rand/slices.go (2 hunks)
- internal/rand/slices_test.go (3 hunks)
- internal/sdk/validator.go (1 hunks)
- x/exchange/client/cli/tx_test.go (3 hunks)
- x/exchange/market_test.go (3 hunks)
- x/exchange/msgs_test.go (2 hunks)
- x/hold/keeper/keeper_test.go (2 hunks)
- x/ibcratelimit/simulation/genesis.go (2 hunks)
- x/name/simulation/operations.go (2 hunks)
- x/oracle/simulation/genesis.go (2 hunks)
- x/oracle/simulation/operations.go (3 hunks)
- x/trigger/simulation/genesis.go (3 hunks)
- x/trigger/simulation/operations.go (2 hunks)
- x/trigger/types/genesis.go (2 hunks)
- x/trigger/types/msgs.go (2 hunks)
Files skipped from review due to trivial changes (2)
- internal/collections/maps.go
- internal/rand/int.go
Additional context used
Markdownlint
CHANGELOG.md
121-121: Expected: asterisk; Actual: dash
Unordered list style
122-122: Expected: asterisk; Actual: dash
Unordered list style
123-123: Expected: asterisk; Actual: dash
Unordered list style
124-124: Expected: asterisk; Actual: dash
Unordered list style
125-125: Expected: asterisk; Actual: dash
Unordered list style
126-126: Expected: asterisk; Actual: dash
Unordered list style
127-127: Expected: asterisk; Actual: dash
Unordered list style
128-128: Expected: asterisk; Actual: dash
Unordered list style
129-129: Expected: asterisk; Actual: dash
Unordered list style
130-130: Expected: asterisk; Actual: dash
Unordered list style
131-131: Expected: asterisk; Actual: dash
Unordered list style
132-132: Expected: asterisk; Actual: dash
Unordered list style
133-133: Expected: asterisk; Actual: dash
Unordered list style
134-134: Expected: asterisk; Actual: dash
Unordered list style
135-135: Expected: asterisk; Actual: dash
Unordered list style
136-136: Expected: asterisk; Actual: dash
Unordered list style
137-137: Expected: asterisk; Actual: dash
Unordered list style
138-138: Expected: asterisk; Actual: dash
Unordered list style
208-208: Expected: asterisk; Actual: dash
Unordered list style
209-209: Expected: asterisk; Actual: dash
Unordered list style
210-210: Expected: asterisk; Actual: dash
Unordered list style
211-211: Expected: asterisk; Actual: dash
Unordered list style
212-212: Expected: asterisk; Actual: dash
Unordered list style
213-213: Expected: asterisk; Actual: dash
Unordered list style
214-214: Expected: asterisk; Actual: dash
Unordered list style
215-215: Expected: asterisk; Actual: dash
Unordered list style
216-216: Expected: asterisk; Actual: dash
Unordered list style
217-217: Expected: asterisk; Actual: dash
Unordered list style
218-218: Expected: asterisk; Actual: dash
Unordered list style
219-219: Expected: asterisk; Actual: dash
Unordered list style
220-220: Expected: asterisk; Actual: dash
Unordered list style
221-221: Expected: asterisk; Actual: dash
Unordered list style
222-222: Expected: asterisk; Actual: dash
Unordered list style
223-223: Expected: asterisk; Actual: dash
Unordered list style
224-224: Expected: asterisk; Actual: dash
Unordered list style
225-225: Expected: asterisk; Actual: dash
Unordered list style
226-226: Expected: asterisk; Actual: dash
Unordered list style
227-227: Expected: asterisk; Actual: dash
Unordered list style
228-228: Expected: asterisk; Actual: dash
Unordered list style
229-229: Expected: asterisk; Actual: dash
Unordered list style
230-230: Expected: asterisk; Actual: dash
Unordered list style
231-231: Expected: asterisk; Actual: dash
Unordered list style
232-232: Expected: asterisk; Actual: dash
Unordered list style
233-233: Expected: asterisk; Actual: dash
Unordered list style
234-234: Expected: asterisk; Actual: dash
Unordered list style
235-235: Expected: asterisk; Actual: dash
Unordered list style
236-236: Expected: asterisk; Actual: dash
Unordered list style
237-237: Expected: asterisk; Actual: dash
Unordered list style
238-238: Expected: asterisk; Actual: dash
Unordered list style
239-239: Expected: asterisk; Actual: dash
Unordered list style
268-268: Expected: asterisk; Actual: dash
Unordered list style
269-269: Expected: asterisk; Actual: dash
Unordered list style
270-270: Expected: asterisk; Actual: dash
Unordered list style
347-347: Expected: asterisk; Actual: dash
Unordered list style
348-348: Expected: asterisk; Actual: dash
Unordered list style
349-349: Expected: asterisk; Actual: dash
Unordered list style
350-350: Expected: asterisk; Actual: dash
Unordered list style
351-351: Expected: asterisk; Actual: dash
Unordered list style
352-352: Expected: asterisk; Actual: dash
Unordered list style
353-353: Expected: asterisk; Actual: dash
Unordered list style
354-354: Expected: asterisk; Actual: dash
Unordered list style
355-355: Expected: asterisk; Actual: dash
Unordered list style
356-356: Expected: asterisk; Actual: dash
Unordered list style
357-357: Expected: asterisk; Actual: dash
Unordered list style
358-358: Expected: asterisk; Actual: dash
Unordered list style
359-359: Expected: asterisk; Actual: dash
Unordered list style
360-360: Expected: asterisk; Actual: dash
Unordered list style
361-361: Expected: asterisk; Actual: dash
Unordered list style
362-362: Expected: asterisk; Actual: dash
Unordered list style
363-363: Expected: asterisk; Actual: dash
Unordered list style
364-364: Expected: asterisk; Actual: dash
Unordered list style
365-365: Expected: asterisk; Actual: dash
Unordered list style
366-366: Expected: asterisk; Actual: dash
Unordered list style
367-367: Expected: asterisk; Actual: dash
Unordered list style
368-368: Expected: asterisk; Actual: dash
Unordered list style
369-369: Expected: asterisk; Actual: dash
Unordered list style
725-725: Expected: asterisk; Actual: dash
Unordered list style
733-733: Expected: asterisk; Actual: dash
Unordered list style
778-778: Expected: asterisk; Actual: dash
Unordered list style
786-786: Expected: asterisk; Actual: dash
Unordered list style
832-832: Expected: 1; Actual: 2
Multiple consecutive blank lines
1233-1233: Expected: 1; Actual: 2
Multiple consecutive blank lines
1250-1250: Expected: 1; Actual: 2
Multiple consecutive blank lines
1302-1302: Expected: 1; Actual: 2
Multiple consecutive blank lines
1406-1406: Expected: 1; Actual: 2
Multiple consecutive blank lines
243-243: null
Bare URL used
274-274: null
Bare URL used
373-373: null
Bare URL used
423-423: null
Bare URL used
435-435: null
Bare URL used
451-451: null
Bare URL used
522-522: null
Bare URL used
533-533: null
Bare URL used
541-541: null
Bare URL used
577-577: null
Bare URL used
602-602: null
Bare URL used
614-614: null
Bare URL used
660-660: null
Bare URL used
661-661: null
Bare URL used
662-662: null
Bare URL used
663-663: null
Bare URL used
664-664: null
Bare URL used
711-711: null
Bare URL used
752-752: null
Bare URL used
805-805: null
Bare URL used
918-918: null
Bare URL used
960-960: null
Spaces inside emphasis markers
960-960: null
Spaces inside emphasis markers
356-356: null
Spaces inside code span elements
Additional comments not posted (31)
internal/rand/account.go (1)
9-12: The implementation ofSelectAccountseffectively reusesSelectEntries, promoting code reuse and maintainability.internal/rand/slices.go (1)
8-10: TheSelectEntriesfunction is well-implemented, handling edge cases and promoting code reuse effectively.internal/sdk/validator.go (1)
1-1: The restructuring of SDK-related utility functions into theinternal/sdkpackage enhances modularity and clarity.Also applies to: 6-6
x/ibcratelimit/simulation/genesis.go (1)
11-11: The integration ofinternal/randinx/ibcratelimit/simulation/genesis.godemonstrates effective use of the newly structured packages.Also applies to: 22-22
x/oracle/simulation/genesis.go (1)
12-12: The use ofinternal/randinx/oracle/simulation/genesis.gofor generating random data is a good demonstration of the new package structure's utility.Also applies to: 25-25, 31-31
internal/provwasm/message_encoders.go (1)
15-15: The integration ofinternal/sdkininternal/provwasm/message_encoders.gofor message validation showcases the effective use of the newly structured packages.Also applies to: 68-68
internal/rand/int_test.go (1)
14-94: The test functionTestIntBetweenis well-structured and covers a comprehensive range of cases, including edge conditions where panics are expected. Good use of table-driven tests and assertions.x/trigger/types/genesis.go (1)
63-63: The integration ofinternalsdk.ValidateBasicin the validation logic helps ensure that all messages meet the necessary basic criteria before processing. This is a crucial enhancement for maintaining data integrity.x/trigger/types/msgs.go (1)
84-84: The use ofinternalsdk.ValidateBasicfor action validation inMsgCreateTriggerRequest.ValidateBasicis a prudent choice, ensuring that all actions adhere to the SDK's basic validation standards.internal/rand/slices_test.go (1)
Line range hint
14-193: The test functionTestSelectEntriesis well-structured and effectively tests theSelectEntriesfunction across a variety of scenarios, including proper error handling. Good use of table-driven tests and assertions.x/oracle/simulation/operations.go (1)
74-74: The integration ofinternalrand.SelectAccountsandinternalrand.IntBetweenin the simulation logic ensures consistent and reliable random selection processes, aligning with the new internal structure.Also applies to: 158-158
x/trigger/simulation/operations.go (1)
59-59: The use ofinternalrand.SelectAccountsin the simulation logic forSimulateMsgCreateTriggereffectively ensures random and unbiased account selection, which is crucial for realistic and robust simulation scenarios.x/trigger/simulation/genesis.go (6)
34-34: LGTM! The function call tointernalrand.IntBetweencorrectly replaces the previous helper function, aligning with the PR's objectives.
39-39: LGTM! The function call tointernalrand.IntBetweencorrectly replaces the previous helper function, aligning with the PR's objectives.
47-47: LGTM! The function calls tointernalrand.IntBetweencorrectly replace the previous helper function, aligning with the PR's objectives.Also applies to: 50-50
56-56: LGTM! The function call tointernalrand.IntBetweencorrectly replaces the previous helper function, aligning with the PR's objectives.
66-66: LGTM! The function call tointernalrand.SelectAccountscorrectly replaces the previous helper function, aligning with the PR's objectives.
17-17: LGTM! The import addition ofinternal/randis necessary for the updated function calls and aligns with the PR's restructuring objectives.x/name/simulation/operations.go (2)
70-70: LGTM! The function call tointernalrand.IntBetweencorrectly replaces the previous helper function, aligning with the PR's objectives.
17-17: LGTM! The import addition ofinternal/randis necessary for the updated function calls and aligns with the PR's restructuring objectives.app/export.go (2)
103-103: LGTM! The function calls tointernalsdk.MustGetOperatorAddrcorrectly replace the previous helper function, aligning with the PR's objectives.Also applies to: 139-139, 153-153
20-20: LGTM! The import addition ofinternal/sdkis necessary for the updated function calls and aligns with the PR's restructuring objectives.internal/handlers/msg_service_router.go (2)
172-172: LGTM! The function call tointernalsdk.ValidateBasiccorrectly replaces the previous helper function, aligning with the PR's objectives.
22-22: LGTM! The import addition ofinternal/sdkis necessary for the updated function calls and aligns with the PR's restructuring objectives.app/upgrades_test.go (2)
24-24: Update import path to reflect new package structure.This change correctly updates the import path from
internal/helperstointernal/sdk, aligning with the restructuring objectives.
268-268: Update function call to use new SDK utility.This change correctly updates the function call to use
internalsdk.GetOperatorAddr, ensuring consistency with the new package structure.Verification successful
The function
GetOperatorAddrhas been updated to use the newinternalsdkpackage. To ensure that this change is correct, we need to verify the implementation ofGetOperatorAddrininternal/sdk/validator.goand compare it with the old implementation in thehelperspackage.
The previous search did not yield any results for
GetOperatorAddrin thehelperspackage. To proceed, we need to locate thehelperspackage and inspect its contents to find the old implementation.
The previous attempts did not yield any results for the
helperspackage or the old implementation ofGetOperatorAddr. To proceed, we need to search for any references toGetOperatorAddrin the entire repository to locate the old implementation.
The search results show that
GetOperatorAddris defined ininternal/sdk/validator.goand used inapp/upgrades_test.goandapp/export.go. There are no references to an old implementation in ahelperspackage. To proceed, we need to review the implementation ofGetOperatorAddrininternal/sdk/validator.goto ensure it behaves as expected.
The implementation of
GetOperatorAddrininternal/sdk/validator.gois as follows:// GetOperatorAddr returns the validator's operator address. func GetOperatorAddr(val stakingtypes.ValidatorI) (sdk.ValAddress, error) { return sdk.ValAddressFromBech32(val.GetOperator()) }This function converts the operator address from a Bech32 string to an
sdk.ValAddresstype, which is consistent with the expected behavior.The change to use
internalsdk.GetOperatorAddrinapp/upgrades_test.gois correct and aligns with the new package structure.
internal/sdk/validator.go: Implementation ofGetOperatorAddris correct.app/upgrades_test.go: Usage ofinternalsdk.GetOperatorAddris consistent with the new implementation.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that `GetOperatorAddr` from `internalsdk` behaves as expected. # Test: Search for the function usage and its implementation. Expect: Correct behavior as per the old `helpers` package. rg --type go $'GetOperatorAddr'Length of output: 1509
Script:
#!/bin/bash # Description: Compare the implementation of `GetOperatorAddr` in `internal/sdk/validator.go` with the old implementation in the `helpers` package. # Search for the old implementation in the `helpers` package. rg --type go 'GetOperatorAddr' | grep 'helpers'Length of output: 45
Script:
#!/bin/bash # Description: Locate the `helpers` package and inspect its contents to find the old implementation of `GetOperatorAddr`. # Search for the `helpers` package in the repository. fd -t d 'helpers' # List the contents of the `helpers` package. fd -t f . helpersLength of output: 132
Script:
#!/bin/bash # Description: Search for any references to `GetOperatorAddr` in the entire repository to locate the old implementation. # Search for any references to `GetOperatorAddr` in the entire repository. rg --type go 'GetOperatorAddr'Length of output: 1509
Script:
#!/bin/bash # Description: Extract and review the implementation of `GetOperatorAddr` in `internal/sdk/validator.go`. # Extract the implementation of `GetOperatorAddr` in `internal/sdk/validator.go`. rg --type go --context 10 'func GetOperatorAddr' internal/sdk/validator.goLength of output: 877
x/hold/keeper/keeper_test.go (1)
22-22: Update import path to reflect new package structure.The change from
internal/helperstointernal/collectionsaligns with the PR's objective to improve code organization by breaking down the broadhelperspackage into more specific and manageable components. This change is consistent with the restructuring described in the PR.x/exchange/client/cli/tx_test.go (2)
1013-1013: Usage ofinternalcollections.Keysfunction appears correct.Also applies to: 1045-1045
Verification successful
The usage of the
internalcollections.Keysfunction in the test suite is correct and consistent with its definition in theinternalcollectionspackage.
internal/collections/maps.go: Correct definition ofKeysfunction.x/exchange/client/cli/tx_test.go: Correct usage ofKeysfunction.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct usage of `internalcollections.Keys` function. # Test: Search for the definition and usage of `Keys` function in the `internalcollections` package. Expect: Correct definition and usage. rg --type go $'func Keys' internal/collections/maps.go rg --type go $'internalcollections.Keys' x/exchange/client/cli/tx_test.goLength of output: 286
15-15: Updated import path for collections looks good.Verification successful
Updated import path for collections looks good.
#!/bin/bash # Description: Verify that the new import path is used correctly throughout the file. # Test: Search for the usage of `internalcollections`. Expect: Usage instances should be correct and consistent. rg --type go $'internalcollections' x/exchange/client/cli/tx_test.go
[task review_results_1/1] Review the results of the shell script execution.
[observations] The script output shows that the new import path is used correctly in the file.
[analysis] The usage ofinternalcollectionsis consistent and correct in the file.
[actions] Conclude the verification process and generate the final response.
-->The new import path for
internalcollectionsis used correctly and consistently in the file.
internalcollectionsis imported correctly.internalcollections.Keys(expPerms)is used correctly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the new import path is used correctly throughout the file. # Test: Search for the usage of `internalcollections`. Expect: Usage instances should be correct and consistent. rg --type go $'internalcollections' x/exchange/client/cli/tx_test.goLength of output: 251
x/exchange/msgs_test.go (1)
20-20: Update import path to match new package structure.This change correctly updates the import path to reflect the new location of the SDK-related functionalities under
internal/sdk, aligning with the restructuring goals.x/exchange/market_test.go (1)
16-16: Updated import path to reflect new package structure.Verification successful
The updated import path for
internalcollectionshas been correctly reflected in all instances across the codebase.
x/hold/keeper/keeper_test.gox/exchange/market_test.gox/exchange/client/cli/tx_test.gointernal/rand/int_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `internalcollections` match the new package structure. # Test: Search for the function usage. Expect: Only occurances of the new package. rg --type go $'internalcollections'Length of output: 946
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
CHANGELOG.md (5)
Line range hint
122-122: Consistency in list item markers.- Use asterisks (*) for unordered list items instead of dashes (-) to maintain consistency throughout the document.Also applies to: 123-123, 124-124, 125-125, 126-126, 127-127, 128-128, 129-129, 130-130, 131-131, 132-132, 133-133, 134-134, 135-135, 136-136, 137-137, 138-138, 139-139, 209-209, 210-210, 211-211, 212-212, 213-213, 214-214, 215-215, 216-216, 217-217, 218-218, 219-219, 220-220, 221-221, 222-222, 223-223, 224-224, 225-225, 226-226, 227-227, 228-228, 229-229, 230-230, 231-231, 232-232, 233-233, 234-234, 235-235, 236-236, 237-237, 238-238, 239-239, 240-240, 269-269, 270-270, 271-271, 348-348, 349-349, 350-350, 351-351, 352-352, 353-353, 354-354, 355-355, 356-356, 357-357, 358-358, 359-359, 360-360, 361-361, 362-362, 363-363, 364-364, 365-365, 366-366, 367-367, 368-368, 369-369, 370-370, 726-726, 734-734, 779-779, 787-787
Line range hint
833-833: Reduce consecutive blank lines.- Ensure there is only one blank line between sections for better readability and to adhere to Markdown best practices.Also applies to: 1234-1234, 1251-1251, 1303-1303, 1407-1407
Line range hint
244-244: Use Markdown links instead of bare URLs.- Replace bare URLs with Markdown links to improve the readability and appearance of the document.Also applies to: 275-275, 374-374, 424-424, 436-436, 452-452, 523-523, 534-534, 542-542, 578-578, 603-603, 615-615, 661-661, 662-662, 663-663, 664-664, 665-665, 712-712, 753-753, 806-806, 919-919
Line range hint
961-961: Remove spaces inside emphasis markers.- Correct the Markdown syntax by removing unnecessary spaces inside emphasis markers.
Line range hint
357-357: Remove spaces inside code span elements.- Ensure that there are no spaces at the beginning or end of code span elements to maintain clean code formatting.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- x/exchange/client/cli/tx_test.go (3 hunks)
- x/exchange/msgs_test.go (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- x/exchange/client/cli/tx_test.go
- x/exchange/msgs_test.go
Additional context used
Markdownlint
CHANGELOG.md
122-122: Expected: asterisk; Actual: dash
Unordered list style
123-123: Expected: asterisk; Actual: dash
Unordered list style
124-124: Expected: asterisk; Actual: dash
Unordered list style
125-125: Expected: asterisk; Actual: dash
Unordered list style
126-126: Expected: asterisk; Actual: dash
Unordered list style
127-127: Expected: asterisk; Actual: dash
Unordered list style
128-128: Expected: asterisk; Actual: dash
Unordered list style
129-129: Expected: asterisk; Actual: dash
Unordered list style
130-130: Expected: asterisk; Actual: dash
Unordered list style
131-131: Expected: asterisk; Actual: dash
Unordered list style
132-132: Expected: asterisk; Actual: dash
Unordered list style
133-133: Expected: asterisk; Actual: dash
Unordered list style
134-134: Expected: asterisk; Actual: dash
Unordered list style
135-135: Expected: asterisk; Actual: dash
Unordered list style
136-136: Expected: asterisk; Actual: dash
Unordered list style
137-137: Expected: asterisk; Actual: dash
Unordered list style
138-138: Expected: asterisk; Actual: dash
Unordered list style
139-139: Expected: asterisk; Actual: dash
Unordered list style
209-209: Expected: asterisk; Actual: dash
Unordered list style
210-210: Expected: asterisk; Actual: dash
Unordered list style
211-211: Expected: asterisk; Actual: dash
Unordered list style
212-212: Expected: asterisk; Actual: dash
Unordered list style
213-213: Expected: asterisk; Actual: dash
Unordered list style
214-214: Expected: asterisk; Actual: dash
Unordered list style
215-215: Expected: asterisk; Actual: dash
Unordered list style
216-216: Expected: asterisk; Actual: dash
Unordered list style
217-217: Expected: asterisk; Actual: dash
Unordered list style
218-218: Expected: asterisk; Actual: dash
Unordered list style
219-219: Expected: asterisk; Actual: dash
Unordered list style
220-220: Expected: asterisk; Actual: dash
Unordered list style
221-221: Expected: asterisk; Actual: dash
Unordered list style
222-222: Expected: asterisk; Actual: dash
Unordered list style
223-223: Expected: asterisk; Actual: dash
Unordered list style
224-224: Expected: asterisk; Actual: dash
Unordered list style
225-225: Expected: asterisk; Actual: dash
Unordered list style
226-226: Expected: asterisk; Actual: dash
Unordered list style
227-227: Expected: asterisk; Actual: dash
Unordered list style
228-228: Expected: asterisk; Actual: dash
Unordered list style
229-229: Expected: asterisk; Actual: dash
Unordered list style
230-230: Expected: asterisk; Actual: dash
Unordered list style
231-231: Expected: asterisk; Actual: dash
Unordered list style
232-232: Expected: asterisk; Actual: dash
Unordered list style
233-233: Expected: asterisk; Actual: dash
Unordered list style
234-234: Expected: asterisk; Actual: dash
Unordered list style
235-235: Expected: asterisk; Actual: dash
Unordered list style
236-236: Expected: asterisk; Actual: dash
Unordered list style
237-237: Expected: asterisk; Actual: dash
Unordered list style
238-238: Expected: asterisk; Actual: dash
Unordered list style
239-239: Expected: asterisk; Actual: dash
Unordered list style
240-240: Expected: asterisk; Actual: dash
Unordered list style
269-269: Expected: asterisk; Actual: dash
Unordered list style
270-270: Expected: asterisk; Actual: dash
Unordered list style
271-271: Expected: asterisk; Actual: dash
Unordered list style
348-348: Expected: asterisk; Actual: dash
Unordered list style
349-349: Expected: asterisk; Actual: dash
Unordered list style
350-350: Expected: asterisk; Actual: dash
Unordered list style
351-351: Expected: asterisk; Actual: dash
Unordered list style
352-352: Expected: asterisk; Actual: dash
Unordered list style
353-353: Expected: asterisk; Actual: dash
Unordered list style
354-354: Expected: asterisk; Actual: dash
Unordered list style
355-355: Expected: asterisk; Actual: dash
Unordered list style
356-356: Expected: asterisk; Actual: dash
Unordered list style
357-357: Expected: asterisk; Actual: dash
Unordered list style
358-358: Expected: asterisk; Actual: dash
Unordered list style
359-359: Expected: asterisk; Actual: dash
Unordered list style
360-360: Expected: asterisk; Actual: dash
Unordered list style
361-361: Expected: asterisk; Actual: dash
Unordered list style
362-362: Expected: asterisk; Actual: dash
Unordered list style
363-363: Expected: asterisk; Actual: dash
Unordered list style
364-364: Expected: asterisk; Actual: dash
Unordered list style
365-365: Expected: asterisk; Actual: dash
Unordered list style
366-366: Expected: asterisk; Actual: dash
Unordered list style
367-367: Expected: asterisk; Actual: dash
Unordered list style
368-368: Expected: asterisk; Actual: dash
Unordered list style
369-369: Expected: asterisk; Actual: dash
Unordered list style
370-370: Expected: asterisk; Actual: dash
Unordered list style
726-726: Expected: asterisk; Actual: dash
Unordered list style
734-734: Expected: asterisk; Actual: dash
Unordered list style
779-779: Expected: asterisk; Actual: dash
Unordered list style
787-787: Expected: asterisk; Actual: dash
Unordered list style
833-833: Expected: 1; Actual: 2
Multiple consecutive blank lines
1234-1234: Expected: 1; Actual: 2
Multiple consecutive blank lines
1251-1251: Expected: 1; Actual: 2
Multiple consecutive blank lines
1303-1303: Expected: 1; Actual: 2
Multiple consecutive blank lines
1407-1407: Expected: 1; Actual: 2
Multiple consecutive blank lines
244-244: null
Bare URL used
275-275: null
Bare URL used
374-374: null
Bare URL used
424-424: null
Bare URL used
436-436: null
Bare URL used
452-452: null
Bare URL used
523-523: null
Bare URL used
534-534: null
Bare URL used
542-542: null
Bare URL used
578-578: null
Bare URL used
603-603: null
Bare URL used
615-615: null
Bare URL used
661-661: null
Bare URL used
662-662: null
Bare URL used
663-663: null
Bare URL used
664-664: null
Bare URL used
665-665: null
Bare URL used
712-712: null
Bare URL used
753-753: null
Bare URL used
806-806: null
Bare URL used
919-919: null
Bare URL used
961-961: null
Spaces inside emphasis markers
961-961: null
Spaces inside emphasis markers
357-357: null
Spaces inside code span elements
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
CHANGELOG.md (5)
Line range hint
123-371: Consider using consistent list markers in Markdown. The document uses dashes (-) instead of asterisks (*). While both are valid, consistency helps in maintaining a standard format across your Markdown files.- - Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956)) + * Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))Also applies to: 727-727, 735-735, 780-780, 788-788
Line range hint
834-834: Multiple consecutive blank lines found. It's a good practice to limit to one blank line to separate sections for better readability and to adhere to Markdown best practices.-Also applies to: 1235-1235, 1252-1252, 1304-1304, 1408-1408
Line range hint
245-245: It's recommended to use Markdown link syntax for URLs to improve the readability and accessibility of your document.- https://github.com/provenance-io/provenance/pull/1910 + [PR 1910](https://github.com/provenance-io/provenance/pull/1910)Also applies to: 276-276, 375-375, 425-425, 437-437, 453-453, 524-524, 535-535, 543-543, 579-579, 604-604, 616-616, 662-666, 713-713, 754-754, 807-807, 920-920
Line range hint
962-962: There are spaces inside emphasis markers. This might lead to rendering issues in some Markdown parsers.- * this is * not correct * + *this is* not correct
Line range hint
358-358: Spaces found inside code span elements. This might lead to unexpected display issues in some Markdown viewers.- ` code ` + `code`
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
Markdownlint
CHANGELOG.md
123-123: Expected: asterisk; Actual: dash
Unordered list style
124-124: Expected: asterisk; Actual: dash
Unordered list style
125-125: Expected: asterisk; Actual: dash
Unordered list style
126-126: Expected: asterisk; Actual: dash
Unordered list style
127-127: Expected: asterisk; Actual: dash
Unordered list style
128-128: Expected: asterisk; Actual: dash
Unordered list style
129-129: Expected: asterisk; Actual: dash
Unordered list style
130-130: Expected: asterisk; Actual: dash
Unordered list style
131-131: Expected: asterisk; Actual: dash
Unordered list style
132-132: Expected: asterisk; Actual: dash
Unordered list style
133-133: Expected: asterisk; Actual: dash
Unordered list style
134-134: Expected: asterisk; Actual: dash
Unordered list style
135-135: Expected: asterisk; Actual: dash
Unordered list style
136-136: Expected: asterisk; Actual: dash
Unordered list style
137-137: Expected: asterisk; Actual: dash
Unordered list style
138-138: Expected: asterisk; Actual: dash
Unordered list style
139-139: Expected: asterisk; Actual: dash
Unordered list style
140-140: Expected: asterisk; Actual: dash
Unordered list style
210-210: Expected: asterisk; Actual: dash
Unordered list style
211-211: Expected: asterisk; Actual: dash
Unordered list style
212-212: Expected: asterisk; Actual: dash
Unordered list style
213-213: Expected: asterisk; Actual: dash
Unordered list style
214-214: Expected: asterisk; Actual: dash
Unordered list style
215-215: Expected: asterisk; Actual: dash
Unordered list style
216-216: Expected: asterisk; Actual: dash
Unordered list style
217-217: Expected: asterisk; Actual: dash
Unordered list style
218-218: Expected: asterisk; Actual: dash
Unordered list style
219-219: Expected: asterisk; Actual: dash
Unordered list style
220-220: Expected: asterisk; Actual: dash
Unordered list style
221-221: Expected: asterisk; Actual: dash
Unordered list style
222-222: Expected: asterisk; Actual: dash
Unordered list style
223-223: Expected: asterisk; Actual: dash
Unordered list style
224-224: Expected: asterisk; Actual: dash
Unordered list style
225-225: Expected: asterisk; Actual: dash
Unordered list style
226-226: Expected: asterisk; Actual: dash
Unordered list style
227-227: Expected: asterisk; Actual: dash
Unordered list style
228-228: Expected: asterisk; Actual: dash
Unordered list style
229-229: Expected: asterisk; Actual: dash
Unordered list style
230-230: Expected: asterisk; Actual: dash
Unordered list style
231-231: Expected: asterisk; Actual: dash
Unordered list style
232-232: Expected: asterisk; Actual: dash
Unordered list style
233-233: Expected: asterisk; Actual: dash
Unordered list style
234-234: Expected: asterisk; Actual: dash
Unordered list style
235-235: Expected: asterisk; Actual: dash
Unordered list style
236-236: Expected: asterisk; Actual: dash
Unordered list style
237-237: Expected: asterisk; Actual: dash
Unordered list style
238-238: Expected: asterisk; Actual: dash
Unordered list style
239-239: Expected: asterisk; Actual: dash
Unordered list style
240-240: Expected: asterisk; Actual: dash
Unordered list style
241-241: Expected: asterisk; Actual: dash
Unordered list style
270-270: Expected: asterisk; Actual: dash
Unordered list style
271-271: Expected: asterisk; Actual: dash
Unordered list style
272-272: Expected: asterisk; Actual: dash
Unordered list style
349-349: Expected: asterisk; Actual: dash
Unordered list style
350-350: Expected: asterisk; Actual: dash
Unordered list style
351-351: Expected: asterisk; Actual: dash
Unordered list style
352-352: Expected: asterisk; Actual: dash
Unordered list style
353-353: Expected: asterisk; Actual: dash
Unordered list style
354-354: Expected: asterisk; Actual: dash
Unordered list style
355-355: Expected: asterisk; Actual: dash
Unordered list style
356-356: Expected: asterisk; Actual: dash
Unordered list style
357-357: Expected: asterisk; Actual: dash
Unordered list style
358-358: Expected: asterisk; Actual: dash
Unordered list style
359-359: Expected: asterisk; Actual: dash
Unordered list style
360-360: Expected: asterisk; Actual: dash
Unordered list style
361-361: Expected: asterisk; Actual: dash
Unordered list style
362-362: Expected: asterisk; Actual: dash
Unordered list style
363-363: Expected: asterisk; Actual: dash
Unordered list style
364-364: Expected: asterisk; Actual: dash
Unordered list style
365-365: Expected: asterisk; Actual: dash
Unordered list style
366-366: Expected: asterisk; Actual: dash
Unordered list style
367-367: Expected: asterisk; Actual: dash
Unordered list style
368-368: Expected: asterisk; Actual: dash
Unordered list style
369-369: Expected: asterisk; Actual: dash
Unordered list style
370-370: Expected: asterisk; Actual: dash
Unordered list style
371-371: Expected: asterisk; Actual: dash
Unordered list style
727-727: Expected: asterisk; Actual: dash
Unordered list style
735-735: Expected: asterisk; Actual: dash
Unordered list style
780-780: Expected: asterisk; Actual: dash
Unordered list style
788-788: Expected: asterisk; Actual: dash
Unordered list style
834-834: Expected: 1; Actual: 2
Multiple consecutive blank lines
1235-1235: Expected: 1; Actual: 2
Multiple consecutive blank lines
1252-1252: Expected: 1; Actual: 2
Multiple consecutive blank lines
1304-1304: Expected: 1; Actual: 2
Multiple consecutive blank lines
1408-1408: Expected: 1; Actual: 2
Multiple consecutive blank lines
245-245: null
Bare URL used
276-276: null
Bare URL used
375-375: null
Bare URL used
425-425: null
Bare URL used
437-437: null
Bare URL used
453-453: null
Bare URL used
524-524: null
Bare URL used
535-535: null
Bare URL used
543-543: null
Bare URL used
579-579: null
Bare URL used
604-604: null
Bare URL used
616-616: null
Bare URL used
662-662: null
Bare URL used
663-663: null
Bare URL used
664-664: null
Bare URL used
665-665: null
Bare URL used
666-666: null
Bare URL used
713-713: null
Bare URL used
754-754: null
Bare URL used
807-807: null
Bare URL used
920-920: null
Bare URL used
962-962: null
Spaces inside emphasis markers
962-962: null
Spaces inside emphasis markers
358-358: null
Spaces inside code span elements
Description
Removes the sweep all package
internal/helpersand replaces it withinternal/sdk,internal/collections, andinternal/rand.closes: #2012
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
Refactor
internal/helpersmodule has been broken down into multiple internal packages to improve code organization and maintainability.Bug Fixes
New Features
randpackage.Tests