Fix the sim tests. #2015
Fix the sim tests. #2015
Conversation
…as. Upgrade and wasm seem to have problems, though.
WalkthroughThe recent changes involve significant updates to the Provenance Blockchain's codebase, focusing on dependency management, code refactoring, and enhanced testing. Key updates include reorganizing dependencies in Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant App
participant Module
participant API
User ->> App: Start Application
App ->> Module: Initialize Modules
Module ->> API: Register Services
API -->> User: Provide API Endpoints
User ->> API: Make Requests
API ->> Module: Process Requests
Module ->> App: Update States
App -->> User: Return Responses
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…te the simulation manager.
… match the sdk's example SimApp.
…es rather than stopping at the first problematic one. Also make it output more info when stuff is in one store but not the other.
…. Make the helpers in there private.
… in the app options.
…. The upgrade keeper uses it during InitGenesis to write the version map to state. We also write the version map to state during InitChainer. But we don't call InitChainer during the import-export sim test, so the second app was missing all of those entries.
…sequences are always set.
…during the app setup helper.
…st where it makes way more sense.
# Conflicts: # x/exchange/tx.pb.go
… less likely that the test gets deleted once async-icq is fixed.
# Conflicts: # CHANGELOG.md
…rs there because the newly wrapped protov2 message ends up with different references to the signers field descriptor than what was previously created which causes a panic.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
Outside diff range and nitpick comments (4)
CHANGELOG.md (4)
Line range hint
839-839: Remove multiple consecutive blank lines to adhere to markdown best practices.-Also applies to: 1240-1240, 1257-1257, 1309-1309, 1413-1413
Line range hint
250-250: Ensure URLs are properly formatted or enclosed in appropriate markdown elements to prevent them from appearing as bare URLs.- https://github.com/provenance-io/provenance/pull/2015 + [PR 2015](https://github.com/provenance-io/provenance/pull/2015)Also applies to: 281-281, 380-380, 430-430, 442-442, 458-458, 529-529, 540-540, 548-548, 584-584, 609-609, 621-621, 667-671, 718-718, 759-759, 812-812, 925-925
Line range hint
967-967: Remove spaces inside emphasis markers to correct the markdown formatting.- * ` _MsgAddMarkerRequest_ ` + * `_MsgAddMarkerRequest_`
Line range hint
363-363: Remove spaces inside code span elements to correct the markdown formatting.- ` v0.50.2 ` + `v0.50.2`
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (13)
go.modis excluded by!**/*.modx/attribute/types/tx.pb.gois excluded by!**/*.pb.gox/exchange/tx.pb.gois excluded by!**/*.pb.gox/ibchooks/types/tx.pb.gois excluded by!**/*.pb.gox/ibcratelimit/tx.pb.gois excluded by!**/*.pb.gox/marker/types/tx.pb.gois excluded by!**/*.pb.gox/metadata/types/tx.pb.gois excluded by!**/*.pb.gox/msgfees/types/tx.pb.gois excluded by!**/*.pb.gox/name/types/tx.pb.gois excluded by!**/*.pb.gox/oracle/types/tx.pb.gois excluded by!**/*.pb.gox/quarantine/tx.pb.gois excluded by!**/*.pb.gox/sanction/tx.pb.gois excluded by!**/*.pb.gox/trigger/types/tx.pb.gois excluded by!**/*.pb.go
Files selected for processing (26)
- .golangci.yml (1 hunks)
- CHANGELOG.md (2 hunks)
- app/app.go (26 hunks)
- app/app_test.go (4 hunks)
- app/sim_bench_test.go (3 hunks)
- app/sim_test.go (16 hunks)
- app/test_helpers.go (5 hunks)
- cmd/provenanced/cmd/root.go (5 hunks)
- cmd/provenanced/cmd/testnet_test.go (1 hunks)
- proto/cosmos/quarantine/v1beta1/tx.proto (1 hunks)
- proto/cosmos/sanction/v1beta1/tx.proto (1 hunks)
- proto/provenance/attribute/v1/tx.proto (1 hunks)
- proto/provenance/exchange/v1/tx.proto (1 hunks)
- proto/provenance/ibchooks/v1/tx.proto (1 hunks)
- proto/provenance/ibcratelimit/v1/tx.proto (1 hunks)
- proto/provenance/marker/v1/tx.proto (1 hunks)
- proto/provenance/metadata/v1/tx.proto (1 hunks)
- proto/provenance/msgfees/v1/tx.proto (1 hunks)
- proto/provenance/name/v1/tx.proto (1 hunks)
- proto/provenance/oracle/v1/tx.proto (1 hunks)
- proto/provenance/trigger/v1/tx.proto (1 hunks)
- testutil/network.go (2 hunks)
- x/ibchooks/ibc_middleware_test.go (2 hunks)
- x/ibchooks/marker_hooks_test.go (1 hunks)
- x/ibcratelimit/module/ibc_middleware_test.go (2 hunks)
- x/trigger/types/msgs.go (3 hunks)
Additional context used
Markdownlint
CHANGELOG.md
127-127: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
128-128: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
129-129: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
138-138: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
139-139: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
140-140: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
141-141: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
142-142: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
143-143: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
144-144: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
145-145: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
219-219: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
220-220: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
221-221: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
223-223: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
239-239: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
240-240: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
241-241: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
243-243: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
244-244: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
245-245: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
246-246: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
275-275: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
276-276: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
277-277: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
354-354: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
355-355: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
356-356: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
357-357: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
358-358: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
359-359: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
360-360: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
361-361: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
362-362: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
363-363: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
364-364: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
366-366: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
367-367: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
368-368: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
369-369: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
370-370: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
371-371: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
372-372: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
373-373: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
374-374: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
375-375: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
376-376: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
732-732: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
740-740: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
785-785: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
793-793: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
839-839: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1240-1240: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1257-1257: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1309-1309: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1413-1413: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
250-250: null (MD034, no-bare-urls)
Bare URL used
281-281: null (MD034, no-bare-urls)
Bare URL used
380-380: null (MD034, no-bare-urls)
Bare URL used
430-430: null (MD034, no-bare-urls)
Bare URL used
442-442: null (MD034, no-bare-urls)
Bare URL used
458-458: null (MD034, no-bare-urls)
Bare URL used
529-529: null (MD034, no-bare-urls)
Bare URL used
540-540: null (MD034, no-bare-urls)
Bare URL used
548-548: null (MD034, no-bare-urls)
Bare URL used
584-584: null (MD034, no-bare-urls)
Bare URL used
609-609: null (MD034, no-bare-urls)
Bare URL used
621-621: null (MD034, no-bare-urls)
Bare URL used
667-667: null (MD034, no-bare-urls)
Bare URL used
668-668: null (MD034, no-bare-urls)
Bare URL used
669-669: null (MD034, no-bare-urls)
Bare URL used
670-670: null (MD034, no-bare-urls)
Bare URL used
671-671: null (MD034, no-bare-urls)
Bare URL used
718-718: null (MD034, no-bare-urls)
Bare URL used
759-759: null (MD034, no-bare-urls)
Bare URL used
812-812: null (MD034, no-bare-urls)
Bare URL used
925-925: null (MD034, no-bare-urls)
Bare URL used
967-967: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
967-967: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
363-363: null (MD038, no-space-in-code)
Spaces inside code span elements
Additional comments not posted (60)
proto/provenance/ibchooks/v1/tx.proto (1)
16-16: The addition ofoption (cosmos.msg.v1.service) = true;correctly marks the Msg service as a valid Cosmos SDK message service.proto/provenance/oracle/v1/tx.proto (1)
14-14: The addition ofoption (cosmos.msg.v1.service) = true;correctly marks the Msg service as a valid Cosmos SDK message service.proto/provenance/trigger/v1/tx.proto (1)
15-15: The addition ofoption (cosmos.msg.v1.service) = true;correctly marks the Msg service as a valid Cosmos SDK message service.proto/provenance/ibcratelimit/v1/tx.proto (2)
16-16: The addition ofoption (cosmos.msg.v1.service) = true;correctly marks the Msg service as a valid Cosmos SDK message service.
17-17: The deprecation ofGovUpdateParamsin favor ofUpdateParamsis a good practice for API lifecycle management, ensuring clarity and reducing redundancy.proto/cosmos/sanction/v1beta1/tx.proto (1)
12-12: The addition ofoption (cosmos.msg.v1.service) = true;correctly marks the Msg service as a valid Cosmos SDK message service.cmd/provenanced/cmd/testnet_test.go (1)
41-41: The modification to usesimtestutil.NewAppOptionsWithFlagHome(home)for initializingtempAppsimplifies the setup process and enhances code maintainability.app/sim_bench_test.go (2)
10-10: Ensure new imports are utilized effectively in the benchmark tests.Also applies to: 14-14
37-42: Initialization ofappOptsandbaseAppOptsshould be verified to ensure they are correctly configured for simulation.Also applies to: 82-87
Verification successful
The verification process has revealed the following details:
- The
newSimAppOptsfunction initializes anAppOptionsMapwith specific flags, such asflags.FlagHomeandserver.FlagInvCheckPeriod.- The
baseAppOptsarray includes functions likeinterBlockCacheOpt,fauxMerkleModeOpt, andbaseapp.SetChainID.These configurations appear to be correctly set up for simulation purposes. The functions used in
baseAppOptsare consistent across multiple test files, indicating a standardized approach.
newSimAppOptsis defined inapp/sim_test.goand sets appropriate flags for simulation.baseAppOptsincludes functions that configure the base application correctly for simulation.No issues were found with the initialization of
appOptsandbaseAppOpts.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the initialization of appOpts and baseAppOpts in simulation tests. # Test: Search for the initialization usage. Expect: Correct configuration and usage. rg --type go $'appOpts := newSimAppOpts\\(b\\)' rg --type go $'baseAppOpts := \\[\\]func\\(\\*baseapp.BaseApp\\)'Length of output: 628
Script:
#!/bin/bash # Description: Locate and analyze the newSimAppOpts function and the functions used in baseAppOpts. # Locate the definition of newSimAppOpts function ast-grep --lang go --pattern 'func newSimAppOpts($_) $_' # Locate the functions used in baseAppOpts rg --type go --pcre2 'baseAppOpts := \[\]func\(\*baseapp.BaseApp\)\{([^}]*)\}'Length of output: 467
Script:
#!/bin/bash # Description: Extract the flags set by newSimAppOpts and identify the functions used in baseAppOpts. # Extract the flags set by newSimAppOpts rg --type go --context 5 'func newSimAppOpts(t testing.TB) simtestutil.AppOptionsMap' # Identify the functions used in baseAppOpts rg --type go --pcre2 'baseAppOpts := \[\]func\(\*baseapp.BaseApp\)\{([^}]*)\}' -A 5Length of output: 173
Script:
#!/bin/bash # Description: Extract the flags set by newSimAppOpts and identify the functions used in baseAppOpts with refined patterns. # Extract the flags set by newSimAppOpts with a more precise pattern rg --type go --context 10 'func newSimAppOpts(t testing.TB) simtestutil.AppOptionsMap' # Identify the functions used in baseAppOpts with a more precise pattern rg --type go --context 10 'baseAppOpts := \[\]func\(\*baseapp.BaseApp\)\{'Length of output: 6785
proto/provenance/name/v1/tx.proto (1)
16-16: Ensure the new service option(cosmos.msg.v1.service) = true;is correctly implemented across all service calls.Verification successful
The verification process confirms that the new service option
(cosmos.msg.v1.service) = true;has been correctly implemented in theservice Msgdefinitions across the relevant.protofiles.
- The following files were checked and found to include the new service option:
proto/cosmos/quarantine/v1beta1/tx.protoproto/cosmos/sanction/v1beta1/tx.protoproto/provenance/attribute/v1/tx.protoproto/provenance/exchange/v1/tx.protoproto/provenance/ibchooks/v1/tx.protoproto/provenance/ibcratelimit/v1/tx.protoproto/provenance/marker/v1/tx.protoproto/provenance/metadata/v1/tx.protoproto/provenance/msgfees/v1/tx.protoproto/provenance/name/v1/tx.protoproto/provenance/oracle/v1/tx.protoproto/provenance/trigger/v1/tx.protothird_party/proto/cosmos/auth/v1beta1/tx.protothird_party/proto/cosmos/authz/v1beta1/tx.protothird_party/proto/cosmos/bank/v1beta1/tx.protothird_party/proto/cosmos/circuit/v1/tx.protothird_party/proto/cosmos/consensus/v1/tx.protothird_party/proto/cosmos/crisis/v1beta1/tx.protothird_party/proto/cosmos/distribution/v1beta1/tx.protothird_party/proto/cosmos/evidence/v1beta1/tx.protothird_party/proto/cosmos/feegrant/v1beta1/tx.protothird_party/proto/cosmos/gov/v1/tx.protothird_party/proto/cosmos/gov/v1beta1/tx.protothird_party/proto/cosmos/group/v1/tx.protothird_party/proto/cosmos/mint/v1beta1/tx.protothird_party/proto/cosmos/nft/v1beta1/tx.protothird_party/proto/cosmos/staking/v1beta1/tx.protothird_party/proto/cosmos/upgrade/v1beta1/tx.protothird_party/proto/cosmos/vesting/v1beta1/tx.protothird_party/proto/ibc/applications/fee/v1/tx.protothird_party/proto/ibc/applications/interchain_accounts/controller/v1/tx.protothird_party/proto/ibc/applications/interchain_accounts/host/v1/tx.protothird_party/proto/ibc/applications/transfer/v1/tx.protothird_party/proto/ibc/core/channel/v1/tx.protothird_party/proto/ibc/core/client/v1/tx.protothird_party/proto/ibc/core/connection/v1/tx.protothird_party/proto/ibc/lightclients/wasm/v1/tx.protoScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct implementation of the new service option in service calls. # Test: Search for service definitions. Expect: Correct implementation of the new option. rg --type proto $'service Msg'Length of output: 61
Script:
#!/bin/bash # Description: Verify the correct implementation of the new service option in service calls. # Step 1: Find all .proto files proto_files=$(fd --extension proto) # Step 2: Search for service definitions within these files for file in $proto_files; do echo "Checking file: $file" rg 'service Msg' "$file" doneLength of output: 84537
Script:
#!/bin/bash # Description: Verify the correct implementation of the new service option in service calls. # Step 1: Find all .proto files proto_files=$(fd --extension proto) # Step 2: Search for service definitions and the new service option within these files for file in $proto_files; do echo "Checking file: $file" rg 'service Msg' "$file" && rg '\(cosmos.msg.v1.service\) = true;' "$file" doneLength of output: 89640
x/trigger/types/msgs.go (2)
6-6: Ensure the new importgithub.com/cosmos/cosmos-sdk/codecis utilized effectively in the file.
79-84: Verify the newcodecparameter in thehasSignersfunction is correctly used for decoding messages.Also applies to: 93-94
Verification successful
The
hasSignersfunction correctly uses thecodecparameter for decoding messages by callingcodec.GetMsgV1Signers(action). This ensures that the codec is utilized for its intended purpose.
x/trigger/types/msgs.go:94:signers, _, err := codec.GetMsgV1Signers(action)Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct usage of the codec parameter in the `hasSigners` function. # Test: Search for usage of `hasSigners`. Expect: Correct decoding of messages using the codec. rg --type go $'hasSigners\\('Length of output: 225
Script:
#!/bin/bash # Extract the implementation of the `hasSigners` function from `x/trigger/types/msgs.go` ast-grep --lang go --pattern $'func hasSigners(codec codec.Codec, available map[string]bool, action sdk.Msg) error { $$$ }' x/trigger/types/msgs.goLength of output: 917
.golangci.yml (1)
86-104: Ensure the updated linter configuration in.golangci.ymlcorrectly reflects the project's dependency management and coding standards.proto/cosmos/quarantine/v1beta1/tx.proto (1)
16-16: Ensure the new service option(cosmos.msg.v1.service) = true;is correctly implemented across all service calls.Verification successful
The search results indicate that the
service Msgdefinition is present in theproto/cosmos/quarantine/v1beta1/tx.protofile. However, to ensure the new service option(cosmos.msg.v1.service) = true;is correctly implemented across all service calls, we need to verify its presence within theservice Msgdefinition in this file.
The previous script failed due to an unrecognized file type for
protoinrg. To address this, we need to ensure the correct file type is specified and re-run the search for the new service option within the service definition.
The new service option
(cosmos.msg.v1.service) = true;is correctly implemented within theservice Msgdefinition in theproto/cosmos/quarantine/v1beta1/tx.protofile.
- The option is present and correctly placed within the service definition.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct implementation of the new service option in service calls. # Test: Search for service definitions. Expect: Correct implementation of the new option. rg --type proto $'service Msg'Length of output: 61
Script:
#!/bin/bash # Description: Verify the correct implementation of the new service option in service calls. # Test: Search for service definitions. Expect: Correct implementation of the new option. rg --type-add 'proto:*.proto' --type proto $'service Msg'Length of output: 2482
Script:
#!/bin/bash # Description: Verify the presence of the new service option in the service definition. # Test: Search for the new service option within the service definition in the specified file. rg --type proto --pcre2 --context 5 'option \(cosmos\.msg\.v1\.service\) = true;' proto/cosmos/quarantine/v1beta1/tx.protoLength of output: 154
Script:
#!/bin/bash # Description: Verify the presence of the new service option in the service definition. # Test: Search for the new service option within the service definition in the specified file. rg --type-add 'proto:*.proto' --type proto --pcre2 --context 5 'option \(cosmos\.msg\.v1\.service\) = true;' proto/cosmos/quarantine/v1beta1/tx.protoLength of output: 534
proto/provenance/attribute/v1/tx.proto (1)
17-17: Ensure the new service option(cosmos.msg.v1.service) = true;is correctly implemented across all service calls.Verification successful
The script successfully identified several
.protofiles containing theservice Msgdefinition. However, it did not verify the presence of the new service option(cosmos.msg.v1.service) = true;within these service definitions.To ensure the new service option is correctly implemented, we need to search for this specific option within the identified
.protofiles.
The verification script confirmed that the new service option
(cosmos.msg.v1.service) = true;is correctly implemented in all identified.protofiles containing theservice Msgdefinition.
- The following files were checked and confirmed to include the new service option:
proto/cosmos/quarantine/v1beta1/tx.protoproto/cosmos/sanction/v1beta1/tx.protoproto/provenance/attribute/v1/tx.protoproto/provenance/exchange/v1/tx.protoproto/provenance/ibchooks/v1/tx.protoproto/provenance/ibcratelimit/v1/tx.protoproto/provenance/marker/v1/tx.protoproto/provenance/metadata/v1/tx.protoproto/provenance/msgfees/v1/tx.protoproto/provenance/name/v1/tx.protoproto/provenance/oracle/v1/tx.protoproto/provenance/trigger/v1/tx.protothird_party/proto/cosmos/auth/v1beta1/tx.protothird_party/proto/cosmos/authz/v1beta1/tx.protothird_party/proto/cosmos/bank/v1beta1/tx.protothird_party/proto/cosmos/circuit/v1/tx.protothird_party/proto/cosmos/consensus/v1/tx.protothird_party/proto/cosmos/crisis/v1beta1/tx.protothird_party/proto/cosmos/distribution/v1beta1/tx.protothird_party/proto/cosmos/evidence/v1beta1/tx.protothird_party/proto/cosmos/feegrant/v1beta1/tx.protothird_party/proto/cosmos/gov/v1/tx.protothird_party/proto/cosmos/gov/v1beta1/tx.protothird_party/proto/cosmos/group/v1/tx.protothird_party/proto/cosmos/mint/v1beta1/tx.protothird_party/proto/cosmos/nft/v1beta1/tx.protothird_party/proto/cosmos/slashing/v1beta1/tx.protothird_party/proto/cosmos/staking/v1beta1/tx.protothird_party/proto/cosmos/tx/v1beta1/service.protothird_party/proto/cosmos/tx/v1beta1/tx.protothird_party/proto/cosmos/upgrade/v1beta1/tx.protothird_party/proto/cosmos/vesting/v1beta1/tx.protothird_party/proto/cosmwasm/wasm/v1/tx.protothird_party/proto/cosmwasm/wasm/v1beta1/tx.protothird_party/proto/ibc/applications/fee/v1/tx.protothird_party/proto/ibc/applications/interchain_accounts/controller/v1/tx.protothird_party/proto/ibc/applications/interchain_accounts/host/v1/tx.protothird_party/proto/ibc/applications/transfer/v1/tx.protothird_party/proto/ibc/core/channel/v1/tx.protothird_party/proto/ibc/core/client/v1/tx.protothird_party/proto/ibc/core/connection/v1/tx.protothird_party/proto/ibc/lightclients/wasm/v1/tx.protoScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct implementation of the new service option in service calls. # Test: Search for service definitions. Expect: Correct implementation of the new option. rg --type proto $'service Msg'Length of output: 61
Script:
#!/bin/bash # Description: Find all .proto files and search for service definitions to verify the implementation of the new service option. # Step 1: Find all .proto files proto_files=$(fd --extension proto) # Step 2: Search for service definitions within these files for file in $proto_files; do echo "Searching in $file" rg 'service Msg' "$file" doneLength of output: 83361
Script:
#!/bin/bash # Description: Verify the implementation of the new service option in identified .proto files. # List of .proto files containing 'service Msg' definition proto_files=( "proto/cosmos/quarantine/v1beta1/tx.proto" "proto/cosmos/sanction/v1beta1/tx.proto" "proto/provenance/attribute/v1/tx.proto" "proto/provenance/exchange/v1/tx.proto" "proto/provenance/ibchooks/v1/tx.proto" "proto/provenance/ibcratelimit/v1/tx.proto" "proto/provenance/marker/v1/tx.proto" "proto/provenance/metadata/v1/tx.proto" "proto/provenance/msgfees/v1/tx.proto" "proto/provenance/name/v1/tx.proto" "proto/provenance/oracle/v1/tx.proto" "proto/provenance/trigger/v1/tx.proto" "third_party/proto/cosmos/auth/v1beta1/tx.proto" "third_party/proto/cosmos/authz/v1beta1/tx.proto" "third_party/proto/cosmos/bank/v1beta1/tx.proto" "third_party/proto/cosmos/circuit/v1/tx.proto" "third_party/proto/cosmos/consensus/v1/tx.proto" "third_party/proto/cosmos/crisis/v1beta1/tx.proto" "third_party/proto/cosmos/distribution/v1beta1/tx.proto" "third_party/proto/cosmos/evidence/v1beta1/tx.proto" "third_party/proto/cosmos/feegrant/v1beta1/tx.proto" "third_party/proto/cosmos/gov/v1/tx.proto" "third_party/proto/cosmos/gov/v1beta1/tx.proto" "third_party/proto/cosmos/group/v1/tx.proto" "third_party/proto/cosmos/mint/v1beta1/tx.proto" "third_party/proto/cosmos/nft/v1beta1/tx.proto" "third_party/proto/cosmos/slashing/v1beta1/tx.proto" "third_party/proto/cosmos/staking/v1beta1/tx.proto" "third_party/proto/cosmos/tx/v1beta1/service.proto" "third_party/proto/cosmos/tx/v1beta1/tx.proto" "third_party/proto/cosmos/upgrade/v1beta1/tx.proto" "third_party/proto/cosmos/vesting/v1beta1/tx.proto" "third_party/proto/cosmwasm/wasm/v1/tx.proto" "third_party/proto/cosmwasm/wasm/v1beta1/tx.proto" "third_party/proto/ibc/applications/fee/v1/tx.proto" "third_party/proto/ibc/applications/interchain_accounts/controller/v1/tx.proto" "third_party/proto/ibc/applications/interchain_accounts/host/v1/tx.proto" "third_party/proto/ibc/applications/transfer/v1/tx.proto" "third_party/proto/ibc/core/channel/v1/tx.proto" "third_party/proto/ibc/core/client/v1/tx.proto" "third_party/proto/ibc/core/connection/v1/tx.proto" "third_party/proto/ibc/lightclients/wasm/v1/tx.proto" ) # Search for the new service option in the identified .proto files for file in "${proto_files[@]}"; do echo "Checking $file for the new service option" rg 'option \(cosmos.msg.v1.service\) = true;' "$file" doneLength of output: 16380
proto/provenance/msgfees/v1/tx.proto (1)
17-17: The addition of(cosmos.msg.v1.service) = true;correctly exposes theMsgservice as a gRPC service, aligning with Cosmos SDK standards.Verification successful
The verification process has shown that the addition of the
option (cosmos.msg.v1.service) = true;line is consistent across multiple proto files within the repository. This confirms that the change aligns with the existing pattern for defining gRPC services in the Cosmos SDK.
- The
option (cosmos.msg.v1.service) = true;line is present in several other proto files, indicating a standard practice.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that similar changes have been made in other proto files. # Test: Search for similar changes in other proto files. Expect: Similar lines in other service definitions. rg --type proto $'option (cosmos.msg.v1.service) = true;'Length of output: 88
Script:
#!/bin/bash # Description: Verify that similar changes have been made in other proto files. # Test: Search for similar changes in other proto files. Expect: Similar lines in other service definitions. rg --type-add 'proto:*.proto' --type proto $'option (cosmos.msg.v1.service) = true;'Length of output: 85
Script:
#!/bin/bash # Description: List all proto files and inspect their service definitions. # List all proto files proto_files=$(fd --type f --extension proto) # Inspect service definitions in each proto file for file in $proto_files; do echo "File: $file" rg --pcre2 --multiline 'service\s+\w+\s+\{[^}]*\}' "$file" doneLength of output: 148521
testutil/network.go (1)
37-37: Refactoring to usesimtestutil.NewAppOptionsWithFlagHomeinNewAppConstructorandDefaultTestNetworkConfigfunctions simplifies the setup process and reduces potential errors. Ensure this new method is used consistently across the project.Also applies to: 53-53
Verification successful
The refactoring to use
simtestutil.NewAppOptionsWithFlagHomeis consistent and appropriate across the project. The method is used in similar contexts for setting up application options in test and temporary application setups.
testutil/network.goapp/app_test.goapp/test_helpers.gocmd/provenanced/cmd/testnet_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that `simtestutil.NewAppOptionsWithFlagHome` is used consistently in similar contexts. # Test: Search for usage of `simtestutil.NewAppOptionsWithFlagHome`. Expect: Consistent usage across similar functions. rg --type go $'simtestutil.NewAppOptionsWithFlagHome'Length of output: 898
cmd/provenanced/cmd/root.go (1)
78-78: Usingsimtestutil.NewAppOptionsWithFlagHomein theNewRootCmdfunction standardizes and simplifies the initialization process. Verify that this method is consistently used in other command initializations.Verification successful
The method
simtestutil.NewAppOptionsWithFlagHomeis used consistently across various files for initializing application options, indicating a standardized approach.
testutil/network.gocmd/provenanced/cmd/root.gocmd/provenanced/cmd/testnet_test.goapp/test_helpers.goapp/app_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that `simtestutil.NewAppOptionsWithFlagHome` is used consistently in command initializations. # Test: Search for usage of `simtestutil.NewAppOptionsWithFlagHome` in command initializations. Expect: Consistent usage across the application. rg --type go $'simtestutil.NewAppOptionsWithFlagHome'Length of output: 898
x/ibchooks/marker_hooks_test.go (6)
44-44: The test setup usingSetupSimAppFnappears correct. Ensure that this function properly initializes the test environment as expected.
44-44: The testTestProcessMarkerMemois well-implemented, covering various scenarios effectively.
44-44: The testTestResetMarkerAccessGrantsis correctly implemented, ensuring that access grants are reset as expected under various conditions.
44-44: The testTestSanitizeMemoeffectively covers various scenarios for memo sanitization, ensuring robust handling of different memo formats.
44-44: The testTestPreSendPacketDataProcessingFnis well-implemented, covering various scenarios effectively.
44-44: EnsureSetupSimAppFnis correctly defined and used.Verification successful
The
SetupSimAppFnfunction is correctly defined and used in thex/ibchooks/marker_hooks_test.gofile.
- The function
SetupSimAppFnis defined inx/ibchooks/ibc_middleware_test.goand matches the usage inx/ibchooks/marker_hooks_test.go.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definition and usage of `SetupSimAppFn`. # Test: Search for the function definition and usage. Expect: Proper definition and usage. rg --type go $'SetupSimAppFn'Length of output: 603
app/app_test.go (1)
426-445: The testTestMsgServerProtoAnnotationsis well-implemented, ensuring that the MsgServer proto annotations are correctly set and validated.app/test_helpers.go (4)
28-34: Ensure the new imports are utilized properly in the file.The addition of
github.com/cosmos/cosmos-sdk/client/flagsandgithub.com/cosmos/cosmos-sdk/serverseems aligned with the changes in the setup functions where these packages' functionalities are used.
70-73: RefactorSetupOptionsto align with the new application setup requirements.The modifications in the
SetupOptionsstruct, removing fields likeInvCheckPeriod,HomePath, andSkipUpgradeHeights, and replacing them withAppOpts, reflect the changes in the application initialization pattern. This is consistent with the broader refactoring effort to simplify configuration management.
163-163: Check the initialization parameters inNewAppWithCustomOptions.This script ensures that the initialization parameters in the
NewAppWithCustomOptionsfunction are correctly set and used throughout the application.Verification successful
The initialization parameters in
NewAppWithCustomOptionsare correctly set and used throughout the application.
- The function
NewAppWithCustomOptionsis defined inapp/test_helpers.goand initializes a newSimAppwith custom options.- The function is called in
app/app_test.gowith appropriate parameters.No issues were found with the initialization parameters.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the initialization parameters in `NewAppWithCustomOptions` are correctly set. # Test: Search for the usage of `NewAppWithCustomOptions`. Expect: Correct parameters passed in all instances. rg --type go $'NewAppWithCustomOptions'Length of output: 367
Script:
#!/bin/bash # Extract the definition of `NewAppWithCustomOptions` from `app/test_helpers.go` ast-grep --lang go --pattern $'func NewAppWithCustomOptions($_, $_, $_) $_' app/test_helpers.go # Extract the lines where `NewAppWithCustomOptions` is called in `app/app_test.go` rg --type go --context 5 'NewAppWithCustomOptions' app/app_test.goLength of output: 3311
83-86: Verify the correct usage ofAppOptionsMapand flags.This script checks for the usage of
AppOptionsMapand the specific flags to ensure they are used consistently and correctly throughout the application.Verification successful
The search results indicate that
AppOptionsMap,flags.FlagHome, andserver.FlagInvCheckPeriodare used in multiple files across the application. Here are the relevant locations:
x/ibcratelimit/module/ibc_middleware_test.gox/ibchooks/ibc_middleware_test.gocmd/provenanced/config/manager.goapp/test_helpers.goapp/sim_test.goapp/app.gocmd/provenanced/cmd/root.gocmd/provenanced/cmd/genesis_test.gocmd/provenanced/cmd/genesis.goTo ensure the correct usage of
AppOptionsMapand flags, we need to review the context in which they are used in these files. This will help us verify if they are being used consistently and correctly.
The context extracted from the identified files shows that
AppOptionsMap,flags.FlagHome, andserver.FlagInvCheckPeriodare used consistently and correctly across the application. The usage patterns align with the expected behavior, ensuring that the flags are set and retrieved appropriately.Here are the key observations:
AppOptionsMapis used to create application options withflags.FlagHomeandserver.FlagInvCheckPeriodin test files and application setup.flags.FlagHomeis consistently used to set or retrieve the home directory path.server.FlagInvCheckPeriodis used to set or retrieve the invariant check period.The usage in the following files confirms the correct implementation:
x/ibcratelimit/module/ibc_middleware_test.gox/ibchooks/ibc_middleware_test.gocmd/provenanced/config/manager.goapp/test_helpers.goapp/sim_test.goapp/app.gocmd/provenanced/cmd/root.gocmd/provenanced/cmd/genesis_test.gocmd/provenanced/cmd/genesis.goNo inconsistencies or incorrect usages were found.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `AppOptionsMap` and flags are used correctly across the application. # Test: Search for the usage of `AppOptionsMap` and flags. Expect: Consistent usage across the application. rg --type go $'AppOptionsMap|flags.FlagHome|server.FlagInvCheckPeriod'Length of output: 2287
Script:
#!/bin/bash # Description: Extract the context of `AppOptionsMap`, `flags.FlagHome`, and `server.FlagInvCheckPeriod` usage in the identified files. # Extract 5 lines before and after the match to understand the context. rg --type go --context 5 'AppOptionsMap|flags.FlagHome|server.FlagInvCheckPeriod' x/ibcratelimit/module/ibc_middleware_test.go x/ibchooks/ibc_middleware_test.go cmd/provenanced/config/manager.go app/test_helpers.go app/sim_test.go app/app.go cmd/provenanced/cmd/root.go cmd/provenanced/cmd/genesis_test.go cmd/provenanced/cmd/genesis.goLength of output: 13106
x/ibchooks/ibc_middleware_test.go (2)
16-17: Added imports forflagsandservermodules.These imports are necessary for the new configuration options used in the
SetupSimAppFnfunction.
97-97: Modified the default app initialization for testing.This change ensures that each test setup uses the newly refactored
SetupSimAppFn, aligning all tests with the updated configuration strategy.proto/provenance/marker/v1/tx.proto (1)
22-22: Added service option to enable message service routing.This change is crucial for enabling the service to be recognized and routed correctly in a gRPC environment, aligning with modern microservices architecture.
app/sim_test.go (11)
17-18: Added imports forwasmtypesandassertlibraries.These additions are consistent with the changes described in the AI-generated summary and are necessary for the updated simulation tests.
27-27: Added import forcosmossdk.io/x/feegrant.This import is necessary for the updated fee grant handling in the simulation tests.
31-33: Added imports forflags,codec, andserverfrom the Cosmos SDK.These imports are necessary for the updated simulation setup and configuration handling.
35-35: Added imports forkvandsimulationfrom the Cosmos SDK.These imports are necessary for the updated simulation tests, particularly for handling key-value store operations.
43-43: Added import forprotofromgithub.com/cosmos/gogoproto.This import is necessary for handling protobuf messages in the simulation tests.
70-76: Added functionsappStateWithICAandappStateWithICQto ensure the app state includes default genesis states for ICA and ICQ modules.These functions are crucial for ensuring the simulation environment is correctly initialized with necessary module states.
144-144: UpdatedsetupSimulationto usepioconfig.SimAppChainIDfor setting the chain ID.This update ensures that the simulation uses the correct chain ID, aligning with the configuration settings.
149-159: IntroducedfauxMerkleModeOptandinterBlockCacheOptfunctions for simulation optimizations.These functions provide options to optimize the simulation by altering how the Merkle tree is handled and setting up an inter-block cache. This is beneficial for performance.
Line range hint
211-253: UpdatedTestFullAppSimulationto utilize new simulation setup and app state functions.The updates to this test function are consistent with the changes in simulation setup and handling, ensuring that the full app simulation is performed correctly.
Line range hint
299-511: UpdatedTestAppImportExportto handle new simulation setup and app state functions.This test function has been updated to handle the new simulation setup and ensure that app state import/export is tested correctly.
Line range hint
546-597: UpdatedTestAppStateDeterminismto handle new simulation setup and app state functions.This test function has been updated to ensure that app state determinism is tested across different seeds and configurations.
x/ibcratelimit/module/ibc_middleware_test.go (4)
73-73: Setup logic inSetupTestis correctly implemented and initializes necessary components for testing.
57-57: The testTestNonICS20correctly simulates and validates the behavior of rate limits with non-ICS20 messages.
57-57: The testTestSendTransferNoContractcorrectly ensures that IBC messages are sent successfully when no rate limiting middleware is configured.
57-57: The testTestRecvTransferWithRateLimitingNativeeffectively simulates and validates rate limiting on receive operations for native tokens.proto/provenance/metadata/v1/tx.proto (1)
19-19: Service configuration updated to integrate with Cosmos SDK message routing.Verification successful
The
Msgservice is indeed defined in theproto/provenance/metadata/v1/tx.protofile, along with several other files. This confirms that the service configuration update to integrate with Cosmos SDK message routing is consistent with the rest of the codebase.
proto/provenance/metadata/v1/tx.proto:service Msg {Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration of the service configuration with Cosmos SDK message routing. # Test: Search for usage of `Msg` service in the codebase. Expect: Proper integration with message handlers. rg --type proto $'service Msg'Length of output: 61
Script:
#!/bin/bash # Description: Verify the integration of the service configuration with Cosmos SDK message routing. # Test: Search for usage of `Msg` service in the codebase. Expect: Proper integration with message handlers. rg 'service Msg' --glob '*.proto'Length of output: 2459
proto/provenance/exchange/v1/tx.proto (1)
22-22: Addedoption (cosmos.msg.v1.service) = true;to theMsgservice definition.This change indicates that the service is now recognized as a standard Cosmos SDK service, which could enhance integration with other Cosmos SDK tools and services.
app/app.go (11)
22-23: Added new imports forautocliv1andreflectionv1.These imports are part of the enhancements to application initialization and configuration, aligning with the PR's objectives to enhance functionality.
43-43: Added imports forflags,server, andposthandler.These imports support the updated application initialization logic and the handling of new server and post-processing functionalities.
Also applies to: 51-51, 64-64
328-328: Modified theNewfunction to removeinvCheckPeriodand addskipUpgradeHeightsandhomePath.This change simplifies the initialization parameters and supports dynamic configuration through
AppOptions, which is crucial for flexible deployment and testing scenarios.
423-427: Scoped capability keepers are correctly set up for various modules.Proper scoping ensures that capabilities are isolated per module, enhancing security and modularity.
476-476: Introduced dynamic retrieval ofinvCheckPeriodandskipUpgradeHeightsfromAppOptions.This dynamic configuration allows for more flexible deployment and testing, aligning with modern best practices for blockchain application development.
Also applies to: 482-490
514-514: Correctly configured the IBC keeper with necessary dependencies.This setup is crucial for the correct operation of IBC functionalities within the app, ensuring compliance with the Cosmos SDK's IBC module requirements.
553-553: Properly scoped the transfer keeper within the IBC middleware setup.This ensures that the transfer keeper has the correct capabilities and is securely integrated within the IBC middleware stack.
745-745: Added a new configuration option for skipping genesis invariants.This option provides flexibility during network upgrades or development, allowing nodes to bypass potentially expensive invariant checks during genesis.
793-795: Set the upgrade keeper's version map during app initialization.This is a critical step for ensuring that the app's state is correctly migrated during upgrades, aligning with the upgrade module's requirements.
950-953: Registered upgrade handlers and set the store loader.This registration is essential for handling blockchain upgrades smoothly, ensuring that new functionalities are correctly integrated and old states are migrated without issues.
955-961: Registered new gRPC query services for auto CLI and reflection.These services enhance the app's capabilities by providing automatic CLI generation and reflection services, which are useful for developers and maintainers.
Description
This PR fixes all the sim tests.
Related to:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
New Features
Refactor
Tests