-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape the brackets in sanction and quarantine docs. #2007
Conversation
WalkthroughThe recent changes primarily involve escaping curly braces in attribute values for event types related to quarantine and sanction operations. This alteration ensures that curly braces are properly interpreted in the context of event attributes, enhancing the clarity and accuracy of event data representation. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- x/quarantine/spec/04_events.md (2 hunks)
- x/sanction/spec/04_events.md (1 hunks)
Additional Context Used
LanguageTool (10)
x/quarantine/spec/04_events.md (5)
Near line 15: Loose punctuation mark.
Context: ...n account opts into quarantine.@Type
:/cosmos.quarantine.v1beta1.EventOptIn
...
Rule ID: UNLIKELY_OPENING_PUNCTUATION
Near line 25: Loose punctuation mark.
Context: ...account opts out of quarantine.@Type
: `/cosmos.quarantine.v1beta1.EventOptOut...
Rule ID: UNLIKELY_OPENING_PUNCTUATION
Near line 33: It seems likely that a singular genitive (’s) apostrophe is missing.
Context: ...x/bank
module will be the quarantined funds holder account instead of the intended ...
Rule ID: AI_HYDRA_LEO_APOSTROPHE_S_XS
Near line 36: Loose punctuation mark.
Context: ...ollowing event is also emitted.@Type
: `/cosmos.quarantine.v1beta1.EventFundsQ...
Rule ID: UNLIKELY_OPENING_PUNCTUATION
Near line 47: Loose punctuation mark.
Context: ... originally intended recipient.@Type
: `/cosmos.quarantine.v1beta1.EventFundsR...
Rule ID: UNLIKELY_OPENING_PUNCTUATIONx/sanction/spec/04_events.md (5)
Near line 16: Loose punctuation mark.
Context: ... when an account is sanctioned.@Type
: `/cosmos.sanction.v1beta1.EventAddressS...
Rule ID: UNLIKELY_OPENING_PUNCTUATION
Near line 26: Loose punctuation mark.
Context: ...hen an account is unsanctioned.@Type
: `/cosmos.sanction.v1beta1.EventAddressU...
Rule ID: UNLIKELY_OPENING_PUNCTUATION
Near line 36: Loose punctuation mark.
Context: ...nction is placed on an account.@Type
: `/cosmos.sanction.v1beta1.EventTempAddr...
Rule ID: UNLIKELY_OPENING_PUNCTUATION
Near line 46: Loose punctuation mark.
Context: ...nction is placed on an account.@Type
: `/cosmos.sanction.v1beta1.EventTempAddr...
Rule ID: UNLIKELY_OPENING_PUNCTUATION
Near line 56: Loose punctuation mark.
Context: ...nmodule's params are updated.
@type:
/cosmos.sanction.v1beta1.EventParamsUp...
Rule ID: UNLIKELY_OPENING_PUNCTUATION
Markdownlint (9)
x/quarantine/spec/04_events.md (4)
6: Expected: 0; Actual: 2
Unordered list indentation
7: Expected: 0; Actual: 2
Unordered list indentation
8: Expected: 0; Actual: 2
Unordered list indentation
9: Expected: 0; Actual: 2
Unordered list indentationx/sanction/spec/04_events.md (5)
6: Expected: 0; Actual: 2
Unordered list indentation
7: Expected: 0; Actual: 2
Unordered list indentation
8: Expected: 0; Actual: 2
Unordered list indentation
9: Expected: 0; Actual: 2
Unordered list indentation
10: Expected: 0; Actual: 2
Unordered list indentation
Additional comments not posted (8)
x/quarantine/spec/04_events.md (4)
19-19
: Escaping curly braces ensures proper rendering in Docusaurus. Good job on this fix.
29-29
: Proper escaping of curly braces in the attribute value. This change is consistent with the PR objectives.
40-41
: The escaping of curly braces in bothto_address
andcoins
attributes is correctly implemented.
51-52
: Correct implementation of escaping in the attribute values. This ensures that the documentation will render correctly in Docusaurus.x/sanction/spec/04_events.md (4)
20-20
: Correctly escaped curly braces in the attribute value, ensuring proper rendering in Docusaurus.
30-30
: The escaping of curly braces is consistent and correct, aligning with the PR objectives.
40-40
: Properly escaped curly braces in the attribute value. This change is consistent and necessary for correct documentation rendering.
50-50
: The escaping of curly braces is implemented correctly across all relevant attributes, ensuring consistency and correct rendering.
Description
The non escaped brackets are breaking the dev-portal. Need to have them escaped for the docusaurus renderer.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passesSummary by CodeRabbit