Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ica proposal sims #1998

Merged
merged 9 commits into from
May 24, 2024
Merged

Update ica proposal sims #1998

merged 9 commits into from
May 24, 2024

Conversation

Taztingo
Copy link
Contributor

@Taztingo Taztingo commented May 23, 2024 •
edited by coderabbitai bot
Loading

Description

Updates our ibc-go dependency to to our fork containing the fix to conditionally give sim proposal messages.

closes: #1997

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Summary by CodeRabbit

  • Chores
    • Updated dependency github.com/cosmos/ibc-go/v8 to forked tag v8.2.1-pio-1.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 23, 2024 •
edited
Loading

Walkthrough

The primary change involves updating the CHANGELOG.md to reflect the dependency update of github.com/cosmos/ibc-go/v8 to a forked tag v8.2.1-pio-1. This update does not alter any declarations of exported or public entities.

Changes

Files Change Summary
CHANGELOG.md Updated dependency github.com/cosmos/ibc-go/v8 to forked tag v8.2.1-pio-1

Assessment against linked issues

Objective (Issue #) Addressed Explanation
ICA simtests require an application to have both the controller and host modules (#1997) ❓ The update to the forked tag v8.2.1-pio-1 may address the issue, but the changelog does not specify changes to simtests directly.

In code we trust, dependencies align,
With updates forked, the stars now shine.
Simtests may dance, both host and control,
In the realm of chains, they play their role.
A rabbit's joy in every line! 🐇✨

Tip

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

  • Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
  • Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
  • Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

  • Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
  • Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
  • High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
  • Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Taztingo Taztingo marked this pull request as ready for review May 23, 2024 15:56
@Taztingo Taztingo requested a review from a team as a code owner May 23, 2024 15:56
coderabbitai[bot]
coderabbitai bot reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (5)
CHANGELOG.md (5)

Line range hint 110-356: Consider using a consistent list marker style in Markdown. The document uses dashes (-) instead of asterisks (*) inconsistently. For better consistency and readability, choose one style and use it throughout the document.

- - Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))
+ * Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))

Also applies to: 712-712, 720-720, 765-765, 773-773

Line range hint 819-819: There are multiple consecutive blank lines found in the document. It's a good practice to limit consecutive blank lines to one for better readability and to maintain a clean and professional appearance in the document.

- 
-
+

Also applies to: 1220-1220, 1237-1237, 1289-1289, 1393-1393

Line range hint 230-230: Consider using Markdown link syntax instead of bare URLs for better readability and to make the document look cleaner.

- https://github.com/provenance-io/provenance/pull/1910
+ [PR #1910](https://github.com/provenance-io/provenance/pull/1910)

Also applies to: 261-261, 360-360, 410-410, 422-422, 438-438, 509-509, 520-520, 528-528, 564-564, 589-589, 601-601, 647-647, 648-648, 649-649, 650-650, 651-651, 698-698, 739-739, 792-792, 905-905

Line range hint 947-947: There are spaces inside emphasis markers. It's recommended to remove any leading or trailing spaces inside emphasis markers to adhere to Markdown best practices.

- * Bump ` github.com/cosmos/ibc-go/v8 ` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))
+ * Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))

Line range hint 343-343: There are spaces inside code span elements. It's recommended to remove any leading or trailing spaces inside code span elements to adhere to Markdown best practices.

- ` github.com/cosmos/ibc-go/v8 `
+ `github.com/cosmos/ibc-go/v8`
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 86b2af7 and c579090.
Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional Context Used
Markdownlint (109)
CHANGELOG.md (109)

110: Expected: asterisk; Actual: dash
Unordered list style

111: Expected: asterisk; Actual: dash
Unordered list style

112: Expected: asterisk; Actual: dash
Unordered list style

113: Expected: asterisk; Actual: dash
Unordered list style

114: Expected: asterisk; Actual: dash
Unordered list style

115: Expected: asterisk; Actual: dash
Unordered list style

116: Expected: asterisk; Actual: dash
Unordered list style

117: Expected: asterisk; Actual: dash
Unordered list style

118: Expected: asterisk; Actual: dash
Unordered list style

119: Expected: asterisk; Actual: dash
Unordered list style

120: Expected: asterisk; Actual: dash
Unordered list style

121: Expected: asterisk; Actual: dash
Unordered list style

122: Expected: asterisk; Actual: dash
Unordered list style

123: Expected: asterisk; Actual: dash
Unordered list style

124: Expected: asterisk; Actual: dash
Unordered list style

125: Expected: asterisk; Actual: dash
Unordered list style

126: Expected: asterisk; Actual: dash
Unordered list style

195: Expected: asterisk; Actual: dash
Unordered list style

196: Expected: asterisk; Actual: dash
Unordered list style

197: Expected: asterisk; Actual: dash
Unordered list style

198: Expected: asterisk; Actual: dash
Unordered list style

199: Expected: asterisk; Actual: dash
Unordered list style

200: Expected: asterisk; Actual: dash
Unordered list style

201: Expected: asterisk; Actual: dash
Unordered list style

202: Expected: asterisk; Actual: dash
Unordered list style

203: Expected: asterisk; Actual: dash
Unordered list style

204: Expected: asterisk; Actual: dash
Unordered list style

205: Expected: asterisk; Actual: dash
Unordered list style

206: Expected: asterisk; Actual: dash
Unordered list style

207: Expected: asterisk; Actual: dash
Unordered list style

208: Expected: asterisk; Actual: dash
Unordered list style

209: Expected: asterisk; Actual: dash
Unordered list style

210: Expected: asterisk; Actual: dash
Unordered list style

211: Expected: asterisk; Actual: dash
Unordered list style

212: Expected: asterisk; Actual: dash
Unordered list style

213: Expected: asterisk; Actual: dash
Unordered list style

214: Expected: asterisk; Actual: dash
Unordered list style

215: Expected: asterisk; Actual: dash
Unordered list style

216: Expected: asterisk; Actual: dash
Unordered list style

217: Expected: asterisk; Actual: dash
Unordered list style

218: Expected: asterisk; Actual: dash
Unordered list style

219: Expected: asterisk; Actual: dash
Unordered list style

220: Expected: asterisk; Actual: dash
Unordered list style

221: Expected: asterisk; Actual: dash
Unordered list style

222: Expected: asterisk; Actual: dash
Unordered list style

223: Expected: asterisk; Actual: dash
Unordered list style

224: Expected: asterisk; Actual: dash
Unordered list style

225: Expected: asterisk; Actual: dash
Unordered list style

226: Expected: asterisk; Actual: dash
Unordered list style

255: Expected: asterisk; Actual: dash
Unordered list style

256: Expected: asterisk; Actual: dash
Unordered list style

257: Expected: asterisk; Actual: dash
Unordered list style

334: Expected: asterisk; Actual: dash
Unordered list style

335: Expected: asterisk; Actual: dash
Unordered list style

336: Expected: asterisk; Actual: dash
Unordered list style

337: Expected: asterisk; Actual: dash
Unordered list style

338: Expected: asterisk; Actual: dash
Unordered list style

339: Expected: asterisk; Actual: dash
Unordered list style

340: Expected: asterisk; Actual: dash
Unordered list style

341: Expected: asterisk; Actual: dash
Unordered list style

342: Expected: asterisk; Actual: dash
Unordered list style

343: Expected: asterisk; Actual: dash
Unordered list style

344: Expected: asterisk; Actual: dash
Unordered list style

345: Expected: asterisk; Actual: dash
Unordered list style

346: Expected: asterisk; Actual: dash
Unordered list style

347: Expected: asterisk; Actual: dash
Unordered list style

348: Expected: asterisk; Actual: dash
Unordered list style

349: Expected: asterisk; Actual: dash
Unordered list style

350: Expected: asterisk; Actual: dash
Unordered list style

351: Expected: asterisk; Actual: dash
Unordered list style

352: Expected: asterisk; Actual: dash
Unordered list style

353: Expected: asterisk; Actual: dash
Unordered list style

354: Expected: asterisk; Actual: dash
Unordered list style

355: Expected: asterisk; Actual: dash
Unordered list style

356: Expected: asterisk; Actual: dash
Unordered list style

712: Expected: asterisk; Actual: dash
Unordered list style

720: Expected: asterisk; Actual: dash
Unordered list style

765: Expected: asterisk; Actual: dash
Unordered list style

773: Expected: asterisk; Actual: dash
Unordered list style

819: Expected: 1; Actual: 2
Multiple consecutive blank lines

1220: Expected: 1; Actual: 2
Multiple consecutive blank lines

1237: Expected: 1; Actual: 2
Multiple consecutive blank lines

1289: Expected: 1; Actual: 2
Multiple consecutive blank lines

1393: Expected: 1; Actual: 2
Multiple consecutive blank lines

126: null
Lists should be surrounded by blank lines

230: null
Bare URL used

261: null
Bare URL used

360: null
Bare URL used

410: null
Bare URL used

422: null
Bare URL used

438: null
Bare URL used

509: null
Bare URL used

520: null
Bare URL used

528: null
Bare URL used

564: null
Bare URL used

589: null
Bare URL used

601: null
Bare URL used

647: null
Bare URL used

648: null
Bare URL used

649: null
Bare URL used

650: null
Bare URL used

651: null
Bare URL used

698: null
Bare URL used

739: null
Bare URL used

792: null
Bare URL used

905: null
Bare URL used

947: null
Spaces inside emphasis markers

947: null
Spaces inside emphasis markers

343: null
Spaces inside code span elements

CHANGELOG.md Show resolved Hide resolved
@Taztingo Taztingo enabled auto-merge (squash) May 23, 2024 16:25
coderabbitai[bot]
coderabbitai bot reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (5)
CHANGELOG.md (5)

Line range hint 110-357: The list items in the CHANGELOG should consistently use asterisks (*) instead of dashes (-) for unordered lists to maintain consistency and adhere to Markdown linting rules.

- - Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))
+ * Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))

Line range hint 820-820: Multiple consecutive blank lines detected. Consider reducing to a single blank line to improve readability and adhere to best practices.

- 
- 
+

Line range hint 231-231: Bare URLs are used in the document. Consider using Markdown link syntax to improve readability and presentation.

- https://github.com/provenance-io/provenance/pull/1910
+ [PR #1910](https://github.com/provenance-io/provenance/pull/1910)

Also applies to: 262-262, 361-361, 411-411, 423-423, 439-439, 510-510, 521-521, 529-529, 565-565, 590-590, 602-602, 648-648, 649-649, 650-650, 651-651, 652-652, 699-699, 740-740, 793-793, 906-906

Line range hint 948-948: Spaces detected inside emphasis markers. Consider removing them to adhere to Markdown syntax rules.

- * message *PR<pull-request-number>*
+ * message* PR<pull-request-number>*

Line range hint 344-344: Spaces detected inside code span elements. Consider removing them to adhere to Markdown syntax rules.

- ` provenanced query account `
+ `provenanced query account`
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c579090 and b6bf101.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional Context Used
Markdownlint (108)
CHANGELOG.md (108)

110: Expected: asterisk; Actual: dash
Unordered list style

111: Expected: asterisk; Actual: dash
Unordered list style

112: Expected: asterisk; Actual: dash
Unordered list style

113: Expected: asterisk; Actual: dash
Unordered list style

114: Expected: asterisk; Actual: dash
Unordered list style

115: Expected: asterisk; Actual: dash
Unordered list style

116: Expected: asterisk; Actual: dash
Unordered list style

117: Expected: asterisk; Actual: dash
Unordered list style

118: Expected: asterisk; Actual: dash
Unordered list style

119: Expected: asterisk; Actual: dash
Unordered list style

120: Expected: asterisk; Actual: dash
Unordered list style

121: Expected: asterisk; Actual: dash
Unordered list style

122: Expected: asterisk; Actual: dash
Unordered list style

123: Expected: asterisk; Actual: dash
Unordered list style

124: Expected: asterisk; Actual: dash
Unordered list style

125: Expected: asterisk; Actual: dash
Unordered list style

126: Expected: asterisk; Actual: dash
Unordered list style

196: Expected: asterisk; Actual: dash
Unordered list style

197: Expected: asterisk; Actual: dash
Unordered list style

198: Expected: asterisk; Actual: dash
Unordered list style

199: Expected: asterisk; Actual: dash
Unordered list style

200: Expected: asterisk; Actual: dash
Unordered list style

201: Expected: asterisk; Actual: dash
Unordered list style

202: Expected: asterisk; Actual: dash
Unordered list style

203: Expected: asterisk; Actual: dash
Unordered list style

204: Expected: asterisk; Actual: dash
Unordered list style

205: Expected: asterisk; Actual: dash
Unordered list style

206: Expected: asterisk; Actual: dash
Unordered list style

207: Expected: asterisk; Actual: dash
Unordered list style

208: Expected: asterisk; Actual: dash
Unordered list style

209: Expected: asterisk; Actual: dash
Unordered list style

210: Expected: asterisk; Actual: dash
Unordered list style

211: Expected: asterisk; Actual: dash
Unordered list style

212: Expected: asterisk; Actual: dash
Unordered list style

213: Expected: asterisk; Actual: dash
Unordered list style

214: Expected: asterisk; Actual: dash
Unordered list style

215: Expected: asterisk; Actual: dash
Unordered list style

216: Expected: asterisk; Actual: dash
Unordered list style

217: Expected: asterisk; Actual: dash
Unordered list style

218: Expected: asterisk; Actual: dash
Unordered list style

219: Expected: asterisk; Actual: dash
Unordered list style

220: Expected: asterisk; Actual: dash
Unordered list style

221: Expected: asterisk; Actual: dash
Unordered list style

222: Expected: asterisk; Actual: dash
Unordered list style

223: Expected: asterisk; Actual: dash
Unordered list style

224: Expected: asterisk; Actual: dash
Unordered list style

225: Expected: asterisk; Actual: dash
Unordered list style

226: Expected: asterisk; Actual: dash
Unordered list style

227: Expected: asterisk; Actual: dash
Unordered list style

256: Expected: asterisk; Actual: dash
Unordered list style

257: Expected: asterisk; Actual: dash
Unordered list style

258: Expected: asterisk; Actual: dash
Unordered list style

335: Expected: asterisk; Actual: dash
Unordered list style

336: Expected: asterisk; Actual: dash
Unordered list style

337: Expected: asterisk; Actual: dash
Unordered list style

338: Expected: asterisk; Actual: dash
Unordered list style

339: Expected: asterisk; Actual: dash
Unordered list style

340: Expected: asterisk; Actual: dash
Unordered list style

341: Expected: asterisk; Actual: dash
Unordered list style

342: Expected: asterisk; Actual: dash
Unordered list style

343: Expected: asterisk; Actual: dash
Unordered list style

344: Expected: asterisk; Actual: dash
Unordered list style

345: Expected: asterisk; Actual: dash
Unordered list style

346: Expected: asterisk; Actual: dash
Unordered list style

347: Expected: asterisk; Actual: dash
Unordered list style

348: Expected: asterisk; Actual: dash
Unordered list style

349: Expected: asterisk; Actual: dash
Unordered list style

350: Expected: asterisk; Actual: dash
Unordered list style

351: Expected: asterisk; Actual: dash
Unordered list style

352: Expected: asterisk; Actual: dash
Unordered list style

353: Expected: asterisk; Actual: dash
Unordered list style

354: Expected: asterisk; Actual: dash
Unordered list style

355: Expected: asterisk; Actual: dash
Unordered list style

356: Expected: asterisk; Actual: dash
Unordered list style

357: Expected: asterisk; Actual: dash
Unordered list style

713: Expected: asterisk; Actual: dash
Unordered list style

721: Expected: asterisk; Actual: dash
Unordered list style

766: Expected: asterisk; Actual: dash
Unordered list style

774: Expected: asterisk; Actual: dash
Unordered list style

820: Expected: 1; Actual: 2
Multiple consecutive blank lines

1221: Expected: 1; Actual: 2
Multiple consecutive blank lines

1238: Expected: 1; Actual: 2
Multiple consecutive blank lines

1290: Expected: 1; Actual: 2
Multiple consecutive blank lines

1394: Expected: 1; Actual: 2
Multiple consecutive blank lines

231: null
Bare URL used

262: null
Bare URL used

361: null
Bare URL used

411: null
Bare URL used

423: null
Bare URL used

439: null
Bare URL used

510: null
Bare URL used

521: null
Bare URL used

529: null
Bare URL used

565: null
Bare URL used

590: null
Bare URL used

602: null
Bare URL used

648: null
Bare URL used

649: null
Bare URL used

650: null
Bare URL used

651: null
Bare URL used

652: null
Bare URL used

699: null
Bare URL used

740: null
Bare URL used

793: null
Bare URL used

906: null
Bare URL used

948: null
Spaces inside emphasis markers

948: null
Spaces inside emphasis markers

344: null
Spaces inside code span elements

Additional comments not posted (6)
CHANGELOG.md (6)

126-126: The list items in the CHANGELOG should consistently use asterisks (*) instead of dashes (-) for unordered lists to maintain consistency and adhere to Markdown linting rules.

Line range hint 196-356: The list items in the CHANGELOG should consistently use asterisks (*) instead of dashes (-) for unordered lists to maintain consistency and adhere to Markdown linting rules.

Line range hint 1221-1221: Multiple consecutive blank lines detected. Consider reducing to a single blank line to improve readability and adhere to best practices.

Line range hint 1238-1238: Multiple consecutive blank lines detected. Consider reducing to a single blank line to improve readability and adhere to best practices.

Line range hint 1290-1290: Multiple consecutive blank lines detected. Consider reducing to a single blank line to improve readability and adhere to best practices.

Line range hint 1394-1394: Multiple consecutive blank lines detected. Consider reducing to a single blank line to improve readability and adhere to best practices.

coderabbitai[bot]
coderabbitai bot reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (5)
CHANGELOG.md (5)

Line range hint 115-362: Consider using a consistent list marker style in Markdown.

- - Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))
+ * Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))

Line range hint 825-825: Consider removing consecutive blank lines for better readability and to conform to Markdown best practices.

-

Also applies to: 1226-1226, 1243-1243, 1295-1295, 1399-1399

Line range hint 236-236: Consider using Markdown links instead of bare URLs for better readability and presentation.

- https://github.com/provenance-io/provenance/pull/1910
+ [PR #1910](https://github.com/provenance-io/provenance/pull/1910)

Also applies to: 267-267, 366-366, 416-416, 428-428, 444-444, 515-515, 526-526, 534-534, 570-570, 595-595, 607-607, 653-653, 654-654, 655-655, 656-656, 657-657, 704-704, 745-745, 798-798, 911-911

Line range hint 953-953: Consider removing spaces inside emphasis markers for correct Markdown formatting.

- * message *PR<pull-request-number>*
+ *message* *PR<pull-request-number>*

Line range hint 349-349: Consider removing spaces inside code span elements for correct Markdown formatting.

- ` message `
+ `message`
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between b6bf101 and d2ad4ac.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional Context Used
Markdownlint (108)
CHANGELOG.md (108)

115: Expected: asterisk; Actual: dash
Unordered list style

116: Expected: asterisk; Actual: dash
Unordered list style

117: Expected: asterisk; Actual: dash
Unordered list style

118: Expected: asterisk; Actual: dash
Unordered list style

119: Expected: asterisk; Actual: dash
Unordered list style

120: Expected: asterisk; Actual: dash
Unordered list style

121: Expected: asterisk; Actual: dash
Unordered list style

122: Expected: asterisk; Actual: dash
Unordered list style

123: Expected: asterisk; Actual: dash
Unordered list style

124: Expected: asterisk; Actual: dash
Unordered list style

125: Expected: asterisk; Actual: dash
Unordered list style

126: Expected: asterisk; Actual: dash
Unordered list style

127: Expected: asterisk; Actual: dash
Unordered list style

128: Expected: asterisk; Actual: dash
Unordered list style

129: Expected: asterisk; Actual: dash
Unordered list style

130: Expected: asterisk; Actual: dash
Unordered list style

131: Expected: asterisk; Actual: dash
Unordered list style

201: Expected: asterisk; Actual: dash
Unordered list style

202: Expected: asterisk; Actual: dash
Unordered list style

203: Expected: asterisk; Actual: dash
Unordered list style

204: Expected: asterisk; Actual: dash
Unordered list style

205: Expected: asterisk; Actual: dash
Unordered list style

206: Expected: asterisk; Actual: dash
Unordered list style

207: Expected: asterisk; Actual: dash
Unordered list style

208: Expected: asterisk; Actual: dash
Unordered list style

209: Expected: asterisk; Actual: dash
Unordered list style

210: Expected: asterisk; Actual: dash
Unordered list style

211: Expected: asterisk; Actual: dash
Unordered list style

212: Expected: asterisk; Actual: dash
Unordered list style

213: Expected: asterisk; Actual: dash
Unordered list style

214: Expected: asterisk; Actual: dash
Unordered list style

215: Expected: asterisk; Actual: dash
Unordered list style

216: Expected: asterisk; Actual: dash
Unordered list style

217: Expected: asterisk; Actual: dash
Unordered list style

218: Expected: asterisk; Actual: dash
Unordered list style

219: Expected: asterisk; Actual: dash
Unordered list style

220: Expected: asterisk; Actual: dash
Unordered list style

221: Expected: asterisk; Actual: dash
Unordered list style

222: Expected: asterisk; Actual: dash
Unordered list style

223: Expected: asterisk; Actual: dash
Unordered list style

224: Expected: asterisk; Actual: dash
Unordered list style

225: Expected: asterisk; Actual: dash
Unordered list style

226: Expected: asterisk; Actual: dash
Unordered list style

227: Expected: asterisk; Actual: dash
Unordered list style

228: Expected: asterisk; Actual: dash
Unordered list style

229: Expected: asterisk; Actual: dash
Unordered list style

230: Expected: asterisk; Actual: dash
Unordered list style

231: Expected: asterisk; Actual: dash
Unordered list style

232: Expected: asterisk; Actual: dash
Unordered list style

261: Expected: asterisk; Actual: dash
Unordered list style

262: Expected: asterisk; Actual: dash
Unordered list style

263: Expected: asterisk; Actual: dash
Unordered list style

340: Expected: asterisk; Actual: dash
Unordered list style

341: Expected: asterisk; Actual: dash
Unordered list style

342: Expected: asterisk; Actual: dash
Unordered list style

343: Expected: asterisk; Actual: dash
Unordered list style

344: Expected: asterisk; Actual: dash
Unordered list style

345: Expected: asterisk; Actual: dash
Unordered list style

346: Expected: asterisk; Actual: dash
Unordered list style

347: Expected: asterisk; Actual: dash
Unordered list style

348: Expected: asterisk; Actual: dash
Unordered list style

349: Expected: asterisk; Actual: dash
Unordered list style

350: Expected: asterisk; Actual: dash
Unordered list style

351: Expected: asterisk; Actual: dash
Unordered list style

352: Expected: asterisk; Actual: dash
Unordered list style

353: Expected: asterisk; Actual: dash
Unordered list style

354: Expected: asterisk; Actual: dash
Unordered list style

355: Expected: asterisk; Actual: dash
Unordered list style

356: Expected: asterisk; Actual: dash
Unordered list style

357: Expected: asterisk; Actual: dash
Unordered list style

358: Expected: asterisk; Actual: dash
Unordered list style

359: Expected: asterisk; Actual: dash
Unordered list style

360: Expected: asterisk; Actual: dash
Unordered list style

361: Expected: asterisk; Actual: dash
Unordered list style

362: Expected: asterisk; Actual: dash
Unordered list style

718: Expected: asterisk; Actual: dash
Unordered list style

726: Expected: asterisk; Actual: dash
Unordered list style

771: Expected: asterisk; Actual: dash
Unordered list style

779: Expected: asterisk; Actual: dash
Unordered list style

825: Expected: 1; Actual: 2
Multiple consecutive blank lines

1226: Expected: 1; Actual: 2
Multiple consecutive blank lines

1243: Expected: 1; Actual: 2
Multiple consecutive blank lines

1295: Expected: 1; Actual: 2
Multiple consecutive blank lines

1399: Expected: 1; Actual: 2
Multiple consecutive blank lines

236: null
Bare URL used

267: null
Bare URL used

366: null
Bare URL used

416: null
Bare URL used

428: null
Bare URL used

444: null
Bare URL used

515: null
Bare URL used

526: null
Bare URL used

534: null
Bare URL used

570: null
Bare URL used

595: null
Bare URL used

607: null
Bare URL used

653: null
Bare URL used

654: null
Bare URL used

655: null
Bare URL used

656: null
Bare URL used

657: null
Bare URL used

704: null
Bare URL used

745: null
Bare URL used

798: null
Bare URL used

911: null
Bare URL used

953: null
Spaces inside emphasis markers

953: null
Spaces inside emphasis markers

349: null
Spaces inside code span elements

coderabbitai[bot]
coderabbitai bot reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (5)
CHANGELOG.md (5)

Line range hint 116-361: Consider using a consistent list style in Markdown. The asterisk (*) is commonly used for unordered lists instead of the dash (-).

- - Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))
+ * Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.1 ([#1910](https://github.com/provenance-io/provenance/pull/1910), [#1956](https://github.com/provenance-io/provenance/pull/1956))

Also applies to: 719-719, 727-727, 772-772, 780-780

Line range hint 826-826: Multiple consecutive blank lines found. It's a good practice to limit to one blank line for better readability and to adhere to Markdown linting rules.

-

Also applies to: 1227-1227, 1244-1244, 1296-1296, 1400-1400

Line range hint 237-237: Consider using Markdown links instead of bare URLs to improve the readability and presentation of the document.

- https://github.com/provenance-io/provenance/pull/1910
+ [PR #1910](https://github.com/provenance-io/provenance/pull/1910)

Also applies to: 268-268, 367-367, 417-417, 429-429, 445-445, 516-516, 527-527, 535-535, 571-571, 596-596, 608-608, 654-654, 655-655, 656-656, 657-657, 658-658, 705-705, 746-746, 799-799, 912-912

Line range hint 954-954: Remove spaces inside emphasis markers to correct the Markdown formatting.

- * message *PR<pull-request-number>*
+ *message PR<pull-request-number>*

Line range hint 350-350: Remove spaces inside code span elements to correct the Markdown formatting.

- ` code `
+ `code`
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d2ad4ac and ece8ad9.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional Context Used
Markdownlint (108)
CHANGELOG.md (108)

116: Expected: asterisk; Actual: dash
Unordered list style

117: Expected: asterisk; Actual: dash
Unordered list style

118: Expected: asterisk; Actual: dash
Unordered list style

119: Expected: asterisk; Actual: dash
Unordered list style

120: Expected: asterisk; Actual: dash
Unordered list style

121: Expected: asterisk; Actual: dash
Unordered list style

122: Expected: asterisk; Actual: dash
Unordered list style

123: Expected: asterisk; Actual: dash
Unordered list style

124: Expected: asterisk; Actual: dash
Unordered list style

125: Expected: asterisk; Actual: dash
Unordered list style

126: Expected: asterisk; Actual: dash
Unordered list style

127: Expected: asterisk; Actual: dash
Unordered list style

128: Expected: asterisk; Actual: dash
Unordered list style

129: Expected: asterisk; Actual: dash
Unordered list style

130: Expected: asterisk; Actual: dash
Unordered list style

131: Expected: asterisk; Actual: dash
Unordered list style

132: Expected: asterisk; Actual: dash
Unordered list style

202: Expected: asterisk; Actual: dash
Unordered list style

203: Expected: asterisk; Actual: dash
Unordered list style

204: Expected: asterisk; Actual: dash
Unordered list style

205: Expected: asterisk; Actual: dash
Unordered list style

206: Expected: asterisk; Actual: dash
Unordered list style

207: Expected: asterisk; Actual: dash
Unordered list style

208: Expected: asterisk; Actual: dash
Unordered list style

209: Expected: asterisk; Actual: dash
Unordered list style

210: Expected: asterisk; Actual: dash
Unordered list style

211: Expected: asterisk; Actual: dash
Unordered list style

212: Expected: asterisk; Actual: dash
Unordered list style

213: Expected: asterisk; Actual: dash
Unordered list style

214: Expected: asterisk; Actual: dash
Unordered list style

215: Expected: asterisk; Actual: dash
Unordered list style

216: Expected: asterisk; Actual: dash
Unordered list style

217: Expected: asterisk; Actual: dash
Unordered list style

218: Expected: asterisk; Actual: dash
Unordered list style

219: Expected: asterisk; Actual: dash
Unordered list style

220: Expected: asterisk; Actual: dash
Unordered list style

221: Expected: asterisk; Actual: dash
Unordered list style

222: Expected: asterisk; Actual: dash
Unordered list style

223: Expected: asterisk; Actual: dash
Unordered list style

224: Expected: asterisk; Actual: dash
Unordered list style

225: Expected: asterisk; Actual: dash
Unordered list style

226: Expected: asterisk; Actual: dash
Unordered list style

227: Expected: asterisk; Actual: dash
Unordered list style

228: Expected: asterisk; Actual: dash
Unordered list style

229: Expected: asterisk; Actual: dash
Unordered list style

230: Expected: asterisk; Actual: dash
Unordered list style

231: Expected: asterisk; Actual: dash
Unordered list style

232: Expected: asterisk; Actual: dash
Unordered list style

233: Expected: asterisk; Actual: dash
Unordered list style

262: Expected: asterisk; Actual: dash
Unordered list style

263: Expected: asterisk; Actual: dash
Unordered list style

264: Expected: asterisk; Actual: dash
Unordered list style

341: Expected: asterisk; Actual: dash
Unordered list style

342: Expected: asterisk; Actual: dash
Unordered list style

343: Expected: asterisk; Actual: dash
Unordered list style

344: Expected: asterisk; Actual: dash
Unordered list style

345: Expected: asterisk; Actual: dash
Unordered list style

346: Expected: asterisk; Actual: dash
Unordered list style

347: Expected: asterisk; Actual: dash
Unordered list style

348: Expected: asterisk; Actual: dash
Unordered list style

349: Expected: asterisk; Actual: dash
Unordered list style

350: Expected: asterisk; Actual: dash
Unordered list style

351: Expected: asterisk; Actual: dash
Unordered list style

352: Expected: asterisk; Actual: dash
Unordered list style

353: Expected: asterisk; Actual: dash
Unordered list style

354: Expected: asterisk; Actual: dash
Unordered list style

355: Expected: asterisk; Actual: dash
Unordered list style

356: Expected: asterisk; Actual: dash
Unordered list style

357: Expected: asterisk; Actual: dash
Unordered list style

358: Expected: asterisk; Actual: dash
Unordered list style

359: Expected: asterisk; Actual: dash
Unordered list style

360: Expected: asterisk; Actual: dash
Unordered list style

361: Expected: asterisk; Actual: dash
Unordered list style

362: Expected: asterisk; Actual: dash
Unordered list style

363: Expected: asterisk; Actual: dash
Unordered list style

719: Expected: asterisk; Actual: dash
Unordered list style

727: Expected: asterisk; Actual: dash
Unordered list style

772: Expected: asterisk; Actual: dash
Unordered list style

780: Expected: asterisk; Actual: dash
Unordered list style

826: Expected: 1; Actual: 2
Multiple consecutive blank lines

1227: Expected: 1; Actual: 2
Multiple consecutive blank lines

1244: Expected: 1; Actual: 2
Multiple consecutive blank lines

1296: Expected: 1; Actual: 2
Multiple consecutive blank lines

1400: Expected: 1; Actual: 2
Multiple consecutive blank lines

237: null
Bare URL used

268: null
Bare URL used

367: null
Bare URL used

417: null
Bare URL used

429: null
Bare URL used

445: null
Bare URL used

516: null
Bare URL used

527: null
Bare URL used

535: null
Bare URL used

571: null
Bare URL used

596: null
Bare URL used

608: null
Bare URL used

654: null
Bare URL used

655: null
Bare URL used

656: null
Bare URL used

657: null
Bare URL used

658: null
Bare URL used

705: null
Bare URL used

746: null
Bare URL used

799: null
Bare URL used

912: null
Bare URL used

954: null
Spaces inside emphasis markers

954: null
Spaces inside emphasis markers

350: null
Spaces inside code span elements

@Taztingo Taztingo merged commit 4dc474e into main May 24, 2024
29 of 36 checks passed
@Taztingo Taztingo deleted the taztingo/update-ica-proposal-sims branch May 24, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@nullpointer0x00 nullpointer0x00 nullpointer0x00 approved these changes

@iramiller iramiller iramiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICA simtests require an application to have both the controller and host modules.
3 participants
@Taztingo @iramiller @nullpointer0x00