Add update params to marker module
#1991
Conversation
WalkthroughThe recent update introduces a new Changes
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range and nitpick comments (6)
x/marker/types/events.go (1)
187-194: Consider using direct string methods forsdkmath.Intand boolean types if available, instead ofstrconv, for consistency and performance.CHANGELOG.md (5)
Line range hint
111-357: Consider using a consistent list marker style in Markdown.- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).Also applies to: 713-713, 721-721, 766-766, 774-774
Line range hint
820-820: Remove extra blank lines to maintain consistency in document formatting.-Also applies to: 1221-1221, 1238-1238, 1290-1290, 1394-1394
Line range hint
231-231: Consider using Markdown links instead of bare URLs for better readability and navigation.- https://github.com/provenance-io/provenance/pull/1971 + [PR 1971](https://github.com/provenance-io/provenance/pull/1971)Also applies to: 262-262, 361-361, 411-411, 423-423, 439-439, 510-510, 521-521, 529-529, 565-565, 590-590, 602-602, 648-648, 649-649, 650-650, 651-651, 652-652, 699-699, 740-740, 793-793, 906-906
Line range hint
948-948: Remove unnecessary spaces inside emphasis markers.- * `ibcratelimit` add `UpdateParams` endpoint and deprecate `GovUpdateParams` [#1984](https://github.com/provenance-io/provenance/pull/1984). + * `ibcratelimit` add `UpdateParams` endpoint and deprecate `GovUpdateParams` [#1984](https://github.com/provenance-io/provenance/pull/1984).
Line range hint
344-344: Remove unnecessary spaces inside code span elements.- ` MsgUpdateParamsRequest ` + `MsgUpdateParamsRequest`
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
x/ibcratelimit/tx.pb.gois excluded by!**/*.pb.gox/marker/types/marker.pb.gois excluded by!**/*.pb.gox/marker/types/tx.pb.gois excluded by!**/*.pb.go
Files selected for processing (18)
- CHANGELOG.md (1 hunks)
- client/docs/swagger-ui/swagger.yaml (1 hunks)
- proto/provenance/ibcratelimit/v1/tx.proto (1 hunks)
- proto/provenance/marker/v1/marker.proto (1 hunks)
- proto/provenance/marker/v1/tx.proto (2 hunks)
- x/marker/client/cli/cli_test.go (1 hunks)
- x/marker/client/cli/tx.go (3 hunks)
- x/marker/keeper/keeper.go (2 hunks)
- x/marker/keeper/marker.go (1 hunks)
- x/marker/keeper/msg_server.go (1 hunks)
- x/marker/keeper/msg_server_test.go (1 hunks)
- x/marker/keeper/params.go (1 hunks)
- x/marker/keeper/params_test.go (1 hunks)
- x/marker/types/events.go (2 hunks)
- x/marker/types/msgs.go (2 hunks)
- x/marker/types/msgs_test.go (2 hunks)
- x/marker/types/params.go (5 hunks)
- x/marker/types/params_test.go (3 hunks)
Files skipped from review due to trivial changes (4)
- client/docs/swagger-ui/swagger.yaml
- proto/provenance/ibcratelimit/v1/tx.proto
- proto/provenance/marker/v1/marker.proto
- x/marker/keeper/params.go
Additional Context Used
Markdownlint (107)
CHANGELOG.md (107)
111: Expected: asterisk; Actual: dash
Unordered list style
112: Expected: asterisk; Actual: dash
Unordered list style
113: Expected: asterisk; Actual: dash
Unordered list style
114: Expected: asterisk; Actual: dash
Unordered list style
115: Expected: asterisk; Actual: dash
Unordered list style
116: Expected: asterisk; Actual: dash
Unordered list style
117: Expected: asterisk; Actual: dash
Unordered list style
118: Expected: asterisk; Actual: dash
Unordered list style
119: Expected: asterisk; Actual: dash
Unordered list style
120: Expected: asterisk; Actual: dash
Unordered list style
121: Expected: asterisk; Actual: dash
Unordered list style
122: Expected: asterisk; Actual: dash
Unordered list style
123: Expected: asterisk; Actual: dash
Unordered list style
124: Expected: asterisk; Actual: dash
Unordered list style
125: Expected: asterisk; Actual: dash
Unordered list style
126: Expected: asterisk; Actual: dash
Unordered list style
196: Expected: asterisk; Actual: dash
Unordered list style
197: Expected: asterisk; Actual: dash
Unordered list style
198: Expected: asterisk; Actual: dash
Unordered list style
199: Expected: asterisk; Actual: dash
Unordered list style
200: Expected: asterisk; Actual: dash
Unordered list style
201: Expected: asterisk; Actual: dash
Unordered list style
202: Expected: asterisk; Actual: dash
Unordered list style
203: Expected: asterisk; Actual: dash
Unordered list style
204: Expected: asterisk; Actual: dash
Unordered list style
205: Expected: asterisk; Actual: dash
Unordered list style
206: Expected: asterisk; Actual: dash
Unordered list style
207: Expected: asterisk; Actual: dash
Unordered list style
208: Expected: asterisk; Actual: dash
Unordered list style
209: Expected: asterisk; Actual: dash
Unordered list style
210: Expected: asterisk; Actual: dash
Unordered list style
211: Expected: asterisk; Actual: dash
Unordered list style
212: Expected: asterisk; Actual: dash
Unordered list style
213: Expected: asterisk; Actual: dash
Unordered list style
214: Expected: asterisk; Actual: dash
Unordered list style
215: Expected: asterisk; Actual: dash
Unordered list style
216: Expected: asterisk; Actual: dash
Unordered list style
217: Expected: asterisk; Actual: dash
Unordered list style
218: Expected: asterisk; Actual: dash
Unordered list style
219: Expected: asterisk; Actual: dash
Unordered list style
220: Expected: asterisk; Actual: dash
Unordered list style
221: Expected: asterisk; Actual: dash
Unordered list style
222: Expected: asterisk; Actual: dash
Unordered list style
223: Expected: asterisk; Actual: dash
Unordered list style
224: Expected: asterisk; Actual: dash
Unordered list style
225: Expected: asterisk; Actual: dash
Unordered list style
226: Expected: asterisk; Actual: dash
Unordered list style
227: Expected: asterisk; Actual: dash
Unordered list style
256: Expected: asterisk; Actual: dash
Unordered list style
257: Expected: asterisk; Actual: dash
Unordered list style
258: Expected: asterisk; Actual: dash
Unordered list style
335: Expected: asterisk; Actual: dash
Unordered list style
336: Expected: asterisk; Actual: dash
Unordered list style
337: Expected: asterisk; Actual: dash
Unordered list style
338: Expected: asterisk; Actual: dash
Unordered list style
339: Expected: asterisk; Actual: dash
Unordered list style
340: Expected: asterisk; Actual: dash
Unordered list style
341: Expected: asterisk; Actual: dash
Unordered list style
342: Expected: asterisk; Actual: dash
Unordered list style
343: Expected: asterisk; Actual: dash
Unordered list style
344: Expected: asterisk; Actual: dash
Unordered list style
345: Expected: asterisk; Actual: dash
Unordered list style
346: Expected: asterisk; Actual: dash
Unordered list style
347: Expected: asterisk; Actual: dash
Unordered list style
348: Expected: asterisk; Actual: dash
Unordered list style
349: Expected: asterisk; Actual: dash
Unordered list style
350: Expected: asterisk; Actual: dash
Unordered list style
351: Expected: asterisk; Actual: dash
Unordered list style
352: Expected: asterisk; Actual: dash
Unordered list style
353: Expected: asterisk; Actual: dash
Unordered list style
354: Expected: asterisk; Actual: dash
Unordered list style
355: Expected: asterisk; Actual: dash
Unordered list style
356: Expected: asterisk; Actual: dash
Unordered list style
357: Expected: asterisk; Actual: dash
Unordered list style
713: Expected: asterisk; Actual: dash
Unordered list style
721: Expected: asterisk; Actual: dash
Unordered list style
766: Expected: asterisk; Actual: dash
Unordered list style
774: Expected: asterisk; Actual: dash
Unordered list style
820: Expected: 1; Actual: 2
Multiple consecutive blank lines
1221: Expected: 1; Actual: 2
Multiple consecutive blank lines
1238: Expected: 1; Actual: 2
Multiple consecutive blank lines
1290: Expected: 1; Actual: 2
Multiple consecutive blank lines
1394: Expected: 1; Actual: 2
Multiple consecutive blank lines
231: null
Bare URL used
262: null
Bare URL used
361: null
Bare URL used
411: null
Bare URL used
423: null
Bare URL used
439: null
Bare URL used
510: null
Bare URL used
521: null
Bare URL used
529: null
Bare URL used
565: null
Bare URL used
590: null
Bare URL used
602: null
Bare URL used
648: null
Bare URL used
649: null
Bare URL used
650: null
Bare URL used
651: null
Bare URL used
652: null
Bare URL used
699: null
Bare URL used
740: null
Bare URL used
793: null
Bare URL used
906: null
Bare URL used
948: null
Spaces inside emphasis markers
948: null
Spaces inside emphasis markers
344: null
Spaces inside code span elements
Additional comments not posted (14)
x/marker/types/params.go (1)
82-82: These validation functions are marked for removal in a future version. Ensure there is a tracking issue for this task to avoid overlooking it.Also applies to: 92-92, 102-102
x/marker/types/params_test.go (1)
103-157: The parameter validation tests are comprehensive and cover a variety of scenarios, including edge cases for regex patterns. Good job ensuring robust testing.x/marker/keeper/keeper.go (1)
207-218: The implementation of authority validation usingstrings.EqualFoldis appropriate for case-insensitive comparison. Ensure that the authority address is correctly set and used throughout the module.x/marker/types/msgs.go (2)
48-48: Addition ofMsgUpdateParamsRequesttoAllRequestMsgsis correctly implemented.
727-749: The implementation ofNewMsgUpdateParamsRequestand its validation logic inValidateBasicare correctly done. Ensure thatParams.Validate()is implemented appropriately to handle the new parameters.Verification successful
The
Params.Validatemethod inx/marker/types/params.gocorrectly validates theUnrestrictedDenomRegex,EnableGovernance, andMaxSupplyparameters using appropriate validation functions. ThevalidateRegexParam,validateEnableGovernance, andvalidateBigIntParamfunctions are implemented correctly to ensure the parameters are of the expected types and formats.
validateRegexParamchecks that the regex does not contain anchors and can be compiled.validateEnableGovernanceensures the parameter is a boolean.validateBigIntParamensures the parameter is of typesdkmath.Int.No issues were found with the validation logic.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the implementation of Params.Validate() method. # Test: Search for the Params.Validate() method implementation. Expect: Proper validation logic for new parameters. rg --type go $'func \(p Params\) Validate\(\)'Length of output: 285
Script:
#!/bin/bash # Extract and display the implementation of Params.Validate method in x/marker/types/params.go ast-grep --lang go --pattern $'func (p Params) Validate() error' x/marker/types/params.goLength of output: 393
Script:
#!/bin/bash # Extract and display the implementation of validateRegexParam function in x/marker/types/params.go ast-grep --lang go --pattern $'func validateRegexParam($_) error' x/marker/types/params.go # Check for validation of other parameters in Params.Validate method rg --type go 'validate' x/marker/types/params.goLength of output: 1467
Script:
#!/bin/bash # Extract and display the implementation of validateEnableGovernance function in x/marker/types/params.go ast-grep --lang go --pattern $'func validateEnableGovernance($_) error' x/marker/types/params.go # Extract and display the implementation of validateBigIntParam function in x/marker/types/params.go ast-grep --lang go --pattern $'func validateBigIntParam($_) error' x/marker/types/params.goLength of output: 925
proto/provenance/marker/v1/tx.proto (2)
79-80: The addition of theUpdateParamsmethod in theMsgservice is correctly implemented and follows the protobuf conventions.
467-479: The new message typesMsgUpdateParamsRequestandMsgUpdateParamsResponseare well-defined and align with the intended functionality of updating marker module parameters.x/marker/keeper/msg_server.go (1)
824-838: The implementation of theUpdateParamsfunction in the marker module's message server is correct. It properly handles authority validation, parameter updating, and event emission.x/marker/keeper/marker.go (1)
349-349: Change to usek.GetMaxSupply(ctx)improves maintainability by consolidating parameter management.Verification successful
The reference to
GetParams(ctx).MaxSupplystill exists within theGetMaxSupplyfunction itself, which means the change to useGetMaxSupply(ctx)is correctly implemented. However, theGetMaxSupplyfunction internally still relies onGetParams(ctx).MaxSupply.
x/marker/keeper/params.go:
GetMaxSupplyfunction still usesGetParams(ctx).MaxSupply.This indicates that the change to use
GetMaxSupply(ctx)is consistent with the intended refactor, but the underlying parameter retrieval hasn't been altered.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all references to `GetParams(ctx).MaxSupply` have been replaced with `GetMaxSupply(ctx)`. # Test: Search for the old function usage. Expect: No occurrences of the old function. rg --type go $'GetParams\(.*\)\.MaxSupply'Length of output: 104
Script:
#!/bin/bash # Description: Locate the exact line and context of `GetParams(ctx).MaxSupply` usage in `x/marker/keeper/params.go`. # Locate the line number and surrounding lines for context. rg --type go --context 5 $'GetParams\(.*\)\.MaxSupply' x/marker/keeper/params.go # Verify the implementation of `GetMaxSupply(ctx)` in the codebase. ast-grep --lang go --pattern $'func GetMaxSupply($_) $_'Length of output: 550
x/marker/types/msgs_test.go (2)
54-54: LGTM! Good to seeMsgUpdateParamsRequestincluded in theGetSignerstests.
1223-1285: LGTM! Comprehensive testing ofMsgUpdateParamsRequest.ValidateBasiccovering various scenarios.x/marker/client/cli/tx.go (2)
14-14: Import addition ofsdkmathis appropriate for handling mathematical operations on the newmax-supplyparameter.
1557-1601: The implementation ofNewUpdateMarkerParamsCmdis correct and well-structured. It properly handles argument parsing and transaction generation for the governance proposal.x/marker/keeper/msg_server_test.go (1)
1849-1895: The test cases forUpdateParamsare well-structured and cover both successful and failure scenarios effectively.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- x/marker/client/cli/cli_test.go (1 hunks)
- x/marker/client/cli/tx.go (3 hunks)
- x/marker/keeper/params_test.go (2 hunks)
Files skipped from review as they are similar to previous changes (3)
- x/marker/client/cli/cli_test.go
- x/marker/client/cli/tx.go
- x/marker/keeper/params_test.go
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
CHANGELOG.md (5)
Line range hint
115-361: Consider using a consistent list marker style in Markdown.- * message #<issue-number> + - message #<issue-number>
Line range hint
824-824: Remove consecutive blank lines to maintain a clean and consistent format in the document.-Also applies to: 1225-1225, 1242-1242, 1294-1294, 1398-1398
Line range hint
235-235: Consider using Markdown links instead of bare URLs to improve the readability and presentation of the document.- https://github.com/provenance-io/provenance/issues/123 + [Issue #123](https://github.com/provenance-io/provenance/issues/123)Also applies to: 266-266, 365-365, 415-415, 427-427, 443-443, 514-514, 525-525, 533-533, 569-569, 594-594, 606-606, 652-652, 653-653, 654-654, 655-655, 656-656, 703-703, 744-744, 797-797, 910-910
Line range hint
952-952: Remove unnecessary spaces inside emphasis markers to correct Markdown formatting.- * this is a test * + *this is a test*
Line range hint
348-348: Remove unnecessary spaces inside code span elements to correct Markdown formatting.- ` code ` + `code`
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- x/marker/client/cli/tx.go (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- x/marker/client/cli/tx.go
Additional Context Used
Markdownlint (107)
CHANGELOG.md (107)
115: Expected: asterisk; Actual: dash
Unordered list style
116: Expected: asterisk; Actual: dash
Unordered list style
117: Expected: asterisk; Actual: dash
Unordered list style
118: Expected: asterisk; Actual: dash
Unordered list style
119: Expected: asterisk; Actual: dash
Unordered list style
120: Expected: asterisk; Actual: dash
Unordered list style
121: Expected: asterisk; Actual: dash
Unordered list style
122: Expected: asterisk; Actual: dash
Unordered list style
123: Expected: asterisk; Actual: dash
Unordered list style
124: Expected: asterisk; Actual: dash
Unordered list style
125: Expected: asterisk; Actual: dash
Unordered list style
126: Expected: asterisk; Actual: dash
Unordered list style
127: Expected: asterisk; Actual: dash
Unordered list style
128: Expected: asterisk; Actual: dash
Unordered list style
129: Expected: asterisk; Actual: dash
Unordered list style
130: Expected: asterisk; Actual: dash
Unordered list style
200: Expected: asterisk; Actual: dash
Unordered list style
201: Expected: asterisk; Actual: dash
Unordered list style
202: Expected: asterisk; Actual: dash
Unordered list style
203: Expected: asterisk; Actual: dash
Unordered list style
204: Expected: asterisk; Actual: dash
Unordered list style
205: Expected: asterisk; Actual: dash
Unordered list style
206: Expected: asterisk; Actual: dash
Unordered list style
207: Expected: asterisk; Actual: dash
Unordered list style
208: Expected: asterisk; Actual: dash
Unordered list style
209: Expected: asterisk; Actual: dash
Unordered list style
210: Expected: asterisk; Actual: dash
Unordered list style
211: Expected: asterisk; Actual: dash
Unordered list style
212: Expected: asterisk; Actual: dash
Unordered list style
213: Expected: asterisk; Actual: dash
Unordered list style
214: Expected: asterisk; Actual: dash
Unordered list style
215: Expected: asterisk; Actual: dash
Unordered list style
216: Expected: asterisk; Actual: dash
Unordered list style
217: Expected: asterisk; Actual: dash
Unordered list style
218: Expected: asterisk; Actual: dash
Unordered list style
219: Expected: asterisk; Actual: dash
Unordered list style
220: Expected: asterisk; Actual: dash
Unordered list style
221: Expected: asterisk; Actual: dash
Unordered list style
222: Expected: asterisk; Actual: dash
Unordered list style
223: Expected: asterisk; Actual: dash
Unordered list style
224: Expected: asterisk; Actual: dash
Unordered list style
225: Expected: asterisk; Actual: dash
Unordered list style
226: Expected: asterisk; Actual: dash
Unordered list style
227: Expected: asterisk; Actual: dash
Unordered list style
228: Expected: asterisk; Actual: dash
Unordered list style
229: Expected: asterisk; Actual: dash
Unordered list style
230: Expected: asterisk; Actual: dash
Unordered list style
231: Expected: asterisk; Actual: dash
Unordered list style
260: Expected: asterisk; Actual: dash
Unordered list style
261: Expected: asterisk; Actual: dash
Unordered list style
262: Expected: asterisk; Actual: dash
Unordered list style
339: Expected: asterisk; Actual: dash
Unordered list style
340: Expected: asterisk; Actual: dash
Unordered list style
341: Expected: asterisk; Actual: dash
Unordered list style
342: Expected: asterisk; Actual: dash
Unordered list style
343: Expected: asterisk; Actual: dash
Unordered list style
344: Expected: asterisk; Actual: dash
Unordered list style
345: Expected: asterisk; Actual: dash
Unordered list style
346: Expected: asterisk; Actual: dash
Unordered list style
347: Expected: asterisk; Actual: dash
Unordered list style
348: Expected: asterisk; Actual: dash
Unordered list style
349: Expected: asterisk; Actual: dash
Unordered list style
350: Expected: asterisk; Actual: dash
Unordered list style
351: Expected: asterisk; Actual: dash
Unordered list style
352: Expected: asterisk; Actual: dash
Unordered list style
353: Expected: asterisk; Actual: dash
Unordered list style
354: Expected: asterisk; Actual: dash
Unordered list style
355: Expected: asterisk; Actual: dash
Unordered list style
356: Expected: asterisk; Actual: dash
Unordered list style
357: Expected: asterisk; Actual: dash
Unordered list style
358: Expected: asterisk; Actual: dash
Unordered list style
359: Expected: asterisk; Actual: dash
Unordered list style
360: Expected: asterisk; Actual: dash
Unordered list style
361: Expected: asterisk; Actual: dash
Unordered list style
717: Expected: asterisk; Actual: dash
Unordered list style
725: Expected: asterisk; Actual: dash
Unordered list style
770: Expected: asterisk; Actual: dash
Unordered list style
778: Expected: asterisk; Actual: dash
Unordered list style
824: Expected: 1; Actual: 2
Multiple consecutive blank lines
1225: Expected: 1; Actual: 2
Multiple consecutive blank lines
1242: Expected: 1; Actual: 2
Multiple consecutive blank lines
1294: Expected: 1; Actual: 2
Multiple consecutive blank lines
1398: Expected: 1; Actual: 2
Multiple consecutive blank lines
235: null
Bare URL used
266: null
Bare URL used
365: null
Bare URL used
415: null
Bare URL used
427: null
Bare URL used
443: null
Bare URL used
514: null
Bare URL used
525: null
Bare URL used
533: null
Bare URL used
569: null
Bare URL used
594: null
Bare URL used
606: null
Bare URL used
652: null
Bare URL used
653: null
Bare URL used
654: null
Bare URL used
655: null
Bare URL used
656: null
Bare URL used
703: null
Bare URL used
744: null
Bare URL used
797: null
Bare URL used
910: null
Bare URL used
952: null
Spaces inside emphasis markers
952: null
Spaces inside emphasis markers
348: null
Spaces inside code span elements
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
CHANGELOG.md (5)
Line range hint
116-362: Consider using a consistent list marker style in Markdown. The asterisk (*) is commonly used for unordered lists instead of the dash (-).- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).Also applies to: 718-718, 726-726, 771-771, 779-779
Line range hint
236-236: Consider using Markdown links instead of bare URLs to improve the readability and presentation of the document.- https://github.com/provenance-io/provenance/issues/1772 + [Issue #1772](https://github.com/provenance-io/provenance/issues/1772)Also applies to: 267-267, 366-366, 416-416, 428-428, 444-444, 515-515, 526-526, 534-534, 570-570, 595-595, 607-607, 653-657, 704-704, 745-745, 798-798, 911-911
Line range hint
953-953: Remove unnecessary spaces inside emphasis markers to maintain Markdown formatting consistency.- * message *PR<pull-request-number>* + *message PR<pull-request-number>*
Line range hint
349-349: Ensure there are no spaces inside code span elements to maintain proper Markdown syntax.- ` MsgUpdateParamsRequest ` + `MsgUpdateParamsRequest`
Line range hint
825-825: Remove consecutive blank lines to maintain a clean and professional appearance in the document.- - +Also applies to: 1226-1226, 1243-1243, 1295-1295, 1399-1399
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional Context Used
Markdownlint (107)
CHANGELOG.md (107)
116: Expected: asterisk; Actual: dash
Unordered list style
117: Expected: asterisk; Actual: dash
Unordered list style
118: Expected: asterisk; Actual: dash
Unordered list style
119: Expected: asterisk; Actual: dash
Unordered list style
120: Expected: asterisk; Actual: dash
Unordered list style
121: Expected: asterisk; Actual: dash
Unordered list style
122: Expected: asterisk; Actual: dash
Unordered list style
123: Expected: asterisk; Actual: dash
Unordered list style
124: Expected: asterisk; Actual: dash
Unordered list style
125: Expected: asterisk; Actual: dash
Unordered list style
126: Expected: asterisk; Actual: dash
Unordered list style
127: Expected: asterisk; Actual: dash
Unordered list style
128: Expected: asterisk; Actual: dash
Unordered list style
129: Expected: asterisk; Actual: dash
Unordered list style
130: Expected: asterisk; Actual: dash
Unordered list style
131: Expected: asterisk; Actual: dash
Unordered list style
201: Expected: asterisk; Actual: dash
Unordered list style
202: Expected: asterisk; Actual: dash
Unordered list style
203: Expected: asterisk; Actual: dash
Unordered list style
204: Expected: asterisk; Actual: dash
Unordered list style
205: Expected: asterisk; Actual: dash
Unordered list style
206: Expected: asterisk; Actual: dash
Unordered list style
207: Expected: asterisk; Actual: dash
Unordered list style
208: Expected: asterisk; Actual: dash
Unordered list style
209: Expected: asterisk; Actual: dash
Unordered list style
210: Expected: asterisk; Actual: dash
Unordered list style
211: Expected: asterisk; Actual: dash
Unordered list style
212: Expected: asterisk; Actual: dash
Unordered list style
213: Expected: asterisk; Actual: dash
Unordered list style
214: Expected: asterisk; Actual: dash
Unordered list style
215: Expected: asterisk; Actual: dash
Unordered list style
216: Expected: asterisk; Actual: dash
Unordered list style
217: Expected: asterisk; Actual: dash
Unordered list style
218: Expected: asterisk; Actual: dash
Unordered list style
219: Expected: asterisk; Actual: dash
Unordered list style
220: Expected: asterisk; Actual: dash
Unordered list style
221: Expected: asterisk; Actual: dash
Unordered list style
222: Expected: asterisk; Actual: dash
Unordered list style
223: Expected: asterisk; Actual: dash
Unordered list style
224: Expected: asterisk; Actual: dash
Unordered list style
225: Expected: asterisk; Actual: dash
Unordered list style
226: Expected: asterisk; Actual: dash
Unordered list style
227: Expected: asterisk; Actual: dash
Unordered list style
228: Expected: asterisk; Actual: dash
Unordered list style
229: Expected: asterisk; Actual: dash
Unordered list style
230: Expected: asterisk; Actual: dash
Unordered list style
231: Expected: asterisk; Actual: dash
Unordered list style
232: Expected: asterisk; Actual: dash
Unordered list style
261: Expected: asterisk; Actual: dash
Unordered list style
262: Expected: asterisk; Actual: dash
Unordered list style
263: Expected: asterisk; Actual: dash
Unordered list style
340: Expected: asterisk; Actual: dash
Unordered list style
341: Expected: asterisk; Actual: dash
Unordered list style
342: Expected: asterisk; Actual: dash
Unordered list style
343: Expected: asterisk; Actual: dash
Unordered list style
344: Expected: asterisk; Actual: dash
Unordered list style
345: Expected: asterisk; Actual: dash
Unordered list style
346: Expected: asterisk; Actual: dash
Unordered list style
347: Expected: asterisk; Actual: dash
Unordered list style
348: Expected: asterisk; Actual: dash
Unordered list style
349: Expected: asterisk; Actual: dash
Unordered list style
350: Expected: asterisk; Actual: dash
Unordered list style
351: Expected: asterisk; Actual: dash
Unordered list style
352: Expected: asterisk; Actual: dash
Unordered list style
353: Expected: asterisk; Actual: dash
Unordered list style
354: Expected: asterisk; Actual: dash
Unordered list style
355: Expected: asterisk; Actual: dash
Unordered list style
356: Expected: asterisk; Actual: dash
Unordered list style
357: Expected: asterisk; Actual: dash
Unordered list style
358: Expected: asterisk; Actual: dash
Unordered list style
359: Expected: asterisk; Actual: dash
Unordered list style
360: Expected: asterisk; Actual: dash
Unordered list style
361: Expected: asterisk; Actual: dash
Unordered list style
362: Expected: asterisk; Actual: dash
Unordered list style
718: Expected: asterisk; Actual: dash
Unordered list style
726: Expected: asterisk; Actual: dash
Unordered list style
771: Expected: asterisk; Actual: dash
Unordered list style
779: Expected: asterisk; Actual: dash
Unordered list style
825: Expected: 1; Actual: 2
Multiple consecutive blank lines
1226: Expected: 1; Actual: 2
Multiple consecutive blank lines
1243: Expected: 1; Actual: 2
Multiple consecutive blank lines
1295: Expected: 1; Actual: 2
Multiple consecutive blank lines
1399: Expected: 1; Actual: 2
Multiple consecutive blank lines
236: null
Bare URL used
267: null
Bare URL used
366: null
Bare URL used
416: null
Bare URL used
428: null
Bare URL used
444: null
Bare URL used
515: null
Bare URL used
526: null
Bare URL used
534: null
Bare URL used
570: null
Bare URL used
595: null
Bare URL used
607: null
Bare URL used
653: null
Bare URL used
654: null
Bare URL used
655: null
Bare URL used
656: null
Bare URL used
657: null
Bare URL used
704: null
Bare URL used
745: null
Bare URL used
798: null
Bare URL used
911: null
Bare URL used
953: null
Spaces inside emphasis markers
953: null
Spaces inside emphasis markers
349: null
Spaces inside code span elements
|
LGTM, but you probably want to update the spec with the new included Event. |
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
x/marker/spec/07_events.md (1)
19-19: Add a brief description for the "Marker Params Updated" section in the table of contents for consistency with other entries.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- x/marker/spec/07_events.md (2 hunks)
Additional Context Used
Markdownlint (32)
x/marker/spec/07_events.md (32)
6: Expected: 0; Actual: 2
Unordered list indentation
7: Expected: 0; Actual: 2
Unordered list indentation
8: Expected: 0; Actual: 2
Unordered list indentation
9: Expected: 0; Actual: 2
Unordered list indentation
10: Expected: 0; Actual: 2
Unordered list indentation
11: Expected: 0; Actual: 2
Unordered list indentation
12: Expected: 0; Actual: 2
Unordered list indentation
13: Expected: 0; Actual: 2
Unordered list indentation
14: Expected: 0; Actual: 2
Unordered list indentation
15: Expected: 0; Actual: 2
Unordered list indentation
16: Expected: 0; Actual: 2
Unordered list indentation
17: Expected: 0; Actual: 2
Unordered list indentation
18: Expected: 0; Actual: 2
Unordered list indentation
19: Expected: 0; Actual: 2
Unordered list indentation
231: Expected: 0 or 2; Actual: 1
Trailing spaces
21: Expected: 1; Actual: 2
Multiple consecutive blank lines
22: Expected: 1; Actual: 3
Multiple consecutive blank lines
24: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
40: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
62: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
75: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
87: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
99: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
111: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
123: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
136: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
149: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
163: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
178: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
208: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
222: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
232: null
Files should end with a single newline character
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- x/marker/spec/07_events.md (2 hunks)
Additional Context Used
Markdownlint (32)
x/marker/spec/07_events.md (32)
6: Expected: 0; Actual: 2
Unordered list indentation
7: Expected: 0; Actual: 2
Unordered list indentation
8: Expected: 0; Actual: 2
Unordered list indentation
9: Expected: 0; Actual: 2
Unordered list indentation
10: Expected: 0; Actual: 2
Unordered list indentation
11: Expected: 0; Actual: 2
Unordered list indentation
12: Expected: 0; Actual: 2
Unordered list indentation
13: Expected: 0; Actual: 2
Unordered list indentation
14: Expected: 0; Actual: 2
Unordered list indentation
15: Expected: 0; Actual: 2
Unordered list indentation
16: Expected: 0; Actual: 2
Unordered list indentation
17: Expected: 0; Actual: 2
Unordered list indentation
18: Expected: 0; Actual: 2
Unordered list indentation
19: Expected: 0; Actual: 2
Unordered list indentation
231: Expected: 0 or 2; Actual: 1
Trailing spaces
21: Expected: 1; Actual: 2
Multiple consecutive blank lines
22: Expected: 1; Actual: 3
Multiple consecutive blank lines
24: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
40: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
62: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
75: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
87: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
99: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
111: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
123: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
136: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
149: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
163: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
178: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
208: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
222: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
232: null
Files should end with a single newline character
Additional comments not posted (1)
x/marker/spec/07_events.md (1)
224-232: LGTM! Ensure the file ends with a newline character for proper formatting.| MaxSupply | \{value for the max allowed supply\} | +
nullpointer0x00
deleted the
nullpointer0x00/add-update-params-to-marker-module
branch
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
New Features
UpdateParamsendpoint and CLI for the marker module.EventMarkerParamsUpdatedevent to track marker parameter updates.Bug Fixes
GetMaxSupplyinstead ofGetParams(ctx).MaxSupply.Documentation
MsgUpdateParamsResponse.Tests
UpdateParamsendpoint and marker parameter updates.Paramsstruct.Refactor
GetMaxSupply.GetMaxTotalSupplyfunction.