Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): point to correct provenanced binary in heighliner image #1985

Merged
merged 2 commits into from
May 21, 2024

Conversation

scirner22
Copy link
Contributor

@scirner22 scirner22 commented May 20, 2024

The heighliner-build-action makes it seem like the heighliner repo chains.yaml is used as a default and overrides can be provided. In practice I was seeing a problem where provenanced could not be found on the recently built image. This adds the fields that exist in chains.yaml so this workflow itself can now be thought of as the canonical configuration rather than the chains.yaml.

Tests

  • docker run provenanceio/provenance@sha256:194ec608f295d753dd936ca6d12046ffb0308651735d66fc7fc594936f8de33e /bin/sh -c "provenanced init --chain-id testing -t network-1 ; provenanced start -t"

Summary by CodeRabbit

  • Chores
    • Updated Docker build configurations in the workflow to enhance build process efficiency and customization.

Copy link
Contributor

coderabbitai bot commented May 20, 2024

Walkthrough

The recent update enhances the GitHub Actions workflow for Docker builds. It includes specifying a custom Dockerfile, adding additional binaries, setting build environment variables, and incorporating build tags. These improvements aim to streamline the Docker build process, making it more flexible and efficient.

Changes

Files Change Summary
.github/workflows/docker.yml Added new configurations for Docker build, including custom Dockerfile, additional binaries, build environment variables, and build tags.

In Docker's realm, where code does sail,
New configs set to never fail.
With binaries and tags in tow,
Our builds now swiftly, smoothly flow.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@scirner22 scirner22 force-pushed the temp-heighliner-push branch from d87a73c to 9bd384e Compare May 20, 2024 20:11
@scirner22 scirner22 changed the title chore(ci): one off commit to push amd64 v1.18.0 heighliner fix(ci): point to correct provenanced binary in heighliner image May 20, 2024
@scirner22 scirner22 force-pushed the temp-heighliner-push branch from 9bd384e to ccdc600 Compare May 20, 2024 20:17
@scirner22 scirner22 marked this pull request as ready for review May 20, 2024 20:17
@scirner22 scirner22 requested a review from a team as a code owner May 20, 2024 20:17
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between b7415ab and ccdc600.
Files selected for processing (1)
  • .github/workflows/docker.yml (1 hunks)
Additional comments not posted (3)
.github/workflows/docker.yml (3)

64-64: Correctly specifies the location of the provenanced binary, addressing the issue of the binary not being found in the image.


59-59: Ensure the 'cosmos' Dockerfile exists and is correctly configured for building the provenanced binary.

Verification successful

The 'cosmos' Dockerfile exists and is correctly configured for building the provenanced binary.

  • The Dockerfile includes multiple FROM statements for different build stages and architectures.
  • It contains COPY commands to ensure the provenanced binary is included in the final image.
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the existence and content of the 'cosmos' Dockerfile.

# Test: Search for the Dockerfile and display its content. Expect: Dockerfile exists and contains relevant build instructions.
fd Dockerfile --exec cat {} \; | grep -i "FROM"

Length of output: 2503


66-68: Ensure the specified build environment variables and tags are appropriate and up-to-date for building the provenanced binary.

Verification successful

The build environment variables and tags specified in the workflow file are indeed referenced in the Makefile and documentation. This confirms that the settings are appropriate and up-to-date for building the provenanced binary.

  • WITH_LEDGER: Enables/Disables building with Ledger hardware wallet support.
  • BUILD_TAGS: Any extra -tags to supply to the go build or go install invocations.
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the appropriateness of build environment variables and tags.

# Test: Check the project documentation or configuration files to confirm these settings. Expect: Settings are recommended and up-to-date.
cat README.md | grep -i "build environment"

Length of output: 45



Script:

#!/bin/bash
# Description: Verify the appropriateness of build environment variables and tags.

# Test: Check Dockerfiles for build environment variables and tags.
fd Dockerfile | xargs cat | grep -iE 'WITH_LEDGER|WITH_CLEVELDB|BUILD_TAGS'

# Test: Check Makefiles for build environment variables and tags.
fd Makefile | xargs cat | grep -iE 'WITH_LEDGER|WITH_CLEVELDB|BUILD_TAGS'

# Test: Check other documentation files for build environment variables and tags.
fd .md | xargs cat | grep -iE 'WITH_LEDGER|WITH_CLEVELDB|BUILD_TAGS'

Length of output: 1048

@SpicyLemon SpicyLemon enabled auto-merge (squash) May 21, 2024 18:44
@SpicyLemon SpicyLemon merged commit ab375a1 into main May 21, 2024
23 checks passed
@SpicyLemon SpicyLemon deleted the temp-heighliner-push branch May 21, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants