-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Rosetta #1981
Remove Rosetta #1981
Conversation
WalkthroughThe recent updates focus on restructuring and simplifying the Provenanced blockchain commands and infrastructure. The Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (5)
CHANGELOG.md (5)
Line range hint
105-350
: Consider using a consistent list marker style in markdown.- 105: - + 105: * - 106: - + 106: * ... - 350: - + 350: *
Line range hint
813-813
: Remove consecutive blank lines to maintain a clean and consistent document structure.- 813: - 1214: - 1231: - 1283: - 1387:Also applies to: 1214-1214, 1231-1231, 1283-1283, 1387-1387
Line range hint
224-224
: Convert bare URLs to markdown links to improve the readability and presentation of the document.- 224: https://github.com/provenance-io/provenance/issues/224 + 224: [Issue #224](https://github.com/provenance-io/provenance/issues/224) ... - 899: https://github.com/provenance-io/provenance/issues/899 + 899: [Issue #899](https://github.com/provenance-io/provenance/issues/899)Also applies to: 255-255, 354-354, 404-404, 416-416, 432-432, 503-503, 514-514, 522-522, 558-558, 583-583, 595-595, 641-645, 692-692, 733-733, 786-786, 899-899
Line range hint
941-941
: Remove spaces inside emphasis markers to correct the markdown syntax.- 941: * message * + 941: *message*
Line range hint
337-337
: Remove spaces inside code span elements to adhere to markdown best practices.- 337: ` MsgAddMarkerRequest ` + 337: `MsgAddMarkerRequest`
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.mod
is excluded by!**/*.mod
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- Makefile (1 hunks)
- cmd/provenanced/cmd/root.go (1 hunks)
Files skipped from review due to trivial changes (2)
- Makefile
- cmd/provenanced/cmd/root.go
Description
This PR removes all the Rosetta stuff. It's now a stand-alone service. See https://github.com/cosmos/rosetta for more info.
Related to:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passesSummary by CodeRabbit
provenanced
executable; now a stand-alone service.test-rosetta
target and related commands removed from the Makefile.