Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/cosmos/ibc-go/v8 from 8.2.1 to 8.3.0 #1978

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 17, 2024

Bumps github.com/cosmos/ibc-go/v8 from 8.2.1 to 8.3.0.

Release notes

Sourced from github.com/cosmos/ibc-go/v8's releases.

v8.3.0

Highlights 🌟

We present here a summary of the most relevant changes, please see the v8.3.0 changelog for the full set of changes included in this release. Check out also the release announcement blog post for more information.

dependencies

  • Cosmos SDK has been bumped to v0.50.6.
  • CometBFT has been bumped to v0.38.7.

core

  • Up until now ibc-go assumed that its underlying consensus is Tendermint, but in this release we have added the ConsensusHost interface that defines methods to validate an IBC light client ClientState and ConsensusState against the host chain's underlying consensus parameters. This enables chains whose underlying consensus is not Tendermint to still use ibc-go and be able to specify how the client state and consensus state of counterparties' light clients should be verified during the connection handshake. A custom implementation of the ConsensusHost interface can be set in the core IBC keeper using function SetConsensusHost. By default the consensus host will be set to the implementation for 07-tendermint. See issue cosmos/ibc-go#5315 and PR cosmos/ibc-go#6055 for more details.

core/02-client

  • We have added the VerifyMembershipProof query service gRPC endpoint that queries an IBC light client for proof verification of a value at a given key path. This endpoint specifically enables light clients to query other light clients through gRPC, and streamlines the process of implementing conditional clients, particularly within the 08-wasm module. The method takes a QueryVerifyMembershipRequest where the ID of the light client the verification parameters (proof, value, height, etc) are specified. See issue cosmos/ibc-go#5310 and PR cosmos/ibc-go#5821 for more details.

apps/transfer

  • In v8.1.0 the field allowed_packet_data was added to the Allocation type used for authz support of IBC transfers. This field was originally a list of MsgTransfer's memo packet data keys that were allowed (i.e. top level JSON object keys). After receiving some feedback (thanks to Yieldmos team), we have re-purposed this field to be a list of full memo strings. That means that this field contains a list of memo strings that that the granter allows the grantee to include in the memo field of MsgTransfer, the grantee can then submit MsgTransfer with one of the allowed memo strings. See the documentation for more information.
  • In OnChanOpenTry, when the counterparty version does not match the executing chain's own version, instead of returning an error, the current version is now returned. This allows the channel handshake to complete in situations where the handshake initiating chain has the fee middleware wired up, but the counterparty doesn't (then transfer channel will be created with a version that does not contain fee middleware information). Similar change has been applied to OnChanOpenTry of the host submodule in 27-interchain-accounts. See PR cosmos/ibc-go#6253 for more details.

apps/27-interchain-accounts

Unordered channels

Support for unordered channels was introduced in v8.1.0, and with this release we have now also changed the default ordering of new ICA channels from ordered to unordered. This means that new ICA channels will be unordered by default. Ordering can be specified either by setting the field ordering of MsgRegisterInterchainAccount or using the newly introduced function RegisterInterchainAccountWithOrdering (in case the legacy RegisterInterchainAccount function is used by a custom auth module).

Queries

We have added the message MsgModuleQuerySafe, which enables to perform queries on the host chain. This message contains a list of QueryRequests that will be routed to the query router when the message MsgModuleQuerySafe is executed on the host chain. The MsgModuleQuerySafe message can be included in the list of encoded sdk.Msgs of InterchainPacketData. The host chain will return on the acknowledgment the responses for all the queries (in the same order as the query requests in the Requests field of the MsgModuleQuerySafe).

Please note that only module safe queries can be executed (i.e. deterministic queries that are safe to be called from within the state machine). See the documentation for more details and the list of supported queries.

Please also note that it is mandatory to register the gRPC query router after the creation of the host submodule's keeper, otherwise nodes will not start. The WithQueryRouter function should be used. Please check the sample integration code in the documentation for more details.

apps/29-fee

  • We have fixed a bug where, upon channel closure, already refunded fees remained in state in the event of one or more of the packet fees attached to a packet not being refunded. See PR cosmos/ibc-go#6255 for more details. Many thanks to @​sushiwushi for reporting this bug.

Contributors ❤️

Special thanks to all external contributors that pushed code for this release:


To learn more about ibc-go versioning, please read our RELEASES.md.

... (truncated)

Changelog

Sourced from github.com/cosmos/ibc-go/v8's changelog.

v8.3.0 - 2024-05-16

Dependencies

  • #6300 Bump Cosmos SDK to v0.50.6 and CometBFT to v0.38.7.

State Machine Breaking

  • (light-clients/07-tendermint) #6276 Fix: No-op to avoid panicking on UpdateState for invalid misbehaviour submissions.

Improvements

  • (apps/27-interchain-accounts, apps/tranfer, apps/29-fee) #6253 Allow channel handshake to succeed if fee middleware is wired up on one side, but not the other.
  • (apps/27-interchain-accounts) #6251 Use UNORDERED as the default ordering for new ICA channels.
  • (apps/transfer) #6268 Use memo strings instead of JSON keys in AllowedPacketData of transfer authorization.

Features

  • (core) #6055 Introduce a new interface ConsensusHost used to validate an IBC ClientState and ConsensusState against the host chain's underlying consensus parameters.
  • (core/02-client) #5821 Add rpc VerifyMembershipProof (querier approach for conditional clients).
  • (core/04-channel) #5788 Add NewErrorAcknowledgementWithCodespace to allow codespaces in ack errors.
  • (apps/27-interchain-accounts) #5785 Introduce a new tx message that ICA host submodule can use to query the chain (only those marked with module_query_safe) and write the responses to the acknowledgement.

Bug Fixes

  • (apps/27-interchain-accounts) #6167 Fixed an edge case bug where migrating params for a pre-existing ica module which implemented controller functionality only could panic when migrating params for newly added host, and align controller param migration with host.
  • (app/29-fee) #6255 Delete refunded fees from state if some fee(s) cannot be refunded on channel closure.

v8.2.0 - 2024-04-05

Dependencies

  • #5975 Bump Cosmos SDK to v0.50.5.

Improvements

  • (proto) #5987 Add wasm proto files.

v8.1.0 - 2024-01-31

Dependencies

  • #5663 Bump Cosmos SDK to v0.50.3 and CometBFT to v0.38.2.

State Machine Breaking

  • (apps/27-interchain-accounts) #5442 Increase the maximum allowed length for the memo field of InterchainAccountPacketData.

Improvements

... (truncated)

Commits
  • 8b708ca update changelog before v8.3.0 release
  • 0b10c11 deps: bump cosmos sdk to v0.50.6 and comet bft to v0.38.7 (#6300)
  • 41b6a00 Update CHANGELOG.md
  • 5470cd2 imp: allow memo strings instead of keys for transfer authorizations (backport...
  • 725fe10 fix: noop on UpdateState for invalid misbehaviour (backport #6276) (#6297)
  • 0cece8d fix: delete already refunded fees from state if some fee cannot be refunded o...
  • 740532d imp(apps): allow one sided fee middleware handshakes to complete (backport #6...
  • 3aa76ad Update CHANGELOG.md
  • b3d46d7 feat(release/v8.3.x): use unordered ordering by default for new ica channels ...
  • 0b77b98 fix: avoid panic when migrate param for newly added host (backport #6167) (#6...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/cosmos/ibc-go/v8](https://github.com/cosmos/ibc-go) from 8.2.1 to 8.3.0.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v8.3.0/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v8.2.1...v8.3.0)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v8
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner May 17, 2024 08:06
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 17, 2024
Copy link
Contributor

coderabbitai bot commented May 17, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SpicyLemon
Copy link
Contributor

This version is not compatible with the SDK version that we currently have. We're based on v0.50.5, but this only compatible with v0.50.6. Eventually, we'll bump our fork and we'll have to bump this with that too. But for now, we'll ignore this version.

@SpicyLemon SpicyLemon closed this May 17, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 17, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/cosmos/ibc-go/v8-8.3.0 branch May 17, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant