Cleanup client config #1962
Cleanup client config #1962
Conversation
…gn mode textual after this logic.
|
Warning Rate Limit Exceeded@Taztingo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 12 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update streamlines transaction signing and client configuration management in the Provenance blockchain's codebase. It involves removing outdated dependencies and obsolete client setup logic while enhancing transaction signing configurations based on the client's online status for improved efficiency and context-aware operations. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (24)
CHANGELOG.md (24)
Line range hint
781-781: Remove extra blank line.-Please remove the extra blank line to maintain a clean and consistent format in the document.
Line range hint
1182-1182: Remove extra blank line.-Please remove the extra blank line to maintain a clean and consistent format in the document.
Line range hint
1199-1199: Remove extra blank line.-Please remove the extra blank line to maintain a clean and consistent format in the document.
Line range hint
1251-1251: Remove extra blank line.-Please remove the extra blank line to maintain a clean and consistent format in the document.
Line range hint
1355-1355: Remove extra blank line.-Please remove the extra blank line to maintain a clean and consistent format in the document.
Line range hint
192-192: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
223-223: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
322-322: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
372-372: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
384-384: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
400-400: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
471-471: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
482-482: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
490-490: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
526-526: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
551-551: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
563-563: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
609-613: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
660-660: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
701-701: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
754-754: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
867-867: Avoid using bare URLs.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
909-909: Remove spaces inside emphasis markers.- * message PR<pull-request-number> + * message PR<pull-request-number>Please ensure that there are no spaces inside the emphasis markers to maintain proper Markdown formatting.
Line range hint
305-305: Remove spaces inside code span elements.- ` message #<issue-number> ` + `message #<issue-number>`Please ensure that there are no spaces inside the code span elements to maintain proper Markdown formatting.
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (3)
CHANGELOG.md (3)
Line range hint
77-321: Consistent list formatting is recommended.- * message #<issue-number> + * Message #<issue-number>Ensure all list items begin with a capital letter for consistency.
Line range hint
195-616: Convert bare URLs to clickable links.- https://github.com/provenance-io/provenance/issues/105 + [Issue #105](https://github.com/provenance-io/provenance/issues/105)This change should be applied to all bare URLs throughout the document to improve readability and accessibility.
Line range hint
784-1358: Reduce multiple consecutive blank lines to a single blank line.-This change should be applied wherever multiple blank lines are found to improve the cleanliness of the document.
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (8)
CHANGELOG.md (8)
Line range hint
77-321: Convert list markers from dashes to asterisks for consistency.- - + *
Line range hint
785-785: Remove consecutive blank lines.-
Line range hint
1186-1186: Remove consecutive blank lines.-
Line range hint
1203-1203: Remove consecutive blank lines.-
Line range hint
1255-1255: Remove consecutive blank lines.-
Line range hint
1359-1359: Remove consecutive blank lines.-
Line range hint
913-913: Remove spaces inside emphasis markers.- * message * + *message*
Line range hint
309-309: Remove spaces inside code span elements.- ` message ` + `message`
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
CHANGELOG.md (1)
Line range hint
77-321: Consistent list marker style is recommended.- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). - - Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). + * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). - - Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). + * Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). - - Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897). + * Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897). - - Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905). + * Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905). - - Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920). + * Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920). - - Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935) + * Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935) - - Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931). + * Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931). - - Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943) + * Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943) - - Clean up ReadFromClient [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Clean up ReadFromClient [#1760](https://github.com/provenance-io/provenance/issues/1760).
* Remove ReadFromClientConfig since we already do this, and move the sign mode textual after this logic. * Update changelog.
Description
Remove the unneeded ReadFromClientConfig since we already do that and add textual signing.
Related to: #1760
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit