Remove legacy marker gov proposal handlers #1961
Conversation
… proposal msg, refactor proposal msgs
|
Warning Rate Limit Exceeded@nullpointer0x00 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 42 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates focus on refining the governance proposal handling for marker accounts. Key changes include removing legacy proposal routes, adding new message response types, deprecating old message types, and enhancing test coverage. These modifications streamline the proposal process, improve code maintainability, and ensure compatibility with the latest governance standards. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
SpicyLemon
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- x/marker/keeper/proposal_handler_test.go (1 hunks)
- x/marker/types/msgs.go (3 hunks)
- x/marker/types/msgs_test.go (6 hunks)
Files skipped from review as they are similar to previous changes (1)
- x/marker/types/msgs_test.go
Additional Context Used
Learnings (1)
x/marker/types/msgs.go (1)
User: nullpointer0x00 PR: provenance-io/provenance#1961 File: x/marker/types/msgs.go:613-0 Timestamp: 2024-05-16T19:35:55.196Z Learning: The error message "amount to decrease must be greater than zero" is used for validation errors in the codebase for consistency.
Additional comments not posted (14)
x/marker/keeper/proposal_handler_test.go (7)
59-131: Comprehensive test coverage forSupplyIncreaseProposal.
133-185: Comprehensive test coverage forSupplyDecreaseProposal.
187-244: Comprehensive test coverage forSetAdministratorProposal.
246-303: Comprehensive test coverage forRemoveAdministratorProposal.
305-390: Comprehensive test coverage forChangeStatusProposal.
392-463: Comprehensive test coverage forWithdrawEscrowProposal.
465-541: Comprehensive test coverage forSetDenomMetadataProposal.x/marker/types/msgs.go (7)
Line range hint
42-459: Well-structured message type forMsgSupplyIncreaseProposalRequest.
610-626: Well-structured message type forMsgSupplyDecreaseProposalRequest.
628-647: Well-structured message type forMsgSetAdministratorProposalRequest.
649-667: Well-structured message type forMsgRemoveAdministratorProposalRequest.
670-684: Well-structured message type forMsgChangeStatusProposalRequest.
686-709: Well-structured message type forMsgWithdrawEscrowProposalRequest.
711-724: Well-structured message type forMsgSetDenomMetadataProposalRequest.
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (5)
CHANGELOG.md (5)
Line range hint
103-218: Consider using a consistent list style in the CHANGELOG.- - + *Also applies to: 247-249, 326-348, 704-704, 712-712, 757-757, 765-765
Line range hint
811-811: Remove consecutive blank lines to maintain a clean and consistent format in the document.-Also applies to: 1212-1212, 1229-1229, 1281-1281, 1385-1385
Line range hint
222-222: Consider using Markdown links instead of bare URLs for better readability and navigation.- https://github.com/provenance-io/provenance/issues/105 + [Issue #105](https://github.com/provenance-io/provenance/issues/105)Also applies to: 253-253, 352-352, 402-402, 414-414, 430-430, 501-501, 512-512, 520-520, 556-556, 581-581, 593-593, 639-639, 640-640, 641-641, 642-642, 643-643, 690-690, 731-731, 784-784, 897-897
Line range hint
939-939: Remove unnecessary spaces inside emphasis markers.- * message _PR<pull-request-number>_ + * message _PR<pull-request-number>_
Line range hint
335-335: Remove unnecessary spaces inside code span elements.- ` MsgAddMarker ` + `MsgAddMarker`
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- app/app.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/app.go
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- x/marker/types/msgs.go (3 hunks)
- x/marker/types/msgs_test.go (6 hunks)
Files skipped from review as they are similar to previous changes (2)
- x/marker/types/msgs.go
- x/marker/types/msgs_test.go
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (7)
CHANGELOG.md (7)
Line range hint
104-217: Consider using a consistent style for unordered lists throughout the document. The current mix of asterisks and dashes can be unified to use only asterisks for better consistency and readability.- - + *
Line range hint
188-349: Ensure consistency in unordered list markers throughout the document by using asterisks instead of dashes.- - + *
Line range hint
327-349: For consistency and readability, consider using asterisks for all unordered list items throughout the document.- - + *
Line range hint
705-705: Multiple consecutive blank lines detected. It's best to limit to one blank line to maintain clean and readable markdown formatting.Also applies to: 713-713, 758-758, 766-766
Line range hint
223-223: Bare URLs are used in the document. It's a good practice to use descriptive link texts instead of bare URLs for better readability and accessibility.Also applies to: 254-254, 353-353, 403-403, 415-415, 431-431, 502-502, 513-513, 521-521, 557-557, 582-582, 594-594, 640-640, 641-641, 642-642, 643-643, 644-644, 691-691, 732-732, 785-785, 898-898
Line range hint
940-940: Remove spaces inside emphasis markers to maintain proper markdown formatting.- * text * + *text*
Line range hint
336-336: Remove spaces inside code span elements to ensure correct markdown rendering.- ` code ` + `code`
nullpointer0x00
deleted the
nullpointer0x00/marker-migrate-legegacy-prop-handlers
branch
Description
Related to:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
New Features
Bug Fixes
Refactor
Tests
Documentation