Clean up the Marker's expected BankKeeper interface. #1954
Conversation
# Conflicts: # x/marker/keeper/keeper_test.go
…ery directly (instead of marker's Holding query) because the marker's Holding query fails if the marker doesn't exist, which we don't care about here.
|
Warning Rate Limit Exceeded@SpicyLemon has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 52 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates refine marker management in the blockchain app, enhancing efficiency and clarity. Changes include introducing a new function for retrieving marker holders, refining marker logic by removing unnecessary iterations, and optimizing the BankKeeper interface by removing less utilized methods. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
CHANGELOG.md (4)
Line range hint
77-319: Convert dashes to asterisks for unordered list items to maintain consistency in list formatting.- - + *
Line range hint
193-193: Convert bare URLs to markdown links for better readability and to follow markdown best practices.- https://github.com/provenance-io/provenance/issues/192 + [Issue #192](https://github.com/provenance-io/provenance/issues/192)
Line range hint
306-306: Remove unnecessary spaces inside code span elements to clean up the formatting.- ` MsgAddAccessRequest ` + `MsgAddAccessRequest`
Line range hint
910-910: Remove spaces inside emphasis markers to correct the markdown formatting.- * message * + *message*
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
CHANGELOG.md (1)
Line range hint
77-321: Consistent list item markers should be used.- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). - - Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). + * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). - - Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). + * Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). - - Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897). + * Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897). - - Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905). + * Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905). - - Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920). + * Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920). - - Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935) + * Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935) - - Attribute module param migration [#1927](https://github.com/provenance-io/provenance/pull/1927). + * Attribute module param migration [#1927](https://github.com/provenance-io/provenance/pull/1927). - - Marker module param migration [#1934](https://github.com/provenance-io/provenance/pull/1934). + * Marker module param migration [#1934](https://github.com/provenance-io/provenance/pull/1934). - - Metadata module param migration [#1932](https://github.com/provenance-io/provenance/pull/1932). + * Metadata module param migration [#1932](https://github.com/provenance-io/provenance/pull/1932). - - Msgfees module param migration [#1936](https://github.com/provenance-io/provenance/pull/1936). + * Msgfees module param migration [#1936](https://github.com/provenance-io/provenance/pull/1936). - - Name module param migration [#1937](https://github.com/provenance-io/provenance/pull/1937). + * Name module param migration [#1937](https://github.com/provenance-io/provenance/pull/1937). - - IbcHooks module param migration [#1939](https://github.com/provenance-io/provenance/pull/1939). + * IbcHooks module param migration [#1939](https://github.com/provenance-io/provenance/pull/1939). - - Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931). + * Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931). - - Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943). + * Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943). - - Clean up the marker module's expected BankKeeper interface [#1954](https://github.com/provenance-io/provenance/pull/1954). + * Clean up the marker module's expected BankKeeper interface [#1954](https://github.com/provenance-io/provenance/pull/1954).
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- x/marker/types/marker_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- x/marker/types/marker_test.go
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
CHANGELOG.md (2)
Line range hint
79-321: Consistent list style is recommended.- * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). - * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). - * Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). - * Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). + * Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). + * Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760).
Line range hint
198-619: Avoid using bare URLs. Use markdown link syntax.- https://github.com/provenance-io/provenance/issues/1772 + [Issue #1772](https://github.com/provenance-io/provenance/issues/1772) - https://github.com/provenance-io/provenance/issues/1760 + [Issue #1760](https://github.com/provenance-io/provenance/issues/1760) - https://github.com/provenance-io/provenance/pull/1922 + [PR #1922](https://github.com/provenance-io/provenance/pull/1922) - https://github.com/provenance-io/provenance/pull/1926 + [PR #1926](https://github.com/provenance-io/provenance/pull/1926)
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (27)
CHANGELOG.md (27)
Line range hint
80-325: Consistent list style is recommended.- - + *
Line range hint
788-788: Remove extra blank lines.-
Line range hint
1189-1189: Remove extra blank lines.-
Line range hint
1206-1206: Remove extra blank lines.-
Line range hint
1258-1258: Remove extra blank lines.-
Line range hint
1362-1362: Remove extra blank lines.-
Line range hint
199-199: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/199 + [Issue #199](https://github.com/provenance-io/provenance/issues/199)
Line range hint
230-230: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/230 + [Issue #230](https://github.com/provenance-io/provenance/issues/230)
Line range hint
329-329: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/329 + [Issue #329](https://github.com/provenance-io/provenance/issues/329)
Line range hint
379-379: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/379 + [Issue #379](https://github.com/provenance-io/provenance/issues/379)
Line range hint
391-391: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/391 + [Issue #391](https://github.com/provenance-io/provenance/issues/391)
Line range hint
407-407: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/407 + [Issue #407](https://github.com/provenance-io/provenance/issues/407)
Line range hint
478-478: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/478 + [Issue #478](https://github.com/provenance-io/provenance/issues/478)
Line range hint
489-489: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/489 + [Issue #489](https://github.com/provenance-io/provenance/issues/489)
Line range hint
497-497: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/497 + [Issue #497](https://github.com/provenance-io/provenance/issues/497)
Line range hint
533-533: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/533 + [Issue #533](https://github.com/provenance-io/provenance/issues/533)
Line range hint
558-558: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/558 + [Issue #558](https://github.com/provenance-io/provenance/issues/558)
Line range hint
570-570: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/570 + [Issue #570](https://github.com/provenance-io/provenance/issues/570)
Line range hint
616-616: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/616 + [Issue #616](https://github.com/provenance-io/provenance/issues/616)
Line range hint
617-617: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/617 + [Issue #617](https://github.com/provenance-io/provenance/issues/617)
Line range hint
618-618: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/618 + [Issue #618](https://github.com/provenance-io/provenance/issues/618)
Line range hint
619-619: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/619 + [Issue #619](https://github.com/provenance-io/provenance/issues/619)
Line range hint
620-620: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/620 + [Issue #620](https://github.com/provenance-io/provenance/issues/620)
Line range hint
667-667: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/667 + [Issue #667](https://github.com/provenance-io/provenance/issues/667)
Line range hint
708-708: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/708 + [Issue #708](https://github.com/provenance-io/provenance/issues/708)
Line range hint
761-761: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/761 + [Issue #761](https://github.com/provenance-io/provenance/issues/761)
Line range hint
874-874: Avoid using bare URLs. Provide a descriptive hyperlink text.- https://github.com/provenance-io/provenance/issues/874 + [Issue #874](https://github.com/provenance-io/provenance/issues/874)
* [1760]: Clean up the marker module's BankKeeper expected keeper. * [1760]: For getAllMarkerHolders, use the bank keeper's DenomOwners query directly (instead of marker's Holding query) because the marker's Holding query fails if the marker doesn't exist, which we don't care about here. * [1760]: Add changelog entry.
Description
This PR removes a couple entries form the marker module's expected BankKeeper interface:
IterateAllBalances: This was originally for theHoldingquery. We've since switched to the SDK'sDenomOwnersquery, so we can get rid of this entry.GetAllSendEnabledEntries: This was only needed for thequicksilverupgrade, and is no longer used.Related to:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
New Features
Refactor
BankKeeperinterface by removing unused methods.Documentation
Bug Fixes