Remove legacy msgfees gov proposal handlers #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe recent changes involve streamlining governance processes in the Provenance project by removing legacy Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
nullpointer0x00
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
CHANGELOG.md (1)
Line range hint
77-319: Ensure consistency in list item markers.- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). - - Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). + * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). - - Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). + * Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). - - Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897). + * Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897). - - Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905). + * Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905). - - Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920). + * Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920). - - Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935) + * Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935) - - Attribute module param migration [#1927](https://github.com/provenance-io/provenance/pull/1927). + * Attribute module param migration [#1927](https://github.com/provenance-io/provenance/pull/1927). - - Marker module param migration [#1934](https://github.com/provenance-io/provenance/pull/1934). + * Marker module param migration [#1934](https://github.com/provenance-io/provenance/pull/1934). - - Metadata module param migration [#1932](https://github.com/provenance-io/provenance/pull/1932). + * Metadata module param migration [#1932](https://github.com/provenance-io/provenance/pull/1932). - - Msgfees module param migration [#1936](https://github.com/provenance-io/provenance/pull/1936). + * Msgfees module param migration [#1936](https://github.com/provenance-io/provenance/pull/1936). - - Name module param migration [#1937](https://github.com/provenance-io/provenance/pull/1937). + * Name module param migration [#1937](https://github.com/provenance-io/provenance/pull/1937). - - IbcHooks module param migration [#1939](https://github.com/provenance-io/provenance/pull/1939). + * IbcHooks module param migration [#1939](https://github.com/provenance-io/provenance/pull/1939). - - Remove `msgfees` legacy gov proposals [#1953](https://github.com/provenance-io/provenance/pull/1953). + * Remove `msgfees` legacy gov proposals [#1953](https://github.com/provenance-io/provenance/pull/1953). - - Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931). + * Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931). - - Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943) + * Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943)
Taztingo
previously approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
CHANGELOG.md (4)
Line range hint
77-321: Use asterisks for unordered list items for consistency.- - + *
Line range hint
195-195: Convert bare URL to a markdown link for better readability.- https://github.com/provenance-io/provenance/issues/105 + [Issue #105](https://github.com/provenance-io/provenance/issues/105)
Line range hint
912-912: Remove unnecessary spaces inside emphasis markers.- * message * + *message*
Line range hint
308-308: Remove unnecessary spaces inside code span elements.- ` code ` + `code`
8 tasks
SpicyLemon
reviewed
May 6, 2024
SpicyLemon
reviewed
May 6, 2024
SpicyLemon
reviewed
May 6, 2024
* [1760]: Fix the min gas prices decorator tests. * [1760]: In GetFeePayerUsingFeeGrant, treat the fee payer and granter as AccAddresses since they're now being given to us as byte slices which don't convert to strings properly in formats. * [1760]: Fix the feegrant tests. * [1760]: Fix signmode stuff in the testutil tests. * [1760]: Fix signing stuff in the msg-fee invoker test. * [1760]: Remove TODO about whether something was needed, it was, so I kept it. * [1760]: Re-enable the internal/antewrapper tests in the github action.
* [1760]: Clean up the marker module's BankKeeper expected keeper. * [1760]: For getAllMarkerHolders, use the bank keeper's DenomOwners query directly (instead of marker's Holding query) because the marker's Holding query fails if the marker doesn't exist, which we don't care about here. * [1760]: Add changelog entry.
* [1760]: Turn off address caching in Test_TestnetCmd because it's caching addresses with the wrong hrp for other tests. This doesn't show up if running tests one file at a time, but causes panics when all the tests in that package are run together. * [1760]: Fix some config unit tests that started failing because they were using fields that no longer exist. * [1760]: Update the config get and changed sub-commands to check all the configs for entries, possibly outputting multiple. * [1760]: Start renaming all the tendermint and tm stuff in the config command. Deprecate 'tendermint' and 'tm' as options for 'get' and 'changed', and add 'cometbft', 'comet', and 'cmt' as options. * [1760]: Set the correct TMCoreSemVer variable when building. * [1760]: Take the tendermint libraries off the allowed import list. Update CONTRIBUTING and SECURITY for the change from tendermint to cometbft. * [1760]: Fix the rest of the tendermint references. * [1760]: Tweak the config get tests to check the current output against a previous value in order to identify fields that were added, removed, renamed, or have new default values. * [1760]: Update pre-upgrade command to change the broadcast mode from block to sync. Make the client config defaults public variables (instead of private consts) so we can update them dynamically if needed. * [1760]: Change the default keyring backend to os, but keep it as test for testnets. Add/Update unit tests for the broadcast mode and keyring backend changes, as well as for the pre-upgrade command changes." * [1760]: Move the setting of the default keyring backend to inside the interceptor so that it can get used when loading the files. * [1760]: Fix a gofmt thing in internal/handlers/aggregate_events_test.go. * [1760]: Add a comment to Test_TestnetCmd explaining why address caching is disabled. * [1760]: Make the config get and changed commands also look for sub-field matches and loose matches. * [1760]: Fix a couple unit tests that, when run together, were ending up with the wrong default keyring backend. * [1760]: Remove cmd/provenanced/cmd from the expected failures in the test github action. * [1760]: Add changelog entries.
* Add changelog. * Fix changelog. * Migrate proposal methods to keeper and update tests. Remove handler from app * Remove proposal messages, types, and tests. Update codec and cli. Remove simulation for proposals. * Fix name tests. * Add coderabbit suggestions. * Remove deprecated and unused proposal handlers for wasm and ibc.
nullpointer0x00
force-pushed
the
nullpointer0x00/msgfees-migrate-legegacy-prop-handlers
branch
from
5d337c9 to
5eb44a7
Compare
There was a problem hiding this comment.
Actionable comments posted: 9
Out of diff range and nitpick comments (8)
x/msgfees/client/cli/cli_test.go (3)
135-141: Consider adding more edge cases to theTestMsgFeesProposalfunction.To ensure comprehensive coverage, consider adding more edge cases to the
TestMsgFeesProposalfunction, such as invalid recipient format and bips out of range.{ name: "failure - invalid recipient format", args: []string{ "add", "--msg-type=/provenance.metadata.v1.MsgWriteRecordRequest", "--additional-fee=612nhash", "--recipient=invalid-recipient", "--bips=100", "--deposit=1000000stake", }, expectErrMsg: "error validating basis points args: decoding bech32 failed: invalid separator index -1", signer: s.accountAddresses[0].String(), }, { name: "failure - bips out of range", args: []string{ "add", "--msg-type=/provenance.metadata.v1.MsgWriteRecordRequest", "--additional-fee=612nhash", fmt.Sprintf("--recipient=%v", s.account2Addr.String()), "--bips=10001", "--deposit=1000000stake", }, expectErrMsg: "error validating basis points args: recipient basis points can only be between 0 and 10,000 : 10001", signer: s.accountAddresses[0].String(), },
271-277: Consider adding more edge cases to theTestUpdateNhashPerUsdMilProposalfunction.To ensure comprehensive coverage, consider adding more edge cases to the
TestUpdateNhashPerUsdMilProposalfunction, such as extremely large or small nhash values.{ name: "failure - extremely large nhash value", args: []string{"999999999999999999999999999999"}, expectErrMsg: "nhash value out of range", signer: s.accountAddresses[0].String(), }, { name: "failure - extremely small nhash value", args: []string{"0"}, expectErrMsg: "nhash value out of range", signer: s.accountAddresses[0].String(), },
321-325: Consider adding more edge cases to theTestUpdateConversionFeeDenomProposalfunction.To ensure comprehensive coverage, consider adding more edge cases to the
TestUpdateConversionFeeDenomProposalfunction, such as invalid denom format.{ name: "failure - invalid denom format", args: []string{"invalid-denom"}, expectErrMsg: "invalid denom format", signer: s.accountAddresses[0].String(), },CHANGELOG.md (5)
Line range hint
94-107: Use asterisks for unordered lists instead of dashes for consistency and proper markdown rendering.- - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> - - message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number> + * message #<issue-number>
Line range hint
802-802: Remove multiple consecutive blank lines to improve readability.- - +Also applies to: 1203-1203, 1220-1220, 1272-1272, 1376-1376
Line range hint
213-213: Format bare URLs as markdown links for better readability and proper rendering.- https://keepachangelog.com/en/1.0.0/ + [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)Also applies to: 244-244, 343-343, 393-393, 405-405, 421-421, 492-492, 503-503, 511-511, 547-547, 572-572, 584-584, 630-634, 681-681, 722-722, 775-775, 888-888
Line range hint
930-930: Remove spaces inside emphasis markers for proper markdown rendering.- _ some text _ + _some text_
Line range hint
326-326: Remove spaces inside code span elements for proper markdown rendering.- ` some code ` + `some code`
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
x/msgfees/types/proposals.pb.gois excluded by!**/*.pb.go
Files selected for processing (11)
- CHANGELOG.md (1 hunks)
- app/app.go (2 hunks)
- proto/provenance/msgfees/v1/proposals.proto (5 hunks)
- x/marker/client/cli/tx.go (1 hunks)
- x/msgfees/client/cli/cli_test.go (4 hunks)
- x/msgfees/client/cli/tx.go (5 hunks)
- x/msgfees/keeper/msg_server_test.go (3 hunks)
- x/msgfees/module/module.go (1 hunks)
- x/msgfees/types/msgs.go (2 hunks)
- x/msgfees/types/msgs_test.go (4 hunks)
- x/msgfees/types/proposal.go (4 hunks)
Files skipped from review as they are similar to previous changes (7)
- app/app.go
- proto/provenance/msgfees/v1/proposals.proto
- x/marker/client/cli/tx.go
- x/msgfees/keeper/msg_server_test.go
- x/msgfees/module/module.go
- x/msgfees/types/msgs.go
- x/msgfees/types/msgs_test.go
Additional Context Used
Learnings (1)
x/msgfees/client/cli/cli_test.go (3)
User: nullpointer0x00 PR: provenance-io/provenance#1953 File: x/msgfees/client/cli/cli_test.go:0-0 Timestamp: 2024-05-14T14:00:46.007Z Learning: The function `GenerateAccountsWithKeyrings` is widely used across different test suites for setting up test environments. However, its error handling is not robustly tested.User: nullpointer0x00 PR: provenance-io/provenance#1953 File: x/msgfees/client/cli/cli_test.go:0-0 Timestamp: 2024-05-14T14:00:46.007Z Learning: The function `GenerateAccountsWithKeyrings` is widely used across different test suites for setting up test environments. However, its error handling is not robustly tested.User: nullpointer0x00 PR: provenance-io/provenance#1953 File: x/msgfees/client/cli/cli_test.go:137-143 Timestamp: 2024-05-14T16:45:30.129Z Learning: The `ValidateBasic` function in the Provenance codebase handles missing required flags, making it unnecessary to test for these cases in higher-level tests.
Taztingo
previously approved these changes
May 15, 2024
SpicyLemon
approved these changes
May 15, 2024
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
x/ibchooks/types/params.pb.gois excluded by!**/*.pb.gox/ibchooks/types/tx.pb.gois excluded by!**/*.pb.gox/ibcratelimit/params.pb.gois excluded by!**/*.pb.go
Files selected for processing (4)
- proto/provenance/ibchooks/v1/params.proto (1 hunks)
- proto/provenance/ibchooks/v1/tx.proto (1 hunks)
- proto/provenance/ibcratelimit/v1/params.proto (1 hunks)
- x/msgfees/client/cli/tx.go (5 hunks)
Files skipped from review as they are similar to previous changes (4)
- proto/provenance/ibchooks/v1/params.proto
- proto/provenance/ibchooks/v1/tx.proto
- proto/provenance/ibcratelimit/v1/params.proto
- x/msgfees/client/cli/tx.go
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (3)
CHANGELOG.md (3)
Line range hint
101-115: Fix the unordered list style to use asterisks instead of dashes for consistency.- Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760). - Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760). - Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760). - Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760). - Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760). - Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897). - Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905). - Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920). - Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760). - Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935) + * Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897). + * Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905). + * Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920). + * Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935)
Line range hint
185-215: Fix the unordered list style to use asterisks instead of dashes for consistency.- Remove `msgfees` legacy gov proposals [#1953](https://github.com/provenance-io/provenance/pull/1953). - Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930). - Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930). - Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930). - Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931). - Removes sync-info code for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - Remove `name` legacy gov proposals [#1963](https://github.com/provenance-io/provenance/pull/1963). - Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943). - Clean up ReadFromClient [#1760](https://github.com/provenance-io/provenance/issues/1760). - Enhance the config get and changed commands to make it easier to find fields [#1968](https://github.com/provenance-io/provenance/pull/1968). - Change the default keyring backend to "os", but leave it as "test" for testnets [#1968](https://github.com/provenance-io/provenance/pull/1968). - Change the default broadcast mode to "sync" [#1968](https://github.com/provenance-io/provenance/pull/1968). - The pre-upgrade command now updates the client config's broadcast mode to "sync" if it's set to "block" [#1968](https://github.com/provenance-io/provenance/pull/1968). - Remove all `GetSigners()` methods [#1957](https://github.com/provenance-io/provenance/pull/1957). - Ensure all `Msg`s have correctly identified `signer` fields [#1957](https://github.com/provenance-io/provenance/pull/1957). - Clean up all the module codecs [#1957](https://github.com/provenance-io/provenance/pull/1957). - Switch to auto-generated `String` and `Equal` methods for most proto messages [#1957](https://github.com/provenance-io/provenance/pull/1957). - Clean up the marker module's expected BankKeeper interface [#1954](https://github.com/provenance-io/provenance/pull/1954). - Add the auto-cli commands and a few others newly added by the SDK [#1971](https://github.com/provenance-io/provenance/pull/1971). + * Remove `msgfees` legacy gov proposals [#1953](https://github.com/provenance-io/provenance/pull/1953). + * Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931). + * Removes sync-info code for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove `name` legacy gov proposals [#1963](https://github.com/provenance-io/provenance/pull/1963). + * Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943). + * Clean up ReadFromClient [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Enhance the config get and changed commands to make it easier to find fields [#1968](https://github.com/provenance-io/provenance/pull/1968). + * Change the default keyring backend to "os", but leave it as "test" for testnets [#1968](https://github.com/provenance-io/provenance/pull/1968). + * Change the default broadcast mode to "sync" [#1968](https://github.com/provenance-io/provenance/pull/1968). + * The pre-upgrade command now updates the client config's broadcast mode to "sync" if it's set to "block" [#1968](https://github.com/provenance-io/provenance/pull/1968). + * Remove all `GetSigners()` methods [#1957](https://github.com/provenance-io/provenance/pull/1957). + * Ensure all `Msg`s have correctly identified `signer` fields [#1957](https://github.com/provenance-io/provenance/pull/1957). + * Clean up all the module codecs [#1957](https://github.com/provenance-io/provenance/pull/1957). + * Switch to auto-generated `String` and `Equal` methods for most proto messages [#1957](https://github.com/provenance-io/provenance/pull/1957). + * Clean up the marker module's expected BankKeeper interface [#1954](https://github.com/provenance-io/provenance/pull/1954). + * Add the auto-cli commands and a few others newly added by the SDK [#1971](https://github.com/provenance-io/provenance/pull/1971).
Line range hint
245-247: Fix the unordered list style to use asterisks instead of dashes for consistency.- The `provenanced query account` command has been removed. It is still available as `provenanced query auth account` [#1971](https://github.com/provenance-io/provenance/pull/1971). - Move the genesis-related commands into a new `genesis` sub-command, and remove the `genesis-` parts of their names [#1971](https://github.com/provenance-io/provenance/pull/1971). - Many of the SDK's query commands have had their usage altered [#1971](https://github.com/provenance-io/provenance/pull/1971). + * The `provenanced query account` command has been removed. It is still available as `provenanced query auth account` [#1971](https://github.com/provenance-io/provenance/pull/1971). + * Move the genesis-related commands into a new `genesis` sub-command, and remove the `genesis-` parts of their names [#1971](https://github.com/provenance-io/provenance/pull/1971). + * Many of the SDK's query commands have had their usage altered [#1971](https://github.com/provenance-io/provenance/pull/1971).
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- app/app.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/app.go
Taztingo
approved these changes
May 16, 2024
nullpointer0x00
deleted the
nullpointer0x00/msgfees-migrate-legegacy-prop-handlers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
New Features
Msg*ProposalRequestmessages to replace deprecated proposal messages.Bug Fixes
Refactor
msgfeesfrom government proposals.Documentation
Chores