Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes sync-info endpoint #1952

Merged
merged 11 commits into from
May 7, 2024
Merged

Removes sync-info endpoint #1952

merged 11 commits into from
May 7, 2024

Conversation

Taztingo
Copy link
Contributor

@Taztingo Taztingo commented Apr 25, 2024 •
edited by coderabbitai bot
Loading

Description

Removes sync-info.

Related to: #1760

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Summary by CodeRabbit

  • Chores
    • Removed outdated sync-status registration code to streamline the application's performance.
  • Bug Fixes
    • Addressed issues in CLI commands, exchange transfers, and simulation state fields.
  • Tests
    • Improved unit tests for better reliability and coverage.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 25, 2024 •
edited
Loading

Walkthrough

The recent changes focus on eliminating outdated features like sync-info code for SDK v0.50 in the provenance project and state-sync status registration in app.go. Updates cover CLI commands, exchange transfers, simulation state fields, and unit test enhancements.

Changes

File(s) Change Summary
CHANGELOG.md Removed sync-info code for SDK v0.50, updated CLI commands, exchange transfers, simulation state fields, and fixed unit tests.
app/.../app.go Removed the registration of statesync.RegisterSyncStatus() function.

🐰✨
A hop, a skip, a code deploy,
Out with the old, in with the joy.
Sync-less now, we leap ahead,
With cleaner code, our path is spread.
Cheers to changes, big and small,
CodeRabbit watches over all. 🌟
🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Taztingo Taztingo changed the title Add statesync Add sync-info back Apr 25, 2024
@Taztingo
Copy link
Contributor Author

This PR is being closed since it is no longer possible to support this rpc endpoint unless we fork cometbft. The Routes are no longer global and are encapsulated inside an Environment object that is created right before the rpc server is started. The sync-info endpoint provided the user with the binary version, block height, and the block hash. This information can be retrieved from other endpoints.

  • block_height: This was previously known by the user since it was a parameter, but the latest height can be obtained with status.
  • block_hash: This can be obtained from either the block or newly introduced header endpoint.
  • version: The binary version can be obtained from the provenanced status command.

@Taztingo Taztingo closed this Apr 26, 2024
@Taztingo
Copy link
Contributor Author

Taztingo commented May 1, 2024 •
edited
Loading

Reopening since sync-info code has to be removed.

@Taztingo Taztingo reopened this May 1, 2024
@Taztingo Taztingo changed the title Add sync-info back Removes sync-info command May 1, 2024
@Taztingo Taztingo marked this pull request as ready for review May 1, 2024 14:37
@Taztingo Taztingo requested a review from a team as a code owner May 1, 2024 14:37
coderabbitai[bot]
coderabbitai bot reviewed May 1, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
CHANGELOG.md (1)

Line range hint 77-321: Consistent list item markers should be used.

- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).
+ * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).
- - Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922).
+ * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922).
- - Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926).
+ * Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926).
- - Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897).
+ * Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897).
- - Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905).
+ * Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905).
- - Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920).
+ * Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920).
- - Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935)
+ * Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935)
-   *  Attribute module param migration [#1927](https://github.com/provenance-io/provenance/pull/1927).
+   *  Attribute module param migration [#1927](https://github.com/provenance-io/provenance/pull/1927).
-   *  Marker module param migration [#1934](https://github.com/provenance-io/provenance/pull/1934).
+   *  Marker module param migration [#1934](https://github.com/provenance-io/provenance/pull/1934).
-   *  Metadata module param migration [#1932](https://github.com/provenance-io/provenance/pull/1932).
+   *  Metadata module param migration [#1932](https://github.com/provenance-io/provenance/pull/1932).
-   *  Msgfees module param migration [#1936](https://github.com/provenance-io/provenance/pull/1936).
+   *  Msgfees module param migration [#1936](https://github.com/provenance-io/provenance/pull/1936).
-   *  Name module param migration [#1937](https://github.com/provenance-io/provenance/pull/1937).
+   *  Name module param migration [#1937](https://github.com/provenance-io/provenance/pull/1937).
-   *  IbcHooks module param migration [#1939](https://github.com/provenance-io/provenance/pull/1939).
+   *  IbcHooks module param migration [#1939](https://github.com/provenance-io/provenance/pull/1939).
- - Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930).
+ * Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930).
- - Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930).
+ * Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930).
- - Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930).
+ * Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930).
- - Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931).
+ * Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931).
- - Removes sync-info code for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Removes sync-info code for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943)
+ * Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943)

@Taztingo Taztingo self-assigned this May 1, 2024
@Taztingo Taztingo enabled auto-merge (squash) May 2, 2024 18:13
@Taztingo Taztingo added this to the v1.19.0 milestone May 2, 2024
@SpicyLemon SpicyLemon changed the title Removes sync-info command Removes sync-info endpoint May 6, 2024
@Taztingo Taztingo merged commit f58633d into main May 7, 2024
25 of 36 checks passed
@Taztingo Taztingo deleted the taztingo/sync-info branch May 7, 2024 17:30
coderabbitai[bot]
coderabbitai bot reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
CHANGELOG.md (1)

Line range hint 77-321: Consistency in list item markers.

- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).
+ * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).
- - Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922).
+ * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922).
- - Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926).
+ * Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926).
- - Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897).
+ * Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897).
- - Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905).
+ * Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905).
- - Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920).
+ * Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920).
- - Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935)
+ * Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935)
-   *  Attribute module param migration [#1927](https://github.com/provenance-io/provenance/pull/1927).
+   *  Attribute module param migration [#1927](https://github.com/provenance-io/provenance/pull/1927).
-   *  Marker module param migration [#1934](https://github.com/provenance-io/provenance/pull/1934).
+   *  Marker module param migration [#1934](https://github.com/provenance-io/provenance/pull/1934).
-   *  Metadata module param migration [#1932](https://github.com/provenance-io/provenance/pull/1932).
+   *  Metadata module param migration [#1932](https://github.com/provenance-io/provenance/pull/1932).
-   *  Msgfees module param migration [#1936](https://github.com/provenance-io/provenance/pull/1936).
+   *  Msgfees module param migration [#1936](https://github.com/provenance-io/provenance/pull/1936).
-   *  Name module param migration [#1937](https://github.com/provenance-io/provenance/pull/1937).
+   *  Name module param migration [#1937](https://github.com/provenance-io/provenance/pull/1937).
-   *  IbcHooks module param migration [#1939](https://github.com/provenance-io/provenance/pull/1939).
+   *  IbcHooks module param migration [#1939](https://github.com/provenance-io/provenance/pull/1939).
- - Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930).
+ * Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930).
- - Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930).
+ * Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930).
- - Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930).
+ * Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930).
- - Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931).
+ * Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931).
- - Removes sync-info code for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Removes sync-info code for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943)
+ * Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943)

Ensure consistency in the use of list item markers throughout the document. The document uses asterisks (*) for list items, but dashes (-) are used in several places. It's best to stick to one style for list items to maintain consistency.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 30b2adc and 53378e9.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

nullpointer0x00 pushed a commit that referenced this pull request May 15, 2024
@Taztingo @nullpointer0x00
Removes sync-info command (#1952)
b81138a 
* Update changelog.

* First attempt at state-sync.

* Temporary commit with changes.

* Update changelog.

* Revert to what is in main.

* Remove sync-info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@SpicyLemon SpicyLemon SpicyLemon approved these changes

@iramiller iramiller iramiller approved these changes

Assignees

@Taztingo Taztingo

Labels
None yet
Projects
None yet
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Taztingo @iramiller @SpicyLemon