Update our wasmd fork #1948
Update our wasmd fork #1948
Conversation
WalkthroughThe changes encompass enhancements in the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (5)
CHANGELOG.md (5)
Line range hint
75-315: Consider using a consistent list marker style in the changelog.The changelog uses dashes (-) for list items, which is inconsistent with the expected asterisk (*) style. For consistency and to adhere to Markdown best practices, consider using asterisks for list items throughout the changelog.
Line range hint
189-610: Ensure URLs are properly formatted in Markdown.Several entries in the changelog contain bare URLs. For better readability and to follow Markdown best practices, consider using Markdown link syntax to format these URLs properly.
Line range hint
906-906: Remove unnecessary spaces inside emphasis markers.- * Fixed ** some ** emphasis errors. + * Fixed **some** emphasis errors.There are unnecessary spaces inside the emphasis markers, which could lead to improper rendering of the text. Removing these spaces will ensure the text is emphasized correctly.
Line range hint
302-302: Ensure there are no unnecessary spaces inside code span elements.- Here is a ` code ` example. + Here is a `code` example.There are unnecessary spaces inside the code span elements. Removing these spaces will ensure the code is displayed correctly.
Line range hint
778-1352: Remove multiple consecutive blank lines.- - +There are multiple consecutive blank lines in the document, which could affect the readability and structure of the content. Reducing these to a single blank line will help maintain a cleaner and more organized document.
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
CHANGELOG.md (4)
Line range hint
75-315: Change list markers from dashes (-) to asterisks (*) for consistency with Markdown standards.- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).
Line range hint
189-610: Wrap bare URLs in angle brackets to prevent them from being interpreted as Markdown links.- https://github.com/provenance-io/provenance/issues/1772 + <https://github.com/provenance-io/provenance/issues/1772>
Line range hint
906-906: Remove unnecessary spaces inside emphasis markers for correct Markdown formatting.- *message ** PR<pull-request-number>** + *message **PR<pull-request-number>**
Line range hint
302-302: Remove unnecessary spaces inside code span elements for correct Markdown formatting.- ` message #<issue-number> ` + `message #<issue-number>`
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (3)
CHANGELOG.md (3)
Line range hint
75-316: Consistent Markdown Formatting for Unordered ListsThe changelog uses dashes (
-) instead of asterisks (*) for unordered lists. For consistency and to adhere to common Markdown practices, consider using asterisks for unordered lists. Here's how you can update the formatting:- - Bump `wasmd` to v0.17.0 [#345](https://github.com/provenance-io/provenance/issues/345) + * Bump `wasmd` to v0.17.0 [#345](https://github.com/provenance-io/provenance/issues/345)
Line range hint
779-1353: Remove Multiple Consecutive Blank LinesThere are multiple consecutive blank lines in the changelog, which can disrupt the flow and readability of the document. Consider removing these extra blank lines to improve the cleanliness of the document. For example:
- - +
Line range hint
190-611: Use Markdown Link Syntax for URLsThere are several instances of bare URLs in the changelog. For better readability and to make the document more accessible, consider using Markdown link syntax. For example:
- https://github.com/provenance-io/provenance/issues/345 + [Issue #345](https://github.com/provenance-io/provenance/issues/345)
Description
Our fork of wasmd is still needed because we have additional enforcements when handling a submessage from a smart contract. This updates our fork to v0.50.0.
Related to: #1760
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
Newto improve module initialization.v0.50.0.