-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MsgFees param store migration #1936
MsgFees param store migration #1936
Conversation
WalkthroughThe updates primarily focus on the migration and management of parameters within the Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Actionable comments outside the diff hunks (3)
CHANGELOG.md (3)
Line range hint
72-311
: Consider using a consistent bullet point style for unordered lists throughout the document.- - + *
Line range hint
185-606
: Consider using markdown link syntax to format bare URLs for better readability and accessibility.- https://github.com/provenance-io/provenance/issues/105 + [Issue #105](https://github.com/provenance-io/provenance/issues/105)
Line range hint
774-1348
: Remove unnecessary consecutive blank lines to maintain a clean and professional document structure.-
Removes the use of param store in the msgfees module and uses module's store for params.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passesSummary by CodeRabbit
New Features
MsgFees
parameters to a new store for enhanced management.MsgFees
parameters like floor gas price and conversion fee denominations through new methods.Refactor
MsgFeesKeeper
to improve performance and maintainability.query_server.go
to enhance code clarity and efficiency.Documentation
MsgFees
module.Tests
MsgFees
parameters.