Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsgFees param store migration #1936

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Apr 16, 2024

Removes the use of param store in the msgfees module and uses module's store for params.

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Summary by CodeRabbit

  • New Features

    • Introduced migration of MsgFees parameters to a new store for enhanced management.
    • Added functionality to retrieve and set MsgFees parameters like floor gas price and conversion fee denominations through new methods.
  • Refactor

    • Updated initialization and parameter management in MsgFeesKeeper to improve performance and maintainability.
    • Simplified parameter retrieval in the query_server.go to enhance code clarity and efficiency.
  • Documentation

    • Updated the changelog to include recent changes and migrations related to the MsgFees module.
  • Tests

    • Added new test cases to verify the functionality of getting and setting MsgFees parameters.
    • Modified existing tests to adapt to changes in the parameter management setup.

Copy link
Contributor

coderabbitai bot commented Apr 16, 2024

Walkthrough

The updates primarily focus on the migration and management of parameters within the MsgFees module. This includes the removal of outdated dependencies, refactoring of parameter retrieval and setting mechanisms, and the addition of migration functionalities to support upcoming upgrades. The changes ensure a more streamlined and modular approach to parameter management in line with recent architectural guidelines.

Changes

Files Change Summary
CHANGELOG.md Added entry about Msgfees module parameter migration.
app/app.go, app/upgrades.go Modified initialization and migration functions for MsgFeesKeeper and paramsKeeper, including parameter migration for MsgFees.
x/msgfees/keeper/... Removed outdated paramtypes.Subspace references, refactored parameter handling methods, and updated test setups.
x/msgfees/types/keys.go, x/msgfees/types/params.go Added new ParamStoreKey and updated comments regarding parameter store keys.

Possibly related issues

🐰✨🌟
In the land of code, where parameters roam,
A rabbit hopped, making blockchain its home.
With a flick of its tail, old ways refine,
New keys in place, as stars align.
Cheers to change, let’s hop to the beat,
In this blockchain burrow, success we'll greet!
🌟✨🐰


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0c2cc06 and 7477449.
Files selected for processing (1)
  • x/msgfees/types/keys.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • x/msgfees/types/keys.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nullpointer0x00 nullpointer0x00 self-assigned this Apr 17, 2024
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review April 17, 2024 14:39
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner April 17, 2024 14:39
Taztingo
Taztingo previously approved these changes Apr 17, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Actionable comments outside the diff hunks (3)
CHANGELOG.md (3)

Line range hint 72-311: Consider using a consistent bullet point style for unordered lists throughout the document.

- -
+ *

Line range hint 185-606: Consider using markdown link syntax to format bare URLs for better readability and accessibility.

- https://github.com/provenance-io/provenance/issues/105
+ [Issue #105](https://github.com/provenance-io/provenance/issues/105)

Line range hint 774-1348: Remove unnecessary consecutive blank lines to maintain a clean and professional document structure.

-

app/upgrades.go Show resolved Hide resolved
@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) April 17, 2024 15:58
@nullpointer0x00 nullpointer0x00 merged commit 0a8592c into main Apr 17, 2024
19 of 36 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/msgfees-param-store-migration branch April 17, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants