Metadata os param store addition #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes in this update focus on migrating module parameters from the param space to a new module store in the software project. These modifications streamline parameter handling, initialization processes, and querying mechanisms, enhancing system efficiency and organization by centralizing parameter storage. Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Actionable comments outside the diff hunks (11)
CHANGELOG.md (11)
Line range hint
64-69: Ensure consistency in list item markers.- * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). - * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). - * Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). + * Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926).
Line range hint
140-171: Ensure consistency in list item markers.- * Support commitments in the exchange module [#1789](https://github.com/provenance-io/provenance/issues/1789), [PR 1830](https://github.com/provenance-io/provenance/pull/1830). - * Add [Payments](x/exchange/spec/01_concepts.md#payments) to the exchange module [#1703](https://github.com/provenance-io/provenance/issues/1703). - * Add the ibcratelimit module [#1498](https://github.com/provenance-io/provenance/issues/1498). - * Add NAV support for metadata scopes [#1749](https://github.com/provenance-io/provenance/issues/1749). - * Add fix for NAV units to tourmaline upgrade handler [#1815](https://github.com/provenance-io/provenance/issues/1815). - * In the marker module's `SendRestrictionFn`, allow a transfer agent to be identified through the context [#1834](https://github.com/provenance-io/provenance/issues/1834). - * In the exchange module, provide the admin as the transfer agent when attempting to move funds [#1834](https://github.com/provenance-io/provenance/issues/1834). - * Add upgrade handler to set net asset values to markers in pio-testnet-1 [PR 1881](https://github.com/provenance-io/provenance/pull/1881). - * Add upgrade handler to set net asset values and update block height for pio-mainnet-1 [PR 1888](https://github.com/provenance-io/provenance/pull/1888). + * Support commitments in the exchange module [#1789](https://github.com/provenance-io/provenance/issues/1789), [PR 1830](https://github.com/provenance-io/provenance/pull/1830). + * Add [Payments](x/exchange/spec/01_concepts.md#payments) to the exchange module [#1703](https://github.com/provenance-io/provenance/issues/1703). + * Add the ibcratelimit module [#1498](https://github.com/provenance-io/provenance/issues/1498). + * Add NAV support for metadata scopes [#1749](https://github.com/provenance-io/provenance/issues/1749). + * Add fix for NAV units to tourmaline upgrade handler [#1815](https://github.com/provenance-io/provenance/issues/1815). + * In the marker module's `SendRestrictionFn`, allow a transfer agent to be identified through the context [#1834](https://github.com/provenance-io/provenance/issues/1834). + * In the exchange module, provide the admin as the transfer agent when attempting to move funds [#1834](https://github.com/provenance-io/provenance/issues/1834). + * Add upgrade handler to set net asset values to markers in pio-testnet-1 [PR 1881](https://github.com/provenance-io/provenance/pull/1881). + * Add upgrade handler to set net asset values and update block height for pio-mainnet-1 [PR 1888](https://github.com/provenance-io/provenance/pull/1888).
Line range hint
200-202: Ensure consistency in list item markers.- * Add CLI commands for the exchange module endpoints and queries [#1701](https://github.com/provenance-io/provenance/issues/1701). - * Create CLI commands for adding a market to a genesis file [#1757](https://github.com/provenance-io/provenance/issues/1757). - * Add CLI command to generate autocomplete shell scripts [#1762](https://github.com/provenance-io/provenance/pull/1762). + * Add CLI commands for the exchange module endpoints and queries [#1701](https://github.com/provenance-io/provenance/issues/1701). + * Create CLI commands for adding a market to a genesis file [#1757](https://github.com/provenance-io/provenance/issues/1757). + * Add CLI command to generate autocomplete shell scripts [#1762](https://github.com/provenance-io/provenance/pull/1762).
Line range hint
279-301: Ensure consistency in list item markers.- * Create the `x/exchange` module which facilitates the buying and selling of assets [#1658](https://github.com/provenance-io/provenance/issues/1658), [#1699](https://github.com/provenance-io/provenance/issues/1699), [#1700](https://github.com/provenance-io/provenance/issues/1700). - * Allow marker's transfer authority to prevent transfer of restricted coin with deny list on send [#1518](https://github.com/provenance-io/provenance/issues/1518). - * Add net asset value to markers [#1328](https://github.com/provenance-io/provenance/issues/1328). - * Add ICQHost and Oracle module to allow cross chain oracle queries [#1497](https://github.com/provenance-io/provenance/issues/1497). - * New `GetByAddr` metadata query [#1443](https://github.com/provenance-io/provenance/issues/1443). - * Add Trigger module queries to stargate whitelist for smart contracts [#1636](https://github.com/provenance-io/provenance/issues/1636). - * Added the saffron upgrade handlers [PR 1648](https://github.com/provenance-io/provenance/pull/1648). + * Create the `x/exchange` module which facilitates the buying and selling of assets [#1658](https://github.com/provenance-io/provenance/issues/1658), [#1699](https://github.com/provenance-io/provenance/issues/1699), [#1700](https://github.com/provenance-io/provenance/issues/1700). + * Allow marker's transfer authority to prevent transfer of restricted coin with deny list on send [#1518](https://github.com/provenance-io/provenance/issues/1518). + * Add net asset value to markers [#1328](https://github.com/provenance-io/provenance/issues/1328). + * Add ICQHost and Oracle module to allow cross chain oracle queries [#1497](https://github.com/provenance-io/provenance/issues/1497). + * New `GetByAddr` metadata query [#1443](https://github.com/provenance-io/provenance/issues/1443). + * Add Trigger module queries to stargate whitelist for smart contracts [#1636](https://github.com/provenance-io/provenance/issues/1636). + * Added the saffron upgrade handlers [PR 1648](https://github.com/provenance-io/provenance/pull/1648).
Line range hint
657-665: Ensure consistency in list item markers.- * Add support to add/remove required attributes for a restricted marker. [#1512](https://github.com/provenance-io/provenance/issues/1512) - * Add trigger module for delayed execution. [#1462](https://github.com/provenance-io/provenance/issues/1462) - * Add support to update the `allow_forced_transfer` field of a restricted marker [#1546](https://github.com/provenance-io/provenance/issues/1546). - * Add expiration date value to `attribute` [#1435](https://github.com/provenance-io/provenance/issues/1435). - * Add endpoints to update the value owner address of scopes [#1329](https://github.com/provenance-io/provenance/issues/1329). - * Add pre-upgrade command that updates config files to newest format and sets `consensus.timeout_commit` to `1500ms` [PR 1594](https://github.com/provenance-io/provenance/pull/1594), [PR 1600](https://github.com/provenance-io/provenance/pull/1600). + * Add support to add/remove required attributes for a restricted marker. [#1512](https://github.com/provenance-io/provenance/issues/1512) + * Add trigger module for delayed execution. [#1462](https://github.com/provenance-io/provenance/issues/1462) + * Add support to update the `allow_forced_transfer` field of a restricted marker [#1546](https://github.com/provenance-io/provenance/issues/1546). + * Add expiration date value to `attribute` [#1435](https://github.com/provenance-io/provenance/issues/1435). + * Add endpoints to update the value owner address of scopes [#1329](https://github.com/provenance-io/provenance/issues/1329). + * Add pre-upgrade command that updates config files to newest format and sets `consensus.timeout_commit` to `1500ms` [PR 1594](https://github.com/provenance-io/provenance/pull/1594), [PR 1600](https://github.com/provenance-io/provenance/pull/1600).
Line range hint
710-718: Ensure consistency in list item markers.- * Address the [Barberry security advisory](https://forum.cosmos.network/t/cosmos-sdk-security-advisory-barberry/10825) [PR 1576](https://github.com/provenance-io/provenance/pull/1576) + * Address the [Barberry security advisory](https://forum.cosmos.network/t/cosmos-sdk-security-advisory-barberry/10825) [PR 1576](https://github.com/provenance-io/provenance/pull/1576)
Line range hint
764-764: Ensure there are no multiple consecutive blank lines.-
Line range hint
1165-1165: Ensure there are no multiple consecutive blank lines.-
Line range hint
1182-1182: Ensure there are no multiple consecutive blank lines.-
Line range hint
1234-1234: Ensure there are no multiple consecutive blank lines.-
Line range hint
1338-1338: Ensure there are no multiple consecutive blank lines.-
SpicyLemon
approved these changes
Apr 16, 2024
Taztingo
approved these changes
Apr 16, 2024
nullpointer0x00
deleted the
nullpointer0x00/metadata-param-store-migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the use of param store in the metadata module and uses module's store for params. Currently, metadata module only has a set of os locator params that needed migrated.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit