Merge 'main-v0.50' into main. #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [1772]: Bump the sdk to v0.50.1 (from v0.46.13-pio-2). Reorg the replace lines. Replace jwt since the SDK does that too. * [1772]: Import cosmossdk.io/simapp instead of github.com/cosmos/cosmos-sdk/simapp. Require that in go.mod. Add replaces for store, evidence, feegrant, and upgrade. Bump wasmd to v0.50.0 (from v0.29.0 -> v0.30.0-pio-5) and comment out the replace line. Bump wasmv to v1.5.0 (from v1.2.4). * [1772]: Bump ibc-apps to v7.1.1 (from v6.1.0). * [1772]: Bump ibc-go to v8.0.0 (from v6.2.0). * [1772]: Require cosmossdk.io/store v1.0.1 and change all imports of github.com/cosmos/cosmos-sdk/store to it. * [1772]: Require cosmossdk.io/x/evidence v0.1.0 and replace all imports of github.com/cosmos/cosmos-sdk/x/evidence with it. * [1772]: Require cosmossdk.io/x/feegrant v0.1.0 and replace all imports of github.com/cosmos/cosmos-sdk/x/feegrant with it. * [1772]: Require cosmossdk.io/x/upgrade v0.1.0 and replace all imports of github.com/cosmos/cosmos-sdk/x/upgrade with it. * [1772]: go mod tidy -e * Updates to spec docs (#1773) * Updates to verbiage and reorder the sidebar * Add backticks to ibcratelimit title * Update verbiage in readme * Removing all the page metadata as it's not needed with moving to alphabetical order only * [1772]: Comment out and note all uses of async-icq/v7 stuff. * [1772]: Remove the legacy upgrade proposal stuff that has now been removed. * Remove old wasm proposal handlers (since they don't exist anymore). * [1772]: Switch tmservice import to cmtservice. * [1772]: Fix streaming import. * [1772]: Switch all the capability imports over to ibc-go. * [1772]: Remove the distribution proposal handler since it's gone now. * [1772]: Fix a bunch of the ibc-go imports. * [1772]: Remove the ibc-go gov proposals since they don't exist anymore. * [1772]: Comment out and note the quarantine stuff. * [1772]: Update the proto-update-deps.sh script to get ibc-go v8, and add a TODO in there to check it. * [1772]: Comment out and note the sanction stuff. * [1772]: Fix the imports for the snapshot stuff. * [1772]: Fix uses of simapp/helpers which doesn't exist anymore. * [1772]: Fix pruningtypes import. * [1772]: Fix moved ibc-go GenTx. * [1772]: Fix moved ibc-go tendermin light-client types. * [1772] Fix testutil import. * [1772]: Fix staking test import. * [1772]: Move the SimAppChainID const to pioconfig to get rid of circular dependency. * [1772]: Bump go to 1.21 since one of the ibc libraries requires it. * [1772]: Switch the tendermint loggers to cosmosio. * [1772]: Switch from the experimental maps library to the built-in (added in 1.21). * [1772]: Change calls to CreateDefaultCometConfig (was previously named CreateDefaultTendermintConfig). * Change all tendermint/tendermint imports to cometbft. * [1772]: Switch to cometbft-db (from tm-db). * [1772]: Switch go-metrics to hashicorp (from armon) since that's what the sdk wants now. * [1772]: Include a couple now-unused variables in a TODO comment. * [1772]: Switch to the sdkmath version of all that stuff that was still referenced under sdk (which isn't there anymore). * [1772]: Fix calls to ZeroLogWrapper which doesn't exist anymore and is now more like log.NewCustomLogger. * [1772]: In statesync: fix RoutesMap variable (used to be just Routes). Comment out the block stuff since I'm not sure how to fix that right now. * [1772]: Comment out references to the GetLockedCoinsFn. * [1772]: Fix calls to the moved KVStorePrefixIterator function (now in store/types, was in sdk/types). * [1772]: Switch to github.com/cosmos/gogoproto/proto (from github.com/gogo/protobuf/proto) since that's what the SDK wants a lot now. * [1772]: Apparently it's LegacyDec and LegacyNewDec now instead of Dec and NewDec. * [1772]: Fix new use of log.CreateSDKLogger (forgot the library). * [1772]: Fix references to storetypes.GasMeter (used to be in sdk). * [1772]: Comment out more in the sync info. I was wrong about RoutesMap, that's a type not a global var. That's going to be a pain. * [1772]: Further compilation fix in the oracle relay (var not used). * [1772]: Fix due to changed return type of FeeGranter(). * [1772]: Change back to ReadPageRequest (from ReadPageRequestWithPageKeyDecoded) since that's a custom thing in our sdk fork, and add todos on all of them. * [1772]: Change several import aliases from tm* to cmt* and standardize a couple others. * [1772]: Fix references to storetypes.KVStore (used to be in the SDK). * [1772]: Comment out use of WithVestingLockedBypass. * [1772]: Fix (again) the call to CreateSDKLogger. * [1772]: It's bytes.Equal not bytes.Equals. * [1772]: Maybe finally fix the call to CreateSDKLogger. * [1772]: Comment out call to NewSigVerificationDecorator because the 2nd argument type changed. * [1772]: Fix simtypes alias in the one file where it was different. * [1772]: Fix references to proposal.ParamChange (moved from simtypes). * [1772]: Fix calls to GetOrGenerate which no longer takes in a codec. * [1772]: Fix calls to NewOperationMsg which no longer takes in a codec. * Revert "[1772]: Fix references to proposal.ParamChange (moved from simtypes)." This reverts commit 637fb4d. * [1772]: Fix uses of LegacyParamChange and NewSimParamChange (used to be ParamChange and NewSimParamChange). * [1772]: Remove reference to authzcodec.Amino which doesn't exist anymore. * [1772]: Implement the new AppModule and add some TOODs for module stuff. * [1772]: Fix the authz, bank, and gov expected keepers to take in a context.Context instead of the sdk version. * [1772]: Fix calls to FundAccount (the bank keeper and context arguments swapped). * [1772]: StoreDecoderRegistry moved into simtypes (from sdk). * [1772]: StakingKeeper.BondDenom(ctx) now returns an error too. * [1772]: Add some todo notes about migrating params stuff. * [1772]: Comment out the FeeHandler stuff (which is custom to our fork, so not yet back in). * [1772]: Comment out the IMsgServiceRouter stuff since that's only in our fork. * [1772]: Fix the ValidatorHooks. Implement AfterUnbondingInitiated (added to the interface). And they all take in a context.Context now (instead of sdk.Context). * [1772]: Fix a lot of the staking keeper stuff that now returns an error (instead of a bool or nothing). * [1772]: Remove uses of sdk.Handler which no longer exists. * Delete uss of sdk.Route and sdk.NewRoute and some related now-unneeded stuff. * [1772]: Fix event attribute stuff since the Key and Value are now strings (instead of byte slices). * [1772]: NewInfiniteGasMeter moved into storetypes (from sdk). * [1772]: Get rid of our CosmosApp interface and just use the sdk's runtime.AppI. * [1772]: Fix a lot of the BeginBlock(er) and EndBlock(er) stuff and delete some unneeded ones. * [1772]: Comment out all the uses of app.BeginBlock and app.EndBlock since they don't exist anymore. * [1772]: Fix use of InitChain (that had a signature change). * [1772]: Delete missed use of sdk.Route. * [1772]: Fix references to govtypes.AttributeValueCategory (no longer exists) with TODOs to make sure it's still correct (might just be 'gov'). * [1772]: Fix uses of GetOperator() and GetDelegatorAddr() since they now return strings but we need them as addresses. Fix calls to LegacyNewDecWithPrec (was NewDecWithPrec). * [1772]: Fix uses of Msg.ValidateBasic and Msg.GetSigners. * [1772]: Fix the marker authz authoriation (signature change on Accept). * [1772]: Comment out the event history stuff (with TODOs). * [1772]: Fix some calls to NewGasMeter (moved to storetypes from sdk). * [1772]: Update the the auto-generated stuff that references the old .Dec and .Int types that no longer exists. * [1772]: Fix reference to storetypes.Iterator (used to have an alias in the sdk). * [1772]: Comment out the uses of our custom gov cli stuff (with TODOs). * [1772]: Update marker send restriction to match new signature (takes in go context instead of sdk one). * [1772]: Remove use of sdk.Querier (it's gone now) and add TODOs to delete the queriers. * [1772]: Fix some uses of sdkmath stuff (mostly just standardize the import to use the sdmkath alias). * [1772]: Fix uses of BaseApp.NewContext (no longer takes in a header). * [1772]: Remove uses of coin and coins IsEqual which has gone away (and the people rejoice). Replaced with just .Equal. * [1772]: Fix uses of msg.Type() and OperationInput.MsgType. * [1772]: Fix references to sdk.KVPair which went away, but there's still types/kv.Pair. * [1772]: Ugh. coin.Equal now has a pointer receiver. So we can't do GetThing().Equal(GetOtherThing()). Gotta two-line it. * [1772]: Fix unused variable (commented out previously for a TODO). * [1772]: Fix updated use of query router func that now wants a reference to an abci.RequestQuery (instead of concrete). * [1772]: Comment out some wasm stuff that'll need fixing. * [1772]: Get rid of all the red squigglies in app.go by fixing several expected keepers and commenting out a ton of stuff. * [1772]: Remove some TODO things from error strings and replace them with 'not yet updated'. * [1772]: Standardize some of the TODO categories. * [1772]: Fix uses of LegacyZeroDec and LegacyOneDec (names changed to add Legacy to them). * [1772]: Remove uses of GetFeePool and SetFeePool since they're not just field things. * [1772]: Fix some of the stuff in app/test_helpers.go. * [1772]: Switch to our own ExitCode type (from server.ErrorCode which no longer exists). * [1772]: Clean up and update the MockCodec. * [1772]: Bump sdk to v0.50.2 (from v0.50.1) and pull in the rosetta library. * [1772]: Fix some command stuf. * [1772]: Drop back to v0.50.1 and comment out the rosetta thing since I was getting compilation errors on the SDK side with v0.50.2 which is needed for rosetta. * [1772]: Fix the testnet command. * [1772]: Remove unneeded import alias. * [1772]: Fix uses of MakeTestEncodingConfig in tests and also a lot of DeliverTx stuff is now commented out. * [1772]: Update the msgfees expected AccountKeeper. * [1772]: Make sim tests complile (and the other tests in the app dir too). * [1772]: Make all the tests in internal compile. * [1772]: Make all the cmd unit tests compile. * [1772]: Rename the ExitCodeError (was just ExitCode) to conform to conventions. * [1772]: Fix test compilations in the testutil dir. * [1772]: Fix all uses of sdkmath.LegacyNewDecWithPrec (used to be just NewDecWithPrec). * [1772]: Make the exchange unit tests compile. * [1772]: Fix an incorrect arg in fmt.Errorf in prepForZeroHeightGenesis. * [1772]: Hold test compilation fixes. * [1772]: Attribute test compilation fixes. * [1772]: ibchooks test compilation fixes. * [1772]: Metadata test compilation fixes. * [1772]: Trigger module test compilation fixes. * [1772]: Reward test compilation fixes. * [1772]: Oracle test compilation fixes. * [1772]: Name test compilation fixes. * [1772]: MsgFees test compilation fixes. * [1772]: ibc-rate-limit test compilation fixes. * [1772]: Marker test compilation fixes. * [1772]: Disable the provenanced version steps of the build/release github actions. * [1772]: Add a build/release step that builds the unit tests. * [1772]: Remove the build_osx test compilation since for some reason it takes twice as long as the unix one and the unix one is good enough there. * [1772]: Add changelog entry. * [1772]: Add categories to each of the TODOs and change a few. * [1772]: Delete the completely unused name querier types stuff. * [1772]: Delete a todo that I already took care of. * [1772]: Move the helpers package into internal and split it up a bit. The exit code went into the command stuff since that's all that used it. --------- Co-authored-by: AJ Webb <[email protected]>
* Add PreBlocker to app.go * Remove upgradetypes from BeginBlocker. * Add changelog entry.
* Remove unused databases. * Remove mention of other databases in Changelog. * Remove and update scripts for other databases. * Remove dbmigrate command and util. * Remove some references to cleveldb, badgerdb, and rocksdb. * Remove dbmigrate from Building.md. * Remove dbmigrate from Makefile and update workflows to remove other databses. * Remove dbmigrate from workflow, scripts, and other repo specific files. * Remove cleveldb frrom sims.yml * [1760]: Remove the db cache stuff from sims.yml since there's nothing left for it to cache anymore. --------- Co-authored-by: Daniel Wedul <[email protected]>
* Add changelog entry. * Add umber upgrade with crisis module store. * Add tests for umber. * Update app/upgrades_test.go Co-authored-by: Daniel Wedul <[email protected]> * Update app/upgrades.go Co-authored-by: Daniel Wedul <[email protected]> * Add rremoveInactiveValidatorDelegations to main upgrade handler. --------- Co-authored-by: Daniel Wedul <[email protected]>
* app.go account keeper * add bank keeper * add staking, mint, distr, slashing, crisis, feegrant keepers * refactor staking keeper property * add authz keeper * add app modules * fix broken test compile * Add gov keeper * refactor gov keeper init to reflect cosmos pattern * use provenance cosmos-sdk fork, add msg service router * TODO comment, update msg_service_router_test * fix another test * add register hybrid handler logic * todo async-icq * update third party protos * update proto-update-deps to use new proofs location * remove redundant delete * fix ibc version * update protos for library location updates * ica-host app.go todos * ibc-host app.go todo * few more ibc-host app.go todo * Add new cosmos-sdk tag for msg based fee support, add fee handler, add aggregate events function * add todo for issue that is blocking furture development * finish evidence todo * rename todo to line up with other proto todos * Update protobuf and point async-icq to our own version. Still need to figure out internal/tools and documentation for protos. * Add pulsar in case we need it. * Add pulsar script. * Remove pulsar until we need it. * Add swagger. * Update swagger. * Remove doc since it isn't needed. * Improve comment documentation in go.mod * Update statik.go * First changes towards any generation. * Remove make proto-gen-any. * Remove temporary work that was used for proto-gen-any. * Update phony to remove any. * Remove todo since protos are registering now. * Fix prefix address for tests. * Add WasmKeeper so tests can run. * Fix some wasm sim. Still need to resolve message router issues, and may require fork of wasmd. * Fix more wasm deprecations. Add ConsensusParamsKeeper. * Fix prefixes. * Fix validator address for tests. * Add keys for crisis module. * Add fix for ibc legacy param store. * remove use of deprecated authtypes AccountI and use sdk types AccountI * use protocompat.Handler instead of re-writing func sig * remove proofs.proto customization that isn't needed --------- Co-authored-by: Matthew Witkowski <[email protected]>
* Bump the SDK to v0.50.5-pio-1. * Add changelog entry.
# Conflicts: # .github/workflows/release.yml # .github/workflows/sims.yml # CHANGELOG.md # app/app.go # app/app_test.go # app/sim_test.go # app/test_helpers.go # app/upgrades.go # app/upgrades_test.go # client/docs/statik/statik.go # client/docs/swagger-ui/swagger.yaml # cmd/dbmigrate/utils/badgerdb.go # cmd/dbmigrate/utils/boltdb.go # cmd/dbmigrate/utils/cleveldb.go # cmd/dbmigrate/utils/migrator.go # cmd/dbmigrate/utils/migrator_test.go # cmd/dbmigrate/utils/rocksdb.go # cmd/provenanced/cmd/root.go # go.mod # go.sum # internal/handlers/msg_service_router_test.go # testutil/network.go # x/attribute/keeper/genesis_test.go # x/exchange/client/cli/cli_test.go # x/exchange/events_test.go # x/exchange/expected_keepers.go # x/exchange/keeper/export_test.go # x/exchange/keeper/fulfillment.go # x/exchange/keeper/fulfillment_test.go # x/exchange/keeper/keeper.go # x/exchange/keeper/market.go # x/exchange/keeper/market_test.go # x/exchange/keeper/mocks_test.go # x/exchange/keeper/msg_server_test.go # x/exchange/keeper/orders.go # x/exchange/keeper/params.go # x/exchange/keeper/suite_test.go # x/exchange/msg_test.go # x/exchange/params.pb.go # x/exchange/query.pb.go # x/hold/keeper/grpc_query.go # x/ibchooks/ibc_middleware_test.go # x/ibcratelimit/module/ibc_middleware_test.go # x/marker/client/cli/tx.go # x/marker/keeper/keeper.go # x/marker/keeper/keeper_test.go # x/marker/keeper/proposal_handler_test.go # x/marker/keeper/send_restrictions_test.go # x/marker/types/authz_test.go # x/marker/types/send_restrictions_test.go # x/marker/types/tx.pb.go # x/metadata/client/cli/cli_test.go # x/metadata/client/cli/tx.go # x/metadata/keeper/scope_test.go # x/metadata/types/query.pb.go # x/metadata/types/scope.pb.go
Merge branch 'main' into main-v0.50
…1900) * Create the build-tests make target. * Add a github action that just builds the tests. * Add a warning and delay to the build make target. * Tweak the warning to just say this branch instead of specifying one.
… to protos txs (#1873) * add chain-id to setup to prevent assert failure in chain Init() * start updating finalize block tests, fixing signing * add pub key * add address to signing * add address decoders, update test events * check the tx events * fix a few more tests, remove debug file * update git ignore for debug files * minor refactors * add assess custom msg fee custom signer field * add custom signers to rewards proto * add new sdk * add back event history and simulate function context return * use SimulateProv instead of Simulate * gen rewards pb.go with custom signing option * add gov legacy router * update with new cosmos-sdk tag * Update all tests to use finalize block, add latest proposal walk * fix marker protos and add custom signers * update bank send restriction test with finalize block * add custom signers to attribute protos * remove unneeded begin block since we use SimDeliver instead of Deliver, Unmarshal proto unstead of json, change route to module name for successful * remove begin block from ibcratelimit test, fix route check, unmarshal instead of unmarshaljson * remove begin block from marker test, fix route check, unmarshal instead of unmarshaljson * remove begin block from name test, fix route check, unmarshal instead of unmarshaljson * remove begin block from trigger test, fix route check, unmarshal instead of unmarshaljson * remove begin block from reward test, fix route check, unmarshal instead of unmarshaljson * remove begin block from oracle test, fix route check, unmarshal instead of unmarshaljson * update weighted operation tests * remove todos * proto update * finish up SimulateFromSeed event-history todo * fix reward periods for tests * fix reward vote rules for new event structure * move sleep in test * fix simulate from seed * fix assert * remove un need return
* Verified streaming service change is identical to what we had before. * Update CHANGELOG.
* Update changelog. * Convert send_restrictions_test to not use handler. Start moving tests over to keeper. * migrate msgdeleteaccess test over. * Move more tests over to msg_server tests. * More converted tests. * Finish migrating handler to message server for marker. * Update msgfees to have todos for gov migration. * Remove handler from attribute module. * Migrate tests to msgserver for name module. * Remove handler and migrate tests for metadata. * Remove queriers that are no longer needed.
* Modify changelog. * Add skeleton for ibc upgrade. * Add logic for v7 upgrade. * Add param migration. * Add upgrades for ibcv8 and add logging. Updated umber tests as well * Remove ModuleBasics, and migrate ibc params. * Update changelog to account for ModuleBasics. * Fix typo in changelog. * Add signing options. * Add finalize block to make test pass and help ensure encoder/decoders are working. * Fix remaining test in app_test.go * Remove replace comment for ibc-go dependency. * Remove commented out code. * Update interfaces for modules.
|
Important Auto Review SkippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 182 files out of 298 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
nullpointer0x00
approved these changes
Apr 5, 2024
Taztingo
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges the
main-v0.50branch intomain.This will cause
mainto be unstable for a while, until we can finish all of the upgrade work. But it allows dependabot and coderabbit to also help contribute to that work.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes