Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rewards Module #1906

Closed

Conversation

nullpointer0x00
Copy link
Contributor

Description

closes: #1905


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 added this to the v1.19.0 milestone Apr 4, 2024
Copy link
Contributor

coderabbitai bot commented Apr 4, 2024

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nullpointer0x00
Copy link
Contributor Author

@coderabbitai list all the tests that were removed in internal/handlers/msg_service_router_test.go

Copy link
Contributor

coderabbitai bot commented Apr 4, 2024

Tip

For best results, initiate chat on the files or code changes.

@nullpointer0x00, after running the scripts to compare the tests in internal/handlers/msg_service_router_test.go before and after the last commit, it appears there were no tests removed. This means all previously existing tests are still present in the file as of the latest commit. If you have any more requests or need further assistance, feel free to ask!

Analysis chain
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Find the commit hash of the previous change to msg_service_router_test.go
commit_hash=$(git log -n 1 --pretty=format:"%H" -- internal/handlers/msg_service_router_test.go)

# Show the names of tests removed in the last commit affecting msg_service_router_test.go
git show $commit_hash:internal/handlers/msg_service_router_test.go | grep -oP 'func Test\K\w+' > before_tests.txt
git show HEAD:internal/handlers/msg_service_router_test.go | grep -oP 'func Test\K\w+' > after_tests.txt
comm -23 before_tests.txt after_tests.txt

Length of output: 467



Script:

#!/bin/bash
# Find the commit hash of the previous change to msg_service_router_test.go
commit_hash=$(git log -n 1 --pretty=format:"%H" -- internal/handlers/msg_service_router_test.go)

# Extract the names of tests from the file in the specified commit and the current HEAD, then compare them
git show $commit_hash:internal/handlers/msg_service_router_test.go | grep -oP 'func Test\K\w+' > before_tests.txt
git show HEAD:internal/handlers/msg_service_router_test.go | grep -oP 'func Test\K\w+' > after_tests.txt
diff --new-line-format="" --unchanged-line-format="" before_tests.txt after_tests.txt

Length of output: 435

@nullpointer0x00 nullpointer0x00 changed the title remove reward module, reward protos, and tests Remove Rewards Module Apr 4, 2024
@nullpointer0x00 nullpointer0x00 changed the base branch from main-v0.50 to main April 8, 2024 14:38
@nullpointer0x00
Copy link
Contributor Author

Moved to different branch.

@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/1905-remove-rewards-module branch April 8, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Remove Rewards Module
1 participant