Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'main' into main-v0.50 #1899

Merged
merged 69 commits into from
Apr 2, 2024
Merged

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Apr 2, 2024

Description

This merges main at 97e71a02: Mark v1.18.0 in the changelog. (#1892) into our main-v0.50 branch.

When it comes time to merge this, we'll want to do it as a merge commit (not a squash and merge). So, when it comes time to merge, we'll want to temporarily alter repo settings to allow that, then do that with this PR and change the setting back.

If this PR is squashed into main-v0.50 then git looses track of things and ends up reporting almost everything as a conflict when merging that back into main. By using a merge commit for this (into main-v0.50), the ultimate merge back to main will be much easier on us.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

webbushka and others added 30 commits December 1, 2023 16:11
* Updates to verbiage and reorder the sidebar

* Add backticks to ibcratelimit title

* Update verbiage in readme

* Removing all the page metadata as it's not needed with moving to alphabetical order only
* Remove the rust upgrades and its stuff.

* Call removeInactiveValidatorDelegations in the tourmaline upgrades.

* Add a TODO on addMarkerNavs to delete it with saffron.

* Add changelog entry.
* Bump actions/setup-java from 3 to 4

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Wedul <[email protected]>
* Bump github.com/spf13/cast from 1.5.1 to 1.6.0

Bumps [github.com/spf13/cast](https://github.com/spf13/cast) from 1.5.1 to 1.6.0.
- [Release notes](https://github.com/spf13/cast/releases)
- [Commits](spf13/cast@v1.5.1...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cast
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ira Miller <[email protected]>
* Bump actions/setup-go from 4 to 5

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ira Miller <[email protected]>
* Bump github.com/spf13/viper from 1.17.0 to 1.18.0

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.17.0 to 1.18.0.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.17.0...v1.18.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ira Miller <[email protected]>
* Bump github.com/google/uuid from 1.4.0 to 1.5.0

Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/google/uuid/releases)
- [Changelog](https://github.com/google/uuid/blob/master/CHANGELOG.md)
- [Commits](google/uuid@v1.4.0...v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/google/uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ira Miller <[email protected]>
* Bump github/codeql-action from 2 to 3

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ira Miller <[email protected]>
* Bump google.golang.org/protobuf from 1.31.0 to 1.32.0

Bumps google.golang.org/protobuf from 1.31.0 to 1.32.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ira Miller <[email protected]>
* Bump github.com/dvsekhvalnov/jose2go from 1.5.0 to 1.6.0

Bumps [github.com/dvsekhvalnov/jose2go](https://github.com/dvsekhvalnov/jose2go) from 1.5.0 to 1.6.0.
- [Commits](dvsekhvalnov/jose2go@v1.5...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/dvsekhvalnov/jose2go
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ira Miller <[email protected]>
* Bump google.golang.org/grpc from 1.59.0 to 1.60.1

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.59.0...v1.60.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Bump golang.org/x/crypto from 0.14.0 to 0.17.0

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](golang/crypto@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

* update upload-artifact to matching v4

Note: It seems like there may be a compatability issue with only updating download or upload independently so try to update them together.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ira Miller <[email protected]>
Co-authored-by: Ira Miller <[email protected]>
* Bump github.com/spf13/viper from 1.18.0 to 1.18.2

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.18.0 to 1.18.2.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.18.0...v1.18.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Create store_loader with wrappers, and update main to use them.

* Skeleton for tests.

* Add tests for wrap store loader.

* Clean up text and example code.

* Add tests for pruning wrapper.

* Add comments.

* Update CHANGELOG.

* Lint fixes.

* Set MaxPruningInterval to number supplied by discord.

* Remove accidental pushed files.

* Fix casting.

* Change goleveldb to memdb in tests to prevent directories from being created.

* Lint fix.

* Change interval max.

* Update message to include wait time.

* Separate onto new log line.

* Add check for indexer and update tests.

* Remove accidental binaries.

* Update changelog to reflect not just pruning interval.

* Add check for database.

* Add check for disable-iavl-fastnode.

* Tidy by updating changelog, names, and dependencies.
* Add prefix key for getting entries by marker. Add ClearSendDeny and GetSendDenyList to easily obtain and remove from list.

* Add DenySendMarkerPrefix.

* Add tests for previously existing functions add and remove.

* Fix empty list bug in GetSendDenyList, and add tests.

* Add test for ClearSendDeny.

* Add checks for send deny list in tests that verify removal.

* Add changelog entry.
* Bump wasmvm to v1.2.6 (from v1.2.4).

* Add changelog entry.

* Move the changelog entry to the correct section, and have it reference the issue.

* Bump wasmd to v0.30.0-pio-6 (from v0.30.0-pio-5).
* Update command to do nothing, and update long help text to redirect user.

* Update changelog.

* Update tests to say that each previous command fails.

* Add linting fix.

---------

Co-authored-by: Daniel Wedul <[email protected]>
* Don't issue a warning on start when the indexer is the string 'null'. That's what the config file says to use.

* Set the default iavl-disable-fastnode to false and the default tx_index.indexer to 'null'.

* Add Changelog entry.

* Add unit test for no wait for an indexer of 'null'.
* Bump cosmossdk.io/errors from 1.0.0 to 1.0.1

Bumps [cosmossdk.io/errors](https://github.com/cosmos/cosmos-sdk) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@log/v1.0.0...math/v1.0.1)

---
updated-dependencies:
- dependency-name: cosmossdk.io/errors
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Wedul <[email protected]>
* Copy v1.17.1 section from release/v1.17.x.

* Remove the 1.17.1 entries from unreleased.

* Move the just updated cosmossk.io/errors entry back to unlrelease (the merge put it under v1.17.1).
…ar. (#1810)

* Tweak the store loader config warning stuff a bit to make the tests not actually do the sleeps. Also allow bypassing the sleep via env var. Standardize some of the buffered logger stuff too.

* Add changelog entry.

* Fix imports in app/store_loader_test.go.

* Move the buffered logger to internal because the rosetta stuff needed it (was included in the non-unit-test-only app/test_helpers.go file) but couldn't get it because it wasn't part of accessible stuff.
* Update CHANGELOG.

* Update protos to use mills and update cli.

* Update links in spec.

* Update types and constructors to use UsdMills rather than UsdCents.

* Fix added header.

* Revert flag usage to previous example since it was correct.

* Fix typo in changelog.

* Move changelog entry to bugs.

* Add usd_cents and deprecate it.

* Update links in spec to include deprecated field.

* Additional renaming of cents to mills.
* Bump actions/cache from 3 to 4

Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Bump github.com/google/uuid from 1.5.0 to 1.6.0

Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/google/uuid/releases)
- [Changelog](https://github.com/google/uuid/blob/master/CHANGELOG.md)
- [Commits](google/uuid@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/google/uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Add CHANGELOG entry.

* Add function to get marker addr from key.

* Add conversion func to upgrade handler, and an iterate all function to marker keeper.

* Update changelog entry.

* Add tests for upgrade.

* Add test for upgrade.

* Add test for GetMarkerFromNetAssetValue and fix bug.

* Add additional test case for ConvertNAVUnits.

* Add test for IterateAllNetAssetMarkers.

* Add error checks.
* Bump google.golang.org/grpc from 1.60.1 to 1.61.0

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.60.1 to 1.61.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.60.1...v1.61.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* add filtering of nil events from begin blocker

* Add tests and refactor function

* add comments

* fix lint
* Add permission checker to see if an account is part of a group for marker transfers.

* Bump github.com/google/uuid from 1.5.0 to 1.6.0 (#1819)

* Bump github.com/google/uuid from 1.5.0 to 1.6.0

Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/google/uuid/releases)
- [Changelog](https://github.com/google/uuid/blob/master/CHANGELOG.md)
- [Commits](google/uuid@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/google/uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>

* Update changelog entry.

* Add temporary logic that checks if an address is part of a groups module.

* Fix bug in temporary test code. This solution fixes the issue brought up.

* Rename interface to GroupChecker.

* Move GroupChecker into group.go

* Move group related functions to group.go

* Add test for nil address and add tests for TestIsGroupAddress.

* Add test for NewGroupChecker.

* Add keeper test for canForceTransferFrom for group.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* add nav protos to metadata module for scopes

* refactor proto, add scope-id to add nav tx

* add validations, add msg interface

* add nav key

* add keeper methods, update typed event

* add usd_mils and volume to write scope

* add net asset value keeper call to msg server

* add nav when writing scope

* add new parameters to write scope msg, add command line flags for usd mils and volume, update tests

* add genesis navs

* add change log

* rename mils to mills, add net asset values command

* change some naming, add validate basic tests, cmdline test

* fix property name

* add validation test

* add msg server test, remove check of scope id, move metadata app initialization

* add scope net asset value query

* fix test

* add better error handling

* remove unneeded check, add tests for keeper

* Add ParseNetAssertValueString test

* add query server tests

* add more tests, refactor method name

* fix test

* fix marker references for scope, fix a few missed mils to mills

* ugh missed test assert

* fix proto doc

* remove volume from scope net asset value, update code and tests, add remove nav logic to scope remove call
SpicyLemon and others added 24 commits February 16, 2024 13:58
…s. (#1835)

* [1834]: Add tourmaline-rc2 upgrade handler since I'm about to make a state-breaking change that'll require an upgrade.

* [1834]: Add context functions for passing in the transfer agent.

* [1834]: Pay attention to the newly available transfer agent in the send restriction. Move the deposit check to SendRestrictionFn (from validateSendDenom) since don't need to repeat that check for every denom. Add a check for withdraw on the from addr since that might now be a marker account. Tweak a couple error messages to distinguish them from eachother. In the transfer endpoint, if the destination is also a marker, check for deposit access on that marker.

* [1834]: Switch the TestAccountKeeperMintBurnCoins fix to provide the transfer agent instead of just bypassing the send restrictions.

* [1834]: If no force transfer, and coming from a marker, make sure the admin has withdraw on that marker. Unit tests on the TransferCoin function.

* [1834]: Unit tests on the send restriction function.

* [1834]: Set the transfer agent in the exchange stuff that does bank stuff.

* [1834]: Fix the unit tests that broke and add a couple new ones.

* [1834]: tiny tweak to a couple unit tests.

* [1834]: In AddSetNetAssetValues, emit the nav event even when the price denom's marker isn't found.

* [1834]: Tweak TestKeeper_WithdrawMarketFunds again to make it a little easier on test setup.

* [1834]: lint (kind of since it's in a test file that isn't linted, but whatever).

* [1834]: Add access validator functions to the marker to standardize the errors when an address doesn't have a certain role.

* [1834]: Remove redundant 'access' from error about not having access (the enum name starts with ACCESS_).

* [1834]: Standardize the no-access errors. In WithdrawCoins, if going to a marker, make sure they've got deposit on that marker. Require a marker to be active in ordr to send its funds.

* [1834]: Update TransferCoin. Add comment above authzHandler with the reason we don't check for withdraw and remove the check for withdraw.

* [1834]: Fix the error in validateSendDenom for sends to a marker to reference the correct denom and address.

* [1834]: Fix the tests that broke because I changed the error messages.

* [1834]: Update AddSetNetAssetValues. Try all entries even if an earlier one has an error. If the price marker does not exist, only emit the event if the nav is valid. Put some unit tests on that thing.

* [1834]: Add unit test on send restriction when we can't get attributes.

* [1834]: Fix some comments in the mocks, add a unit test making sure force-transfer access is ignored in the send restriction, and add force transfer to a couple access unit tests.

* [1834]: Update marker spec docs with all the recent chagnes.

* [1834]: For the exchange stuff, pay attention to blocked addresses in the off-chance one gets used.

* [1834]: Check that a marker is active before allowing a transfer.

* [1834]: In WithdrawCoins, make sure the recipient is not a bank blocked address.

* [1834]: Some tweaks to the spec docs to fix some typos, grammer, and flowchart stuff.

* [1834]: Redo the flows so that denied is on the left for all of them. Add some links between flows.

* [1834]: Fix the names of a bunch of keeper unit tests that claim to be testing account stuff.

* [1834]: Unit tests on WithdrawCoins and on Transfer of non-active coins.

* [1834]: Fix unit tests on WithdrawMarketFunds that broke because a call to BlockedAddr is now being made that wasn't expected previously. Add test for when the address is blocked.

* [1834]: Fix TestKeeper_SettleCommitments that broke because of the added calls to BlockedAddr that weren't previously expected.

* [1834]: Fix TestKeeper_DoTransfer that broke because we added calls to BlockedAddr that weren't listed as expected. Add a test for when an address is blocked.

* [1834]: Fix TestKeeper_SettleOrders that broke when I added calls to BlockedAddr.

* [1834]: Fix the FillAsks and FillBids unit tests that broke when I started calling BlockedAddr.

* [1834]: Remove TODO that's TODONE (unit tests on blocked addresses).

* [1834]: Update the exchange spec docs to include stuff about the transfer agent as well as a commitment settlement fee calc example.

* [1834]: Add changelog entries.
…#1846)

* [1845]: Update the marker SendRestrictionFn to not allow restricted coins to be sent to the fee collector account.

* [1845]: Add changelog entry.

* [1845]: Fix some exchange unit tests that broke because they were using restricted coins for the fees.

* [1845]: Update marker spec doc flowcharts.
* Bump cosmos-sdk to v0.46.13-pio-3 (from v0.46.13-pio-2).

* Add changelog entry.
…e. (#1852)

* Make sure the store loader isn't nil.

* Add changelog entry.
* Allow force transfers out of marker and market accounts.

* Add some test cases for marker and market accounts with canForceTransferFrom.

* Add changelog entry.

* Tweak TestCanForceTransferFrom a little based on coderabbit feedback. Namely, have the account creators take in a string to use for the addr instead of the full address that it's going to just turn around and return.

* Lint fix (needed extra empty line in keeper/marker.go).
Bumps [cosmossdk.io/math](https://github.com/cosmos/cosmos-sdk) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@log/v1.2.0...log/v1.3.0)

---
updated-dependencies:
- dependency-name: cosmossdk.io/math
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v6.0.0...v6.0.1)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carlton N Hanna <[email protected]>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.1 to 1.62.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.61.1...v1.62.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ira Miller <[email protected]>
* Fix MarkerTransferAuthorization validation to make sure the limit is valid Coins and the addresses in the allow list are valid.

* Add changelog entry.
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.5.3 to 1.5.4.
- [Release notes](https://github.com/golang/protobuf/releases)
- [Commits](golang/protobuf@v1.5.3...v1.5.4)

---
updated-dependencies:
- dependency-name: github.com/golang/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.62.0 to 1.62.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.62.0...v1.62.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.4...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Switch the changelog action to use activationLabels (instead of the deprecated and maybe broken activationLabel).

* Updated Changelog

* Fix placement of new Dependencies section in the changelog.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Wedul <[email protected]>
Co-authored-by: SpicyLemon <[email protected]>
* [1703]: Update proto stuff to have all the paymen stuff and stuff.

* [1703]: Stub out all the msg server, query server, and msg methods.

* [1703]: Create the Payment.Validate() method and tweak ValidateExternalID to not contain the entire external id when it's too long.

* [1703]: Create Payment.String() so that things can compile

* [1703]: Fix unit tests that broke because I change the external id too-long error message.

* [1703]: Set some default payment fee param values and add validation checks on the new fields. Write the state store stuff for the new entries.

* [1703]: Add some payment fee consumer stuff.

* [1703]: Put the params key strings in some constants and fix a couple params-related unit tests that broke with recent changes.

* [1703]: Payment validation and hopefully an improvement on the Payment.String() method. Unit tests on those too.

* [1703]: New msg validation funcs and their unit tests.

* [1703]: Add some params test cases to cover new keeper stuff.

* [1703]: Create key stuff for payments.

* [1703]: Unit tests on the target to payment index key creators.

* [1703]: Rename the target to payments index key prefix makers to include the word 'Key'.

* [1703]: Write most of the payment stuff in the keeper and fill out the msg server endpoint methods.

* [1703]: Fill in the query endpoint methods.

* [1703]: Add payments to the geneis doc.

* [1703]: Add validation to genesis payments. Add payments to genesis import and export. Unit test on that stuff too.

* [1703]: Add some payment-related events to the protos.

* [1703]: Constructors for the new events and emit them when doing keeper stuff.

* [1703]: Unit tests on the new event constructors.

* [1703]: Unit tests on the GetPayment and CreatePayment keeper methods.

* [1703]: Fix AcceptPayment to correctly release the hold on the payment before trying to move funds.

* [1703]: Update RejectPayments to check for at least one source.

* [1703]: AcceptPayment, tweak the errors a tiny bit and use the existing record for the sends and stuff. In RejectPayment, require a target and source, and make sure the existing target isn't empty.

* [1703]: Unit tests on AcceptPayment and RejectPayment.

* [1703]: In RejectPayment: return an error if the target is empty and skip duplicated source entries. In CancelPayments: return an error if the source is empty and skip duplicated external ids.

* [1703]: Unit tests on RejectPayments and CancelPayments.

* [1703]: Update CancelPayments to use requirePaymentFromStore and improve the same-target error when it's empty.

* [1703]: Unit tests on UpdatePaymentTarget. In all the payment keeper tests, check that the payments and index entries match.

* [1703]: Maintain the ordering of the fee entries in params when they're being read out of state.

* [1703]: Unit test on the GetPaymentsForTargetAndSource, IteratePayments, and CalculatePaymentFees keeper funcs.

* [1703]: Consume the commitment settlment fee only if the settlement succeeds.

* [1703]: In RejectPayments, include the sources index in the error message. In ChangePaymentTarget, allow the new target to be empty.

* [1703]: Unit tests on the msg server endpoints.

* [1703]: In the GetPayment query endpoint, ignore any error that comes back from GetPayment and treat it like that payment doesn't exist.

* [1703]: Unit tests on the new query endpoints.

* [1703]: Add TODOs for the CLI stuff and spec stuff.

* [1703]: For the genaccounts tests, fix empty stuff related to payments.

* [1703]: Fix a couple CLI unit tests that were failing because of the added fields in Params.

* [1703]: Add a bunch of TODOs for the CLI stuff.

* [1703]: Create the payment tx CLI Stuff.

* [1703]: Add payment queries to CLI.

* [1703]: Unit tests on the new flags stuff.

* [1703]: Make it possible to include an empty string in the external ids of the CancelPayments command. Require a source in RejectPayment. Require either from or source with ChangePaymentTarget. Unit tests on all the tx setup funcs.

* [1703]: In the setup tests, ensure that each of the expected flags also appears in the command's Use.

* [1703]: Make a reusalbe use string for indicating there are pagination flags. Make the external id optional in MakeQueryGetPayment. Unit tests on the new query CLI setup stuff.

* [1703]: Update the cli test suite setup to include a bunch of payments.

* [1703]: Make the GetPayment query return an error if the payment isn't found.

* [1703]: Unit tests on the CreatePayment command.

* [1703]: Unit tests on the rest of the tx commands.

* [1703]: Add a 'no results' test case to the GetPaymentsWithSource and GetPaymentsWithTarget keeper unit tests.

* [1703]: Unit tests on the query commands.

* [1703]: Fix the names of the payment keeper unit tests.

* [1703]: Add payments to state, messages, events, queries, and params spec docs.

* [1703]: Update the line numbers in all the proto links in the spec docs.

* [1703]: Standardize the empty lines before headers in the concepts spec doc.

* [1703]: Add payments to the concepts spec doc.

* [1703]: Create the tourmaline-rc3 upgrade to set the new exchange params relating to payments.

* [1703]: Add changelog entries.

* [1703]: Add some missing function comments in the cli test helpers.

* [1703]: Fix typo in the CmdQueryGetPayment Short.

* [1703]: Tweak the new payments concepts spec docs to clarify some stuff.

* [1703]: Remove line that was accidentally added to runMsgServerTestCase, but didn't do anything.

* [1703]: Add an expected log entry to TestTourmaline indicating that the payment params are being set.

* [1703]: Add comment to parsePaymentStoreValue indicating that nil, nil is returned when the value is empty (or nil).

* [1703]: Remove the AddressString decoration from a couple external id proto fields.

* [1703]: Change default exchange payment params to 10hash to create and 8hash to accept.

* [1703]: Add some logging to the queries to help identify issues when there are any.

---------

Co-authored-by: Ira Miller <[email protected]>
* Bump bufbuild/buf-setup-action from 1.29.0 to 1.30.0

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.29.0 to 1.30.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.29.0...v1.30.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ira Miller <[email protected]>
#1870)

* Use activationLabels (instead of the deprecated activationLabel) in the changelog github action.

* Add dependabot changelog entries that were missed previously.

* Add missing # from a changelog entry link.

* Undo the changelog github action change and let it be done in a different PR.

* Combine the Dependencies sections (for some reason the merge from main didn't go as expected and it ended up with two).
* Bump peter-evans/create-pull-request from 6.0.1 to 6.0.2

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v6.0.1...v6.0.2)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
…om v0.46.13-pio-3). (#1874)

* Switch to github.com/cometbft/cometbft-db (from github.com/tendermint/tm-db).

* Remove disable-iavl-fastnode warning.

* Bump cosmos-sdk to v0.46.13-pio-4 (from v0.46.13-pio-3). Bump ibc-go to v6.2.0-pio-2 (from v6.2.0-pio-1). Bump wasmd to v0.30.0-pio-7 (from v0.30.0-pio-6).

* Add changelog entries.

* Add a couple more changelog entries.

* Add cometbft-db to the list of allowed imports.

* Lint fix: Fix some import orderings.
* add denom to nav pricing data method

* add testnet navs to upgrade handler rc3

* comment out negative price, keep as reference

* add upgrade handler

* remove negative value marker

* add change log
* Remove the NAV restriction that volume is at most the supply.

* Fix an exchange unit test that started to fail because the NAV is now being recorded, which takes more gas.

* Add changelog entry.
… of pricing timestamp (#1888)

* add nav setting method to update block height

* add new updates struct for navs, add recent navs

* add upgrade nav setter

* call upgrade nav adding funtion upgrade for v1.18.0

* add tests, add todo for removal

* change marker names

* fix test

* add changelog entry

* remove nhash from list

* fix final test error
# Conflicts:
#	.github/workflows/release.yml
#	.github/workflows/sims.yml
#	CHANGELOG.md
#	app/app.go
#	app/app_test.go
#	app/sim_test.go
#	app/test_helpers.go
#	app/upgrades.go
#	app/upgrades_test.go
#	client/docs/statik/statik.go
#	client/docs/swagger-ui/swagger.yaml
#	cmd/dbmigrate/utils/badgerdb.go
#	cmd/dbmigrate/utils/boltdb.go
#	cmd/dbmigrate/utils/cleveldb.go
#	cmd/dbmigrate/utils/migrator.go
#	cmd/dbmigrate/utils/migrator_test.go
#	cmd/dbmigrate/utils/rocksdb.go
#	cmd/provenanced/cmd/root.go
#	go.mod
#	go.sum
#	internal/handlers/msg_service_router_test.go
#	testutil/network.go
#	x/attribute/keeper/genesis_test.go
#	x/exchange/client/cli/cli_test.go
#	x/exchange/events_test.go
#	x/exchange/expected_keepers.go
#	x/exchange/keeper/export_test.go
#	x/exchange/keeper/fulfillment.go
#	x/exchange/keeper/fulfillment_test.go
#	x/exchange/keeper/keeper.go
#	x/exchange/keeper/market.go
#	x/exchange/keeper/market_test.go
#	x/exchange/keeper/mocks_test.go
#	x/exchange/keeper/msg_server_test.go
#	x/exchange/keeper/orders.go
#	x/exchange/keeper/params.go
#	x/exchange/keeper/suite_test.go
#	x/exchange/msg_test.go
#	x/exchange/params.pb.go
#	x/exchange/query.pb.go
#	x/hold/keeper/grpc_query.go
#	x/ibchooks/ibc_middleware_test.go
#	x/ibcratelimit/module/ibc_middleware_test.go
#	x/marker/client/cli/tx.go
#	x/marker/keeper/keeper.go
#	x/marker/keeper/keeper_test.go
#	x/marker/keeper/proposal_handler_test.go
#	x/marker/keeper/send_restrictions_test.go
#	x/marker/types/authz_test.go
#	x/marker/types/send_restrictions_test.go
#	x/marker/types/tx.pb.go
#	x/metadata/client/cli/cli_test.go
#	x/metadata/client/cli/tx.go
#	x/metadata/keeper/scope_test.go
#	x/metadata/types/query.pb.go
#	x/metadata/types/scope.pb.go
@SpicyLemon SpicyLemon requested a review from a team as a code owner April 2, 2024 18:42
Copy link
Contributor

coderabbitai bot commented Apr 2, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SpicyLemon SpicyLemon merged commit 0bd746c into main-v0.50 Apr 2, 2024
18 of 29 checks passed
@SpicyLemon SpicyLemon deleted the dwedul/v50-merge-main-1 branch April 2, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants