-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODOs finalize-block, event-history, signing,add cosmos.msg.v1.signer to protos txs #1873
TODOs finalize-block, event-history, signing,add cosmos.msg.v1.signer to protos txs #1873
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…r, Unmarshal proto unstead of json, change route to module name for successful
… instead of unmarshaljson
…ad of unmarshaljson
… of unmarshaljson
…ead of unmarshaljson
…ad of unmarshaljson
…ad of unmarshaljson
Description
This PR finished up the finalize-block, event-history, and signing TODOS.
The
cosmos.msg.v1.signer
was needed for the protos to work. However, I will add another TODO to our list for removing GetSigners() from the message types.While doing the finalize-block TODOs, the rewards vote tally rules broke due to events changing. I have fixed that in this PR.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes