Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs finalize-block, event-history, signing,add cosmos.msg.v1.signer to protos txs #1873

Merged
merged 40 commits into from
Apr 3, 2024

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Mar 15, 2024

Description

This PR finished up the finalize-block, event-history, and signing TODOS.

The cosmos.msg.v1.signer was needed for the protos to work. However, I will add another TODO to our list for removing GetSigners() from the message types.

While doing the finalize-block TODOs, the rewards vote tally rules broke due to events changing. I have fixed that in this PR.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

coderabbitai bot commented Mar 15, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nullpointer0x00 nullpointer0x00 self-assigned this Mar 28, 2024
@nullpointer0x00 nullpointer0x00 changed the title TODOs finalize-block TODOs finalize-block, event-history Apr 1, 2024
@nullpointer0x00 nullpointer0x00 changed the title TODOs finalize-block, event-history TODOs finalize-block, event-history, add cosmos.msg.v1.signer to protos txs Apr 1, 2024
@nullpointer0x00 nullpointer0x00 mentioned this pull request Apr 2, 2024
@nullpointer0x00 nullpointer0x00 changed the title TODOs finalize-block, event-history, add cosmos.msg.v1.signer to protos txs TODOs finalize-block, event-history, signing,add cosmos.msg.v1.signer to protos txs Apr 2, 2024
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review April 2, 2024 17:18
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner April 2, 2024 17:18
app/sim_bench_test.go Outdated Show resolved Hide resolved
Taztingo
Taztingo previously approved these changes Apr 2, 2024
@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) April 3, 2024 18:08
@nullpointer0x00 nullpointer0x00 requested a review from Taztingo April 3, 2024 18:09
@nullpointer0x00 nullpointer0x00 merged commit d72b319 into main-v0.50 Apr 3, 2024
18 of 30 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/todo-1760-finalize-block branch April 3, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants