-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protos, documentation, and naming for NAVs #1814
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1814 +/- ##
=======================================
Coverage 73.97% 73.97%
=======================================
Files 315 315
Lines 44772 44772
=======================================
Hits 33120 33120
Misses 10271 10271
Partials 1381 1381
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks, I have mils instead of mills in my scope branch. I will change that...
We need to do a upgrade handler PR to fix and update prices of the navs that are in cents from last upgrade.
Description
Updates the protos, documentation, and naming to use millis for NAVs.
closes: #1813
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes