Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protos, documentation, and naming for NAVs #1814

Merged
merged 11 commits into from
Jan 17, 2024

Conversation

Taztingo
Copy link
Contributor

Description

Updates the protos, documentation, and naming to use millis for NAVs.

closes: #1813


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@Taztingo Taztingo self-assigned this Jan 16, 2024
@Taztingo Taztingo added this to the v1.18.0 milestone Jan 16, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ec697ce) 73.97% compared to head (29ba5d5) 73.97%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1814   +/-   ##
=======================================
  Coverage   73.97%   73.97%           
=======================================
  Files         315      315           
  Lines       44772    44772           
=======================================
  Hits        33120    33120           
  Misses      10271    10271           
  Partials     1381     1381           
Files Coverage Δ
x/marker/keeper/msg_server.go 42.05% <100.00%> (ø)
x/marker/types/msg.go 52.59% <100.00%> (ø)
x/marker/client/cli/tx.go 62.32% <85.71%> (ø)

@Taztingo Taztingo marked this pull request as ready for review January 17, 2024 16:22
@Taztingo Taztingo requested a review from a team as a code owner January 17, 2024 16:22
@Taztingo Taztingo enabled auto-merge (squash) January 17, 2024 16:22
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, I have mils instead of mills in my scope branch. I will change that...

We need to do a upgrade handler PR to fix and update prices of the navs that are in cents from last upgrade.

@Taztingo Taztingo merged commit f464053 into main Jan 17, 2024
42 checks passed
@Taztingo Taztingo deleted the taztingo/1813-nav-millis branch January 17, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Update nav protos and documentation to use millis
3 participants