Exchange Commitments #1812
Merged
Exchange Commitments #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the new commitments proto.
…d fee managment msgs.
…to commitment settlements). Really, I just wanted to shorten that name up. Ugh.
…the NetAssetPrice struct.
Taztingo
previously approved these changes
Jan 29, 2024
Taztingo
reviewed
Jan 29, 2024
Taztingo
reviewed
Jan 29, 2024
Taztingo
reviewed
Jan 29, 2024
Taztingo
reviewed
Jan 29, 2024
Taztingo
reviewed
Jan 29, 2024
Taztingo
reviewed
Jan 29, 2024
Taztingo
reviewed
Jan 29, 2024
Taztingo
reviewed
Jan 29, 2024
…arketUpdateAcceptingOrders endpoint section.
nullpointer0x00
previously approved these changes
Jan 29, 2024
…o tweak a couple sentences for clarity.
SpicyLemon
dismissed stale reviews from nullpointer0x00 and Taztingo
via
7d4df4c
… that was panicing with an index out of bounds because there's only 3 attributes.
…ng the exchange module) and regenerate it all.
Taztingo
previously approved these changes
Jan 29, 2024
Taztingo
approved these changes
Jan 29, 2024
iramiller
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it possible for funds to be committed to a market for use in an off-chain order book.
Closes: #1789
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes