Allow bypassing the new warning wait period through PIO_ACKWARN env var. #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot actually do the sleeps. Also allow bypassing the sleep via env var. Standardize some of the buffered logger stuff too.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1810 +/- ##
=======================================
Coverage 73.97% 73.97%
=======================================
Files 315 315
Lines 44764 44772 +8
=======================================
+ Hits 33114 33120 +6
- Misses 10269 10271 +2
Partials 1381 1381
|
… it (was included in the non-unit-test-only app/test_helpers.go file) but couldn't get it because it wasn't part of accessible stuff.
Taztingo
approved these changes
Jan 12, 2024
iramiller
approved these changes
Jan 12, 2024
SpicyLemon
added a commit
that referenced
this pull request
Jan 12, 2024
…ar. (#1810) * Tweak the store loader config warning stuff a bit to make the tests not actually do the sleeps. Also allow bypassing the sleep via env var. Standardize some of the buffered logger stuff too. * Add changelog entry. * Fix imports in app/store_loader_test.go. * Move the buffered logger to internal because the rosetta stuff needed it (was included in the non-unit-test-only app/test_helpers.go file) but couldn't get it because it wasn't part of accessible stuff.
Merged
8 tasks
SpicyLemon
added a commit
that referenced
this pull request
Jan 12, 2024
…ar. (#1810) (#1811) * Tweak the store loader config warning stuff a bit to make the tests not actually do the sleeps. Also allow bypassing the sleep via env var. Standardize some of the buffered logger stuff too. * Add changelog entry. * Fix imports in app/store_loader_test.go. * Move the buffered logger to internal because the rosetta stuff needed it (was included in the non-unit-test-only app/test_helpers.go file) but couldn't get it because it wasn't part of accessible stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR primarily adds a check of the
PIO_ACKWARNenvironment variable. If it exists, and isn't something false-like (i.e."0","f", '"F","false","False", or"FALSE"`), the 30-second sleep is skipped after issuing the config warnings.This PR also:
app/app.go#New. This made tests on the wrapper stuff easier since I could always use a mock store loader for them.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes