1726 marker creation missing metadata #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iramiller
previously approved these changes
Nov 1, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1728 +/- ##
==========================================
- Coverage 68.77% 68.72% -0.06%
==========================================
Files 288 288
Lines 36483 36522 +39
==========================================
+ Hits 25092 25099 +7
- Misses 10039 10069 +30
- Partials 1352 1354 +2
|
Taztingo
previously approved these changes
Nov 1, 2023
nullpointer0x00
dismissed stale reviews from Taztingo and iramiller
via
67f9e74
SpicyLemon
reviewed
Nov 2, 2023
SpicyLemon
reviewed
Nov 2, 2023
…reate test for rc2 and update existing tests to have logs.
SpicyLemon
reviewed
Nov 2, 2023
SpicyLemon
reviewed
Nov 2, 2023
SpicyLemon
reviewed
Nov 2, 2023
added 5 commits
November 2, 2023 17:21
iramiller
approved these changes
Nov 2, 2023
SpicyLemon
approved these changes
Nov 2, 2023
Taztingo
deleted the
nullpointer0x00/1726-marker-creation-missing-metadata
branch
SpicyLemon
pushed a commit
that referenced
this pull request
Nov 3, 2023
* cast client state to 07-tendermint obj, fail to unknown * return chainid instead of assign * update comment * change GetChainID method signature, add upgrade handler for creating denom metadata * fix denom setting in markerMetadata * Add updateIbcMarkerDenomMetadata to saffron and add logs to method. Create test for rc2 and update existing tests to have logs. * Add fix to get correct denom trace. * Change panics to logs. Remove some indentation that is not needed. * Remove chain from description. * Remove chain from description in hooks. Use BankKeeper.SetDenomMetadata. * Update tests --------- Co-authored-by: Matthew Witkowski <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Marker client id was '07-tendermint-71' and causing the issue. Decided just cast it and if not tendermint return "unknown".
closes: #1726
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes