Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arm64 to docker publish workflow #1709

Merged
merged 19 commits into from
Oct 31, 2023
Merged

Add arm64 to docker publish workflow #1709

merged 19 commits into from
Oct 31, 2023

Conversation

nullpointer0x00
Copy link
Contributor

Description

closes: #1634

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 added the CI Continuous Integration and release process label Oct 17, 2023
@nullpointer0x00 nullpointer0x00 added this to the v1.17.0 milestone Oct 17, 2023
@nullpointer0x00 nullpointer0x00 self-assigned this Oct 17, 2023
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review October 17, 2023 21:20
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner October 17, 2023 21:20
@SpicyLemon
Copy link
Contributor

The docker publish action is failing:

 > [linux/amd64 run 4/6] COPY --from=build /go/src/github.com/provenance-io/provenance/vendor/github.com/CosmWasm/wasmvm/internal/api/libwasmvm..so /usr/local/lib:
------
Dockerfile:39
--------------------
  37 |         rm -rf /var/lib/apt/lists/
  38 |     
  39 | >>> COPY --from=build /go/src/github.com/provenance-io/provenance/vendor/github.com/CosmWasm/wasmvm/internal/api/libwasmvm.$ARCH.so /usr/local/lib
  40 |     COPY --from=build /go/bin/provenanced /usr/bin/provenanced
  41 |     
--------------------
ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref og41bfipp9bxrbsg3ryn46uv5::ko8qnspaa5pgrom4x3vn57x2c: "/go/src/github.com/provenance-io/provenance/vendor/github.com/CosmWasm/wasmvm/internal/api/libwasmvm..so": not found
Error: buildx failed with: ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref og41bfipp9bxrbsg3ryn46uv5::ko8qnspaa5pgrom4x3vn57x2c: "/go/src/github.com/provenance-io/provenance/vendor/github.com/CosmWasm/wasmvm/internal/api/libwasmvm..so": not found

@nullpointer0x00
Copy link
Contributor Author

@SpicyLemon I know it is failing. Have been in the middle of fixing it. Meant to move it back to draft mode.

@nullpointer0x00 nullpointer0x00 marked this pull request as draft October 18, 2023 23:21
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review October 20, 2023 16:51
Taztingo
Taztingo previously approved these changes Oct 30, 2023
View reviewed changes
iramiller
iramiller previously approved these changes Oct 31, 2023
View reviewed changes
@nullpointer0x00 nullpointer0x00 dismissed stale reviews from iramiller and Taztingo via 5a2949f October 31, 2023 16:17
@nullpointer0x00 nullpointer0x00 merged commit c58c373 into main Oct 31, 2023
27 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/1634-arm64-container-builds branch October 31, 2023 16:52
SpicyLemon pushed a commit that referenced this pull request Nov 1, 2023
@nullpointer0x00 @SpicyLemon
Add arm64 to docker publish workflow (#1709)
aa01c96 
* add arm64 to docker publish workflow

* add comments back to file

* Add changelog entry

* temp add of my branch

* remove test

* second attempt

* remove test

* add a fix and temp publish docker from branch

* better logic

* try setting arg another way

* remove ARCH arg from build, use uname from container to copy over correct wasm file

* remove temp wasm files

* Add arch check and error message for clarity

* remove custom branch from workflow

* test build platform

* remove cleveldb, check build archs

* remove branch
@SpicyLemon SpicyLemon mentioned this pull request Nov 1, 2023
Merged
8 tasks
SpicyLemon added a commit that referenced this pull request Nov 3, 2023
@SpicyLemon @nullpointer0x00
@Taztingo @iramiller @webbushka
Backport: arm64 docker container (#1709), exchange keeper tests and f…
f84a50f 
…ixes (#1713) and some readme updates (#1722, #1725) (#1727)

* Add arm64 to docker publish workflow (#1709)

* add arm64 to docker publish workflow

* add comments back to file

* Add changelog entry

* temp add of my branch

* remove test

* second attempt

* remove test

* add a fix and temp publish docker from branch

* better logic

* try setting arg another way

* remove ARCH arg from build, use uname from container to copy over correct wasm file

* remove temp wasm files

* Add arch check and error message for clarity

* remove custom branch from workflow

* test build platform

* remove cleveldb, check build archs

* remove branch

* Add Acknowledgement section to Oracle README. (#1722)

* Add Acknowledgement section.

* Add missing link.

---------

Co-authored-by: Ira Miller <[email protected]>

* Updates to readme from marketing (#1725)

* Dwedul/1699 exchange keeper tests (#1713)

* [1699]: Unit tests on params.

* [1699]: Unit tests on the flat fee getters.

* [1699]: Unit tests on the ratio fee getters and calculators.

* [1699]: Unit tests on the flat fee validators.

* [1699]: Unit tests on ValidateAskPrice.

* [1699]: Change TestSuite.ratio to use ParseFeeRatio.

* [1699]: Unit tests on ValidateBuyerSettlementFee.

* [1699]: Unit tests on UpdateFees.

* [1699]: Create Keeper.IsMarketKnown and tweak the comments on IsMarketActive.

* [1699]: Unit tests on IsMarketKnown and IsMarketActive.

* [1699]: Unit tests on UpdateMarketActive.

* [1699]: Unit tests 0on IsUserSettlementAllowed and UpdateUserSettlementAllowed.

* [1699]: Unit tests on HasPermission and each of the specific Can... permission checkers.

* [1699]: Fix getAccessGrants.

* [1699]: Unit tests on GetUserPermissions and GetAccessGrants.

* [1699]: Unit tests on UpdatePermissions.

* [1699]: Unit tests on GetReqAttrsAsk, GetReqAttrsBid, CanCreateAsk, and CanCreateBid.

* [1699]: Make NewEventMarketPermissionsUpdated just take in the admin as a string since that's what we've got it as when we want to create that event.

* [1699]: Make NewEventMarketReqAttrUpdated just take in the admin as a string since that's what we've got it as when we want to create that event.

* [1699]: Unit tests on UpdateReqAttrs.

* [1699]: Unit tests on GetMarketAccount.

* [1699]: Unit tests on GetMarketDetails.

* [1699]: Remove 'Calls' from the field names of the mock keeper ...Calls structs.

* [1699]: Update NewEventMarketDetailsUpdated to take in a string since that's what we've already got it as everywhere.

* [1699]: Update NewEventMarketActiveUpdated, NewEventMarketEnabled, and NewEventMarketDisabled to take in an updatedBy string (instead of AccAddress) since that's what we've already got it as anyway.

* [1699]: Change NewEventMarketWithdraw to take in withdrawnBy as a string since we don't need it as an addr anywhere.

* [1699]: Update NewEventMarketUserSettleUpdated, NewEventMarketUserSettleEnabled, and NewEventMarketUserSettleDisabled to take in updatedBy as a string.

* [1699]: Update exchange.NewEventOrderCancelled to take in cancelledBy as a string.

* [1699]: A little cleanup in TestTypedEventToEvent.

* [1699]: Unit tests on UpdateMarketDetails.

* [1699]: Change NewAccountResultsMap to NewAccountModifierMap and have NewAccount modify the provided account directly since that's how that func is used.

* [1699]: Unit tests on CreateMarket.

* [1699]: Unit tests on GetMarket and IterateMarkets.

* [1699]: A little cleanup in TestKeeper_CreateMarket since I have SetAccount update the GetAccount results in the mock account keeper.

* [1699]: Unit tests on GetMarketBrief.

* [1699]: Unit tests on WithdrawMarketFunds.

* [1699]: Unit tests on ValidateMarket.

* [1699]: Clean up the market unit tests by not passing the *TestSuite around needlessly.

* [1699] Unit tests on GetOrder.

* [1699]: Unit tests on GetOrderByExternalID.

* [1699]: Fix setOrderInStore to check the store correctly for an existing external id.

* [1699]: Add IsReqAttrMatch unit test case.

* [1699]: Unit tests on CreateAskOrder and CreateBidOrder.

* [1699]: Unit tests on CancelOrder.

* [1699]: Unit tests on SetOrderExternalID.

* [1699]: In parseOrderStoreKeyValue, include the failed order id when it's available.

* [1699]: Unit tests on IterateOrders.

* [1699]: Unit tests on IterateMarketOrders, IterateAddressOrders, and IterateAssetOrders.

* [1699]: In InitGenesis, ensure that the last order id is at least the largest order id, and include the hold error in the returned error.

* [1699]: Unit tests on InitGenesis and ExportGenesis.

* [1699]: Create expEvents using var instead of empty slice since assertEqualEvents doesn't care about nil vs empty. Call assertEqualEvents in TestKeeper_SetOrderExternalID.

* [1699]: Unit tests on FillBids.

* [1699]: Unit tests on FillAsks.

* [1699]: Unit tests on SettleOrders.

* [1699]: Take the stdlibCtx out of the TestSuite and delete the unused int and intStr methods. Replace assertErrorContents with assertErrorContentsf.

* [1699]: In OrderFeeCalc, return an error if the market does not exist.

* [1699]: Unit tests on the OrderFeeCalc query.

* [1699]: In GetOrderByExternalID, return an error if either the market is zero or no external id is given.

* [1699]: Unit tests on GetOrder and GetOrderByExternalID.

* [1699]: Fix the order index queries to properly get the orders.

* [1699]: Modify filteredPaginateAfterOrder with key to return a NextKey that's a hit instead of just the next key the iterator sees. This way, it matches the NextKey behavior when using Offset instead.

* [1699]: In getOrderIterator, for the reverse iterator, the 'start' orderID should be one more than the afterOrderID.

* [1699]: Unit tests on the GetMarketOrders query.

* [1699]: Include the invalid owner in the error from GetOwnerOrders.

* [1699]: Unit tests on the GetOwnerOrders query.

* [1699]: Unit tests on the GetAssetOrders query.

* [1699]: Add a unit test on each of the order iterator queries for a case when the page request is invalid.

* [1699]: Fix GetAllOrders.

* [1699]: Unit tests on GetAllOrders.

* [1699]: Change the querySetupFunc to not take in the context, and just do a swaparoo on the context in the test suite.

* [1699]: Set the address in the QueryGetMarketResponse.

* [1699]: Unit tests on the GetMarket query. Create requireCreateMarketUnmocked and use that everywhere in the query tests.

* [1699]: Unit tests on the GetAllMarkets query.

* [1699]: Unit tests on the Params query.

* [1699]: Unit tests on the ValidateCreateMarket query.

* [1699]: Unit tests on the ValidateMarket query.

* [1699]: Unit tests on the ValidateManageFees query.

* [1699]: Remove todo about discussing the DefaultDefaultSplit value. Best consensus was that 5% seems alright until we know better.

* [1699]: Comment change on the querySetupFunc definition.

* [1699]: Unit tests on the CreateAsk and CreateBid endpoints.

* [1699]: Unit tests on the CancelOrder endpoint.

* [1699]: change IsMarketActive to only return true if the market is both known and active.

* [1699]: Add saffron-rc2 no-op upgrade entry.

* [1699]: In FillBids, calculate the seller settlement ratio fee off the total price instead of each order individually.

* [1699]: Unit tests on FillBids. Extract the balance checking stuff so it's easier for several tests to use.

* [1699]: Unit tests on FillAsks.

* [1699]: Unit tests on the MarketSettle endpoint.

* [1699]: Fix error message from MarketSetOrderExternalID when admin doesn't have permission since they might not actually be uuids.

* [1699]: Unit tests on the MarketSetOrderExternalID endpoint.

* [1699] Unit tests on the MarketWithdraw endpoint.

* [1699]: Unit tests on the MarketUpdateDetails endpoint. Replace uses of requireCreateMarket in the msg_server_test file (with requireCreateMarketUnmocked).

* [1699]: Unit tests on the MarketUpdateEnabled and MarketUpdateUserSettle endpoints.

* [1699]: Unit tests on the MarketManagePermissions and MarketManageReqAttrs endpoints.

* [1699]: Unit tests on the GovCreateMarket, GovManageFees, and GovUpdateParams endpoints. All done with tests.

* [1699]: Mark v1.17.0-rc1 in the changelog.

* [1699]: Add changelog entry.

* [1699]: clean up some of the expected event creation stuff.

* [1699]: Move all the generic keeper test helper funcs to a new suite_test.go file as well as the TestSuite definition. Do a little cleanup to use those in a few places where it made sense.

* [1699]: Remove some unneeded things from the TestSuite.

* [1699]: Some comment clarifications.

* [1699]: Make TestSuite.badKey for changing a key into a bad version of it for the tests that want an incorrect key entry.

* [1699]: Do some of the market id comparisons as ints for better failure output.

* [1699]: Refactor grpc_query_test to be similar to msg_server_test with the typed test definitions and test cases.

* [1699]: Add some test cases to the ValidateManageFees query where everything in the msg is okay, but results in a bad market setup.

* [1699]: Underscore some unused followup func arguments in msg_server_test.

* [1699]: Create agCanOnly, agCanAllBut, and agCanEverything and use them in severl test cases where similar stuff was being done the hard way.

* [1699]: Clean up some of the follow-up args type defs.

* Mark v1.17.0-rc2 in the changelog and release notes.

* Undo the marking of v1.17.0-rc2 since we might have other stuff come in for it.

* Move the 1634 changelog entry up in the unlreleased section where it should be for now.

---------

Co-authored-by: Carlton Hanna <[email protected]>
Co-authored-by: Matt Witkowski <[email protected]>
Co-authored-by: Ira Miller <[email protected]>
Co-authored-by: AJ Webb <[email protected]>
@Taztingo Taztingo mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpicyLemon SpicyLemon SpicyLemon approved these changes

@Taztingo Taztingo Taztingo approved these changes

@iramiller iramiller iramiller approved these changes

Assignees

@nullpointer0x00 nullpointer0x00

Labels
CI Continuous Integration and release process
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

ARM64 Container Builds
4 participants
@nullpointer0x00 @SpicyLemon @iramiller @Taztingo