Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker ics20 hooks #1678

Merged
merged 83 commits into from
Oct 10, 2023
Merged

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Sep 11, 2023

Description

closes: #1127


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 self-assigned this Sep 11, 2023
@nullpointer0x00 nullpointer0x00 added marker Marker Module ibc inter-blockchain communication labels Sep 11, 2023
@nullpointer0x00 nullpointer0x00 added this to the v1.17.0 milestone Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1678 (dea154d) into main (28948e8) will decrease coverage by 0.18%.
Report is 4 commits behind head on main.
The diff coverage is 66.66%.

❗ Current head dea154d differs from pull request most recent head e37ddef. Consider uploading reports for the commit e37ddef to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
- Coverage   64.85%   64.67%   -0.18%     
==========================================
  Files         262      269       +7     
  Lines       31397    31812     +415     
==========================================
+ Hits        20361    20576     +215     
- Misses       9752     9918     +166     
- Partials     1284     1318      +34     
Files Coverage Δ
app/app.go 84.67% <100.00%> (+0.14%) ⬆️
x/marker/keeper/marker.go 57.21% <0.00%> (-0.19%) ⬇️
x/ibchooks/ics4_middleware.go 32.65% <62.50%> (+11.22%) ⬆️
x/ibchooks/types/types.go 59.18% <90.62%> (ø)
x/ibchooks/ibc_hooks.go 64.51% <64.51%> (ø)
x/ibchooks/marker_hooks.go 70.73% <70.73%> (ø)
x/ibchooks/wasm_hook.go 44.65% <55.55%> (-6.46%) ⬇️

... and 4 files with indirect coverage changes

x/ibchooks/wasm_hook.go Fixed Show fixed Hide fixed
x/ibchooks/marker_hooks.go Outdated Show resolved Hide resolved
x/ibchooks/marker_hooks.go Outdated Show resolved Hide resolved
x/ibchooks/marker_hooks.go Outdated Show resolved Hide resolved
Taztingo
Taztingo previously approved these changes Oct 10, 2023
Copy link
Contributor

@Taztingo Taztingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) October 10, 2023 21:52
@nullpointer0x00 nullpointer0x00 merged commit e4b5d91 into main Oct 10, 2023
35 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/1127-marker-ibs20-hooks branch October 10, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ibc inter-blockchain communication marker Marker Module
Projects
None yet
4 participants