Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add genesis export/init for marker deny send lists #1662

Conversation

nullpointer0x00
Copy link
Contributor

Description

closes: #1660


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 added the marker Marker Module label Aug 24, 2023
@nullpointer0x00 nullpointer0x00 added this to the v1.17.0 milestone Aug 24, 2023
@nullpointer0x00 nullpointer0x00 self-assigned this Aug 24, 2023
@nullpointer0x00 nullpointer0x00 changed the title Aadd genesis export/init for marker deny send lists Add genesis export/init for marker deny send lists Aug 24, 2023
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review August 30, 2023 15:36
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner August 30, 2023 15:36
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1662 (ebbdd7a) into main (8556cd6) will decrease coverage by 0.02%.
The diff coverage is 60.31%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1662      +/-   ##
==========================================
- Coverage   64.78%   64.77%   -0.02%     
==========================================
  Files         261      261              
  Lines       31249    31306      +57     
==========================================
+ Hits        20246    20279      +33     
- Misses       9724     9746      +22     
- Partials     1279     1281       +2     
Files Changed Coverage Δ
x/marker/keeper/genesis.go 7.22% <0.00%> (-1.35%) ⬇️
x/marker/keeper/keeper.go 75.00% <0.00%> (-4.42%) ⬇️
x/marker/simulation/operations.go 79.47% <89.65%> (+0.63%) ⬆️
x/marker/types/genesis.go 40.74% <100.00%> (+2.27%) ⬆️
x/marker/types/key.go 82.14% <100.00%> (+4.87%) ⬆️

Taztingo
Taztingo previously approved these changes Aug 30, 2023
Copy link
Contributor

@Taztingo Taztingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) August 31, 2023 18:35
Taztingo
Taztingo previously approved these changes Sep 6, 2023
@nullpointer0x00 nullpointer0x00 merged commit 183734e into main Sep 7, 2023
40 of 41 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/1660-add-genesis-export-init-marker-deny-send branch September 7, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marker Marker Module
Projects
Development

Successfully merging this pull request may close these issues.

Add genesis export/import for Deny Send Addresses in Marker module
4 participants