Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Net Asset Value to Markers #1640

Merged

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Jul 31, 2023

Description

closes: #1470


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 self-assigned this Jul 31, 2023
@nullpointer0x00 nullpointer0x00 added this to the v1.17.0 milestone Jul 31, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1640 (119588b) into main (d7598d2) will decrease coverage by 0.02%.
The diff coverage is 67.60%.

❗ Current head 119588b differs from pull request most recent head bdb13b5. Consider uploading reports for the commit bdb13b5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1640      +/-   ##
==========================================
- Coverage   64.70%   64.68%   -0.02%     
==========================================
  Files         261      245      -16     
  Lines       30937    30611     -326     
==========================================
- Hits        20017    19801     -216     
+ Misses       9657     9544     -113     
- Partials     1263     1266       +3     
Files Changed Coverage Δ
x/marker/keeper/genesis.go 8.57% <0.00%> (-3.93%) ⬇️
x/marker/keeper/query_server.go 0.00% <0.00%> (ø)
x/marker/types/denom.go 90.52% <ø> (ø)
x/marker/types/events.go 0.00% <0.00%> (ø)
x/marker/types/genesis.go 38.46% <50.00%> (-6.54%) ⬇️
x/marker/keeper/keeper.go 79.41% <68.33%> (-8.75%) ⬇️
x/marker/client/cli/query.go 66.15% <71.42%> (+0.62%) ⬆️
x/marker/keeper/marker.go 56.75% <72.72%> (+0.28%) ⬆️
x/marker/types/msg.go 52.59% <82.35%> (+2.47%) ⬆️
x/marker/client/cli/tx.go 64.05% <86.11%> (+1.51%) ⬆️
... and 4 more

... and 18 files with indirect coverage changes

@nullpointer0x00 nullpointer0x00 changed the title add an initial proto object for marker nav Add Net Asset Value to Markers Aug 1, 2023
x/marker/client/cli/tx.go Outdated Show resolved Hide resolved
Taztingo
Taztingo previously approved these changes Aug 31, 2023
Copy link
Contributor

@Taztingo Taztingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) September 6, 2023 17:27
@nullpointer0x00 nullpointer0x00 merged commit 8556cd6 into main Sep 6, 2023
36 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/1470-add-share-pricing-to-markers branch September 6, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exchange marker Marker Module
Projects
Development

Successfully merging this pull request may close these issues.

Add share pricing attribute to Markers
3 participants