-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Net Asset Value to Markers #1640
Merged
nullpointer0x00
merged 114 commits into
main
from
nullpointer0x00/1470-add-share-pricing-to-markers
Sep 6, 2023
Merged
Add Net Asset Value to Markers #1640
nullpointer0x00
merged 114 commits into
main
from
nullpointer0x00/1470-add-share-pricing-to-markers
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1640 +/- ##
==========================================
- Coverage 64.70% 64.68% -0.02%
==========================================
Files 261 245 -16
Lines 30937 30611 -326
==========================================
- Hits 20017 19801 -216
+ Misses 9657 9544 -113
- Partials 1263 1266 +3
|
nullpointer0x00
changed the title
add an initial proto object for marker nav
Add Net Asset Value to Markers
Aug 1, 2023
…e all uses of constructor
…d method comments
… add msg validatebasic and get signers
Taztingo
reviewed
Aug 30, 2023
Taztingo
reviewed
Aug 30, 2023
Taztingo
reviewed
Aug 30, 2023
Taztingo
reviewed
Aug 30, 2023
Taztingo
reviewed
Aug 30, 2023
Taztingo
reviewed
Aug 30, 2023
Taztingo
reviewed
Aug 30, 2023
Taztingo
previously approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Taztingo
approved these changes
Sep 6, 2023
iramiller
reviewed
Sep 6, 2023
iramiller
approved these changes
Sep 6, 2023
nullpointer0x00
deleted the
nullpointer0x00/1470-add-share-pricing-to-markers
branch
September 6, 2023 18:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1470
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes