[1752]: Clean up codec.go by getting rid of the amino codec stuff and…

… switching to the allRequestMsgs pattern used in other modules.

x/quarantine/codec.go

@@ -1,38 +1,19 @@
 package quarantine
 
 import (
-	"github.com/cosmos/cosmos-sdk/codec"
+	"github.com/gogo/protobuf/proto"
+
 	codectypes "github.com/cosmos/cosmos-sdk/codec/types"
-	cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/types/msgservice"
 )
 
 func RegisterInterfaces(registry codectypes.InterfaceRegistry) {
-	registry.RegisterImplementations((*sdk.Msg)(nil),
-		&MsgOptIn{},
-		&MsgOptOut{},
-		&MsgAccept{},
-		&MsgDecline{},
-		&MsgUpdateAutoResponses{},
-	)
+	messages := make([]proto.Message, len(allRequestMsgs))
+	for i, msg := range allRequestMsgs {
+		messages[i] = msg
+	}
+	registry.RegisterImplementations((*sdk.Msg)(nil), messages...)
 
 	msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc)
 }
-
-var (
-	amino = codec.NewLegacyAmino()
-
-	// ModuleCdc references the global x/quarantine module codec. Note, the codec should
-	// ONLY be used in certain instances of tests and for JSON encoding as Amino is
-	// still used for that purpose.
-	//
-	// The actual codec used for serialization should be provided to x/quarantine and
-	// defined at the application level.
-	ModuleCdc = codec.NewAminoCodec(amino)
-)
-
-func init() {
-	cryptocodec.RegisterCrypto(amino)
-	sdk.RegisterLegacyAminoCodec(amino)
-}

x/quarantine/msgs.go

@@ -9,7 +9,13 @@ import (
 	qerrors "github.com/provenance-io/provenance/x/quarantine/errors"
 )
 
-var _ sdk.Msg = &MsgOptIn{}
+var allRequestMsgs = []sdk.Msg{
+	(*MsgOptIn)(nil),
+	(*MsgOptOut)(nil),
+	(*MsgAccept)(nil),
+	(*MsgDecline)(nil),
+	(*MsgUpdateAutoResponses)(nil),
+}
 
 // NewMsgOptIn creates a new msg to opt in to account quarantine.
 func NewMsgOptIn(toAddr sdk.AccAddress) *MsgOptIn {
@@ -32,8 +38,6 @@ func (msg MsgOptIn) GetSigners() []sdk.AccAddress {
 	return []sdk.AccAddress{addr}
 }
 
-var _ sdk.Msg = &MsgOptOut{}
-
 // NewMsgOptOut creates a new msg to opt out of account quarantine.
 func NewMsgOptOut(toAddr sdk.AccAddress) *MsgOptOut {
 	return &MsgOptOut{
@@ -55,8 +59,6 @@ func (msg MsgOptOut) GetSigners() []sdk.AccAddress {
 	return []sdk.AccAddress{addr}
 }
 
-var _ sdk.Msg = &MsgAccept{}
-
 // NewMsgAccept creates a new msg to accept quarantined funds.
 func NewMsgAccept(toAddr sdk.AccAddress, fromAddrsStrs []string, permanent bool) *MsgAccept {
 	return &MsgAccept{
@@ -88,8 +90,6 @@ func (msg MsgAccept) GetSigners() []sdk.AccAddress {
 	return []sdk.AccAddress{addr}
 }
 
-var _ sdk.Msg = &MsgDecline{}
-
 // NewMsgDecline creates a new msg to decline quarantined funds.
 func NewMsgDecline(toAddr sdk.AccAddress, fromAddrsStrs []string, permanent bool) *MsgDecline {
 	return &MsgDecline{
@@ -121,8 +121,6 @@ func (msg MsgDecline) GetSigners() []sdk.AccAddress {
 	return []sdk.AccAddress{addr}
 }
 
-var _ sdk.Msg = &MsgUpdateAutoResponses{}
-
 // NewMsgUpdateAutoResponses creates a new msg to update quarantined auto-responses.
 func NewMsgUpdateAutoResponses(toAddr sdk.AccAddress, updates []*AutoResponseUpdate) *MsgUpdateAutoResponses {
 	return &MsgUpdateAutoResponses{