Apply linter and fix basic linting issues on codebase (#1941) #6904
Annotations
10 errors and 1 warning
golangci-lint:
internal/statesync/statesync.go#L16
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
golangci-lint:
x/quarantine/quarantine.go#L88
if-return: redundant if ...; err != nil check, just return error instead. (revive)
|
golangci-lint:
internal/provwasm/simulation.go#L85
unused-parameter: parameter 'simState' seems to be unused, consider removing or renaming it as _ (revive)
|
golangci-lint:
internal/handlers/msg_service_router.go#L103
(*PioMsgServiceRouter).registerMsgServiceHandler - result 0 (error) is always nil (unparam)
|
golangci-lint:
x/trigger/types/msgs.go#L92
func `hasSigners` is unused (unused)
|
golangci-lint:
internal/protocompat/protocompat.go#L8
import 'github.com/golang/protobuf/proto' is not allowed from list 'main' (depguard)
|
golangci-lint:
x/marker/types/msg.go#L16
SA1019: "github.com/cosmos/ibc-go/v8/modules/core/02-client/types" is deprecated: The legacy v1beta1 gov types maintained in this file are deprecated and will be removed in a future release. Please use MsgIBCSoftwareUpgrade and MsgRecoverClient in favour of the legacy v1beta1 gov proposal types. (staticcheck)
|
golangci-lint:
x/marker/keeper/marker.go#L13
SA1019: "github.com/cosmos/ibc-go/v8/modules/core/02-client/types" is deprecated: The legacy v1beta1 gov types maintained in this file are deprecated and will be removed in a future release. Please use MsgIBCSoftwareUpgrade and MsgRecoverClient in favour of the legacy v1beta1 gov proposal types. (staticcheck)
|
golangci-lint:
x/marker/simulation/proposals.go#L36
SA1019: simtypes.WeightedProposalContent is deprecated: Use WeightedProposalMsg instead. (staticcheck)
|
golangci-lint:
x/marker/simulation/proposals.go#L37
SA1019: simtypes.WeightedProposalContent is deprecated: Use WeightedProposalMsg instead. (staticcheck)
|
golangci-lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: technote-space/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|