Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the data column from the asset_pricing table. #572

Merged

Conversation

nullpointer0x00
Copy link
Contributor

Description

closes: #563


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner October 29, 2024 03:37
@nullpointer0x00 nullpointer0x00 marked this pull request as draft October 29, 2024 03:37
iramiller
iramiller previously approved these changes Oct 29, 2024
@nullpointer0x00 nullpointer0x00 self-assigned this Oct 29, 2024
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review October 29, 2024 13:27
@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) October 29, 2024 13:27
@nullpointer0x00 nullpointer0x00 merged commit 54bef14 into main Oct 29, 2024
4 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/563-remove-asset-pricing-data-column branch October 29, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the data column from the asset_pricing table.
2 participants