Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proposer priority number type #533

Merged

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Aug 20, 2024

Description

This PR addresses issue #530, where the validator proposer priority was incorrectly handled as a 32-bit integer (Int). The blockchain represents this value as a 64-bit integer (Long), so this update changes the data type to Long to prevent potential errors and ensure accurate handling of proposer priorities.

closes: #530


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 self-assigned this Aug 20, 2024
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review August 20, 2024 17:10
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner August 20, 2024 17:10
@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) August 20, 2024 17:12
@nullpointer0x00 nullpointer0x00 merged commit 8028c92 into main Aug 20, 2024
4 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/530-validator-priority-display-fix branch August 20, 2024 17:20
@benarena benarena mentioned this pull request Aug 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator Priority displayed as 32-bit int but is a 64-bit int from the chain.
2 participants