Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically add new provenances protos to JsonFormat.TypeRegistry #513

Merged
merged 9 commits into from
Mar 12, 2024

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Mar 8, 2024

Description

closes: #514


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 changed the title Testing Proto Deploy Dynamically add new provenances protos to JsonFormat.TypeRegistry Mar 12, 2024
@nullpointer0x00 nullpointer0x00 self-assigned this Mar 12, 2024
@nullpointer0x00 nullpointer0x00 added this to the v5.7.0 milestone Mar 12, 2024
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review March 12, 2024 15:24
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner March 12, 2024 15:24
@nullpointer0x00 nullpointer0x00 requested a review from a team March 12, 2024 15:24
@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) March 12, 2024 15:25
@nullpointer0x00 nullpointer0x00 merged commit 5c69395 into main Mar 12, 2024
4 checks passed
@nullpointer0x00 nullpointer0x00 deleted the test-protos branch March 12, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Automate the registration of Provenance protobuf module descriptors
2 participants