Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup Start of day fix #497

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Rollup Start of day fix #497

merged 6 commits into from
Oct 30, 2023

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Oct 27, 2023

Description

Found a bug in dlob orderbooks that prevented saving correct information to database.

Add missing change log entry.

Please review testnet explorer hash history from dates Aug 2nd to present. https://explorer.test.provenance.io/dashboard

closes: #496


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review October 30, 2023 16:39
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner October 30, 2023 16:39
@nullpointer0x00 nullpointer0x00 requested a review from a team October 30, 2023 16:39
@nullpointer0x00 nullpointer0x00 merged commit 925ad9d into main Oct 30, 2023
4 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/rollup-fix branch October 30, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update historical job to pull from new order book
2 participants