Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Quarantine and Sanction modules #586

Closed
wants to merge 10 commits into from

Conversation

SpicyLemon
Copy link

@SpicyLemon SpicyLemon commented Nov 21, 2023

Description

Related:

  • #1752: Move quarantine module into the provenance repo
  • #1753: Move sanction module into the provenance repo
  • #1768: Create a new repo to house the quarantine and sanction modules

This PR deletes all the quarantine and sanction go code and deprecates all of their proto stuff.

Those two modules are being moved to the provenance repo:

  • PR 1754: Move quarantine module into the provenance repo (from our fork)
  • PR 1758: Move sanction module into the provenance repo (from our fork)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@SpicyLemon
Copy link
Author

I'm gonna close this PR, at least for now. The plan is to, at some point, merge the release-pio/v0.50.x branch back to main-pio, stomping on everything currently in main-pio. Since x/quarantine and x/sanction won't be in there, that should ultimately remove them from this repo.

@SpicyLemon SpicyLemon closed this Mar 27, 2024
@SpicyLemon SpicyLemon deleted the dwedul/1752-delete-quar-sanct branch December 17, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant