CI fixes

protonemedia · Mar 12, 2024 · 5927810 · 5927810
1 parent a97db7f
commit 5927810
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 14 deletions.
diff --git a/.github/workflows/run-table-tests.yml b/.github/workflows/run-table-tests.yml
@@ -23,6 +23,8 @@ jobs:
             ssr: true
           - php: 8.2
             ssr: true
+          - laravel: 10.0
+            ssr: true
           - db: mysql
             ssr: true
           - db: postgres
@@ -118,14 +120,6 @@ jobs:
           composer require laravel/framework:^${{ matrix.laravel }} --no-interaction --no-suggest
           composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-suggest
 
-      - name: Prepare L10
-        if: ${{ matrix.laravel == '10.0' }}
-        run: |
-          cd app
-          rm composer.lock
-          composer require spatie/phpunit-snapshot-assertions:^5.0 phpunit/phpunit:^10.0 nunomaduro/collision:^7.0 --no-interaction --no-suggest
-          composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-suggest
-
       - name: Prepare tests
         run: |
           cd app

diff --git a/app/.env.example.mysql b/app/.env.example.mysql
@@ -14,7 +14,7 @@ DB_USERNAME=protone_media_db_test
 DB_PASSWORD=secret
 DB_PORT=3306
 
-BROADCAST_DRIVER=pusher
+BROADCAST_DRIVER=reverb
 CACHE_DRIVER=file
 FILESYSTEM_DISK=local
 QUEUE_CONNECTION=sync

diff --git a/app/.env.example.postgres b/app/.env.example.postgres
@@ -14,7 +14,7 @@ DB_USERNAME=protone_media_db_test
 DB_PASSWORD=secret
 DB_PORT=5432
 
-BROADCAST_DRIVER=pusher
+BROADCAST_DRIVER=reverb
 CACHE_DRIVER=file
 FILESYSTEM_DISK=local
 QUEUE_CONNECTION=sync

diff --git a/app/tests/Browser/Form/SelectDependentTest.php b/app/tests/Browser/Form/SelectDependentTest.php
@@ -7,7 +7,7 @@
 
 class SelectDependentTest extends DuskTestCase
 {
-    public function dependentUrls()
+    public static function dependentUrls()
     {
         return [
             ['form/components/selectAsync/dependent'],

diff --git a/app/tests/Browser/ModalTest.php b/app/tests/Browser/ModalTest.php
@@ -264,7 +264,7 @@ public function it_can_have_a_slideover_with_different_max_widths($size, $expect
         });
     }
 
-    public function sizeAndPixels()
+    public static function sizeAndPixels()
     {
         return [
             ['sm', 384],

diff --git a/app/tests/DuskTestCase.php b/app/tests/DuskTestCase.php
@@ -27,7 +27,7 @@ protected function newBrowser($driver)
         return new Browser($driver);
     }
 
-    public function tableUrls()
+    public static function tableUrls()
     {
         return [
             ['/table/users/spatie/'],
@@ -37,7 +37,7 @@ public function tableUrls()
         ];
     }
 
-    public function booleanDataset()
+    public static function booleanDataset()
     {
         return [[false], [true]];
     }