Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude abi.encodeX calls from func-named-parameters #583

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Exclude abi.encodeX calls from func-named-parameters #583

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccffdcb
Exclude abi.encodeX calls from func-named-parameters
0xCLARITY May 23, 2024
3b74499
Fix linting
0xCLARITY May 28, 2024
b9530be
Fix typo in error msg
0xCLARITY Jun 28, 2024
8490cc3
Merge branch 'develop' into exclude-abi-calls-from-named-parameters
0xCLARITY Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions lib/rules/naming/func-named-parameters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ const meta = {
description: 'Function call with four NAMED parameters',
code: 'functionName({ sender: _senderAddress, amount: 1e18, token: _tokenAddress, receiver: _receiverAddress })',
},
{
description: 'abi.encodeX call with four UNNAMED parameters',
code: 'abi.encodePacked(_senderAddress, 1e18, _tokenAddress, _receiverAddress )',
},
],
bad: [
{
Expand Down Expand Up @@ -67,12 +71,24 @@ class FunctionNamedParametersChecker extends BaseChecker {
const qtyNamed = node.names.length
const qtyArgs = node.arguments.length

if (qtyArgs !== 0) {
if (qtyNamed === 0 && qtyArgs > this.maxUnnamedArguments) {
this.error(
node,
`Named parameters missing. MIN unnamed arguments is ${this.maxUnnamedArguments}`
)
if (!this.isAbiCall(node)) {
if (qtyArgs !== 0) {
if (qtyNamed === 0 && qtyArgs > this.maxUnnamedArguments) {
this.error(
node,
`Named parameters missing. MIN unnamed arguments is ${this.maxUnnamedArguments}`
)
}
}
}
}

isAbiCall(node) {
if (node.expression.type === 'MemberAccess') {
if (node.expression.expression.type === 'Identifier') {
if (node.expression.expression.name === 'abi') {
return true
}
}
}
}
Expand Down
Loading