Feature: Omen Airdrop Popup Modal Version 2 #2220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/2170
…ange into feature/2170
Mi-Lan
suggested changes
Aug 25, 2021
There was a problem hiding this comment.
@Frankaus Hey men I wen't through it once briefly and played around. I would suggest going through it all again and try to implement what I wrote. You have lots of stuff that its not necessary and just adds extra lines for no reason...
Frankaus
commented
Aug 26, 2021
| @@ -83,7 +84,7 @@ export const ModalAirdrop = (props: Props) => { | |||
| <IconClose hoverEffect={true} onClick={onClose} /> | |||
| </ModalNavigation> | |||
| <Graphic /> | |||
| <TYPE.heading2 color={'text1'} fontWeight={500} margin={'32px 0px 12px'}> | |||
| <TYPE.heading2 color={'text1'} fontWeight={500} margin={'24px 0px 12px'}> | |||
There was a problem hiding this comment.
I edited the margin top here to 24px because the Graphic above has a margin bottom of 8px. So together they add up to 32px as per the figma design
|
Testing
|
pimato
approved these changes
Aug 27, 2021
pimato
approved these changes
Aug 27, 2021
Mi-Lan
reviewed
Aug 30, 2021
Mi-Lan
reviewed
Aug 30, 2021
Mi-Lan
reviewed
Aug 30, 2021
Mi-Lan
reviewed
Aug 30, 2021
Mi-Lan
reviewed
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2170
closes #2230
Created Dai warning banner if user has not funded his account with Dai. Added texts and removed the check address functionality.
Testing