Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed comparison of empty repeated/map extensions. #19432

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixed comparison of empty repeated/map extensions. #19432

wants to merge 1 commit into from
+54 −17

Commits on Nov 27, 2024

  1. Fixed comparison of empty repeated/map extensions. 

    Repeated/map extensions are semantically equivalent to an extension that is not present at all. We had code paths that were treating them differently, which led to incorrect results.

In particular, we were considering `{.repeated_ext = []}` to be different from `{}` when comparing with `upb_Message_IsEqual()`.  This change fixes this bug so that they will be considered equivalent.

PiperOrigin-RevId: 700787434
    @haberman @copybara-github
    haberman authored and copybara-github committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5a1aa69 View commit details
    Browse the repository at this point in the history