Duplicate buffer for thread-safe aliasing. #19405
Open
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Fixes #10697: UnsafeDirectNioDecoder modifies shared buffer instance when performing aliased read. I've included a test-ish reproducer in form of a unit test that fails fairly reliably, let me know whether you'd want this merged. Closes #19405 COPYBARA_INTEGRATE_REVIEW=#19405 from mernst-github:mernst/aliasing 1d97209 FUTURE_COPYBARA_INTEGRATE_REVIEW=#19405 from mernst-github:mernst/aliasing 1d97209 PiperOrigin-RevId: 700734396
copybara protocolbuffers#19424 introduces a "var unused" which breaks Java 8 build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10697: UnsafeDirectNioDecoder modifies shared buffer instance when performing aliased read.
I've included a test-ish reproducer in form of a unit test that fails fairly reliably, let me know whether you'd want this merged.